Network Icon not changed when changing "Show drive icons from Explorer"

Bug reports will be moved here when the described bug has been fixed

Moderators: white, sheep, Hacker, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 8029
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Network Icon not changed when changing "Show drive icons from Explorer"

Post by *petermad » 2018-08-09, 01:06 UTC

If I in Options -> Icons, check or uncheck the "Show drive icons from Explorer" then the drive icon for Network Neighborhood is not changed until I restart TC.

In TC 9.0 b10-12 the icon was changed when enabling the setting, but not when disabling it, but since TC 9.0 b13 the icon doesn't change neither when enabling, nor when disabling the setting (until restart of TC).
Last edited by petermad on 2018-08-12, 15:50 UTC, edited 2 times in total.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36425
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Network Icon not changed when changing "Show drive icons from Explorer"

Post by *ghisler(Author) » 2018-08-09, 09:52 UTC

Thanks, I can confirm it, also for Computer and personal files in Alt+F1/F2.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8029
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: Network Icon not changed when changing "Show drive icons from Explorer"

Post by *petermad » 2018-08-09, 14:49 UTC

also for Computer and personal files in Alt+F1/F2
Hmm, I cannnot reproduce that, neither with Windows 10 nor Windows 7...
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36425
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Network Icon not changed when changing "Show drive icons from Explorer"

Post by *ghisler(Author) » 2018-08-10, 08:53 UTC

Example:
1. Start TC 9.20 or 9.21 rc3
2. Check icons in Alt+F1 - by default, it has the Explorer icons
3. Change to internal drive icons via Configuration - Options - Icons
4. Check icons in Alt+F1 - it still has the Explorer icons
5. Close and re-open TC
6. Check icons in Alt+F1 - it now has the internal icons
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8029
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: Network Icon not changed when changing "Show drive icons from Explorer"

Post by *petermad » 2018-08-10, 11:59 UTC

1. Start TC 9.20 or 9.21 rc3
2. Check icons in Alt+F1 - by default, it has the Explorer icons
3. Change to internal drive icons via Configuration - Options - Icons
Just what I did.
4. Check icons in Alt+F1 - it still has the Explorer icons
Not what I see, here the icons are changed immediately.

But what I do see is this:
1. Disable "Show drive icons from Explorer".
2. Open Network Neighborhood in left panel.
3. Enable "Show drive icons from Explorer", don't open the drive combo box, but notice the icon in the box - it is changed to Explorer icon.
4. Disable "Show drive icons from Explorer" again, don't open the drive combo box, but notice the icon in the box - it is NOT changed back from Explorer icon.
5. In the drive button bar (not the combo box), click drive C. and then click the Network button in the drive button bar - the Icon in the combo box is still the Explorer icon.
6. Open the combo-box (Alt-+F1) - NOW the Icons are changed to non-Explorer icons.

The same thing can be observed if I open the "Computer (drive overview)" in the file panel.

It is only when I disable the "Show drive icons from Explorer" option, that the Network and the Computer icons are not changed in the drive combobox until I press Alt+F1, not when I enable the option.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36425
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Network Icon not changed when changing "Show drive icons from Explorer"

Post by *ghisler(Author) » 2018-08-10, 15:43 UTC

The same thing can be observed if I open the "Computer (drive overview)" in the file panel.
The "Computer" virtual folder always uses the Explorer icons.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8029
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: Network Icon not changed when changing "Show drive icons from Explorer"

Post by *petermad » 2018-08-10, 16:01 UTC

License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36425
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Network Icon not changed when changing "Show drive icons from Explorer"

Post by *ghisler(Author) » 2018-08-10, 16:04 UTC

Yes, these should work now too after my change. I have just sent you a private beta, please test with that!
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8029
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: Network Icon not changed when changing "Show drive icons from Explorer"

Post by *petermad » 2018-08-10, 16:27 UTC

Confirmed fixed in TC 9.21 rc3a :-)
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36425
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Network Icon not changed when changing "Show drive icons from Explorer"

Post by *ghisler(Author) » 2018-08-12, 07:10 UTC

Great, thanks!
Author of Total Commander
http://www.ghisler.com

Post Reply