TC 9.50b2 (dark mode): ColorFilterNNColorDark

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
Max33Verstappen
Junior Member
Junior Member
Posts: 2
Joined: 2019-10-21, 18:19 UTC

TC 9.50b2 (dark mode): ColorFilterNNColorDark

Post by *Max33Verstappen » 2019-10-21, 18:31 UTC

Last ColorFilter in darkmode always shown as color "0xFFFFFF"
In my case, my last ColorFilter is:

Code: Select all

ColorFilter6=>Temporary files
ColorFilter6Color=12500670
ColorFilter6ColorDark=4276545,12500670
It's shown as "pure white color" in dark mode. If I modify the "ColorFilter6ColorDark" to

Code: Select all

 ColorFilter6ColorDark=4276545
, problem gone.

umbra
Power Member
Power Member
Posts: 807
Joined: 2012-01-14, 20:41 UTC

Re: TC 9.50b2 (dark mode): ColorFilterNNColorDark

Post by *umbra » 2019-10-21, 18:52 UTC

Is it the same issue as in TC 9.50b1 (dark mode): ColorFilterNNColorDark or something else?
Windows 7 Pro x64, Windows 10 Pro x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38054
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.50b2 (dark mode): ColorFilterNNColorDark

Post by *ghisler(Author) » 2019-10-22, 15:54 UTC

Confirmed, thanks! It happens when the text behind ColorFilter6ColorDark= is longer than 15 characters (length of the string variable, length limited). I will fix it. That second value is there to detect when an older TC version changed these color values without updating the colordark values.
Author of Total Commander
http://www.ghisler.com

Pawel
Junior Member
Junior Member
Posts: 10
Joined: 2018-12-18, 11:54 UTC

Re: TC 9.50b2 (dark mode): ColorFilterNNColorDark

Post by *Pawel » 2019-10-22, 20:26 UTC

ghisler(Author) wrote:
2019-10-22, 15:54 UTC
Confirmed, thanks!
I am trying to define colors by file type in Dark mode (Using TC 9.5 Beta 2).
It works fine in normal mode, but in Dark Mode some colours are not displayed correctly (TC displays some neutral white color).

See the screenshot: http://www.meggamusic.co.uk/shup/1571774976/DarkMode_FileTypes.png

As you can see I defined 15 groups of filters
>RecentFiles
>AudioFiles
>VideoFiles
etc...
Only few of them displays correct colors (for example >AudioFiles (AUDIO.aac) or >ExecutableFiles (EXECUTABLE.exe))
for defined filters. Some filters works fine with one color and not with another (instead displays some random color -> see >TextFiles (TEXT.txt)).

What is going on?

Ps: What is "Dark <->Normal" button?

-Pawel

User avatar
HolgerK
Power Member
Power Member
Posts: 5141
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Re: TC 9.50b2 (dark mode): ColorFilterNNColorDark

Post by *HolgerK » 2019-10-22, 20:44 UTC

What is going on?
As ghisler(Author) already explains:
This happen if the string coded color values right of "ColorFilterNNColorDark=" exceeds 15 characters.
You may edit your wincmd.ini and replace the decimal numbers by hex number:
ColorFilterNNColorDark=16711680,16711680 -> ColorFilterNNColorDark=$FF0000,$FF0000 (untested, but should be max. 15 characters)
Hex format in Pascal:
$BBGGRR : where BB is the hex blue value, GG: hex green value, RR: hex red value

or wait for Beta3.

Regards
Holger
Make our planet great again

User avatar
Usher
Power Member
Power Member
Posts: 563
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.50b2 (dark mode): ColorFilterNNColorDark

Post by *Usher » 2019-10-22, 22:16 UTC

Pawel wrote:
2019-10-22, 20:26 UTC
Ps: What is "Dark <->Normal" button?
Don't be afraid, just click it an you will see. It swaps background color in this window.
Regards from Poland
Andrzej P. Wozniak

Pawel
Junior Member
Junior Member
Posts: 10
Joined: 2018-12-18, 11:54 UTC

Re: TC 9.50b2 (dark mode): ColorFilterNNColorDark

Post by *Pawel » 2019-10-23, 08:55 UTC

@HolgerK
Thanks. Now I see. He must read it as string, then split it and save as integer.
It seems I have to wait for another beta.

@Usher
Thanks for info. So this button just change the background to see how it looks :)

User avatar
Usher
Power Member
Power Member
Posts: 563
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.50b2 (dark mode): ColorFilterNNColorDark

Post by *Usher » 2019-10-23, 11:22 UTC

2Pawel
It's 2-in-1 feature ;-)
You can define best visible colors for 2 modes in 1 place.
Regards from Poland
Andrzej P. Wozniak

User avatar
HolgerK
Power Member
Power Member
Posts: 5141
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Re: TC 9.50b2 (dark mode): ColorFilterNNColorDark

Post by *HolgerK » 2019-11-03, 20:12 UTC

Fixed in TC9.50 Beta 3

Regards
Holger
Make our planet great again

Post Reply