[9.51] Show only differences doesn't work when only whitespaces differ

Please report only one bug per message!

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
MVV
Power Member
Power Member
Posts: 8486
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

[9.51] Show only differences doesn't work when only whitespaces differ

Post by *MVV »

I've just noticed that "Show only differences" feature of file comparer doesn't hide any lines when only whitespaces differ. E.g. I have two files that only differ in tabs/spaces and look identical (all lines are black) with enabled "Ignore repeated spaces" option, and when I check "Show only differences" option, just nothing happens: no lines are hidden, even drop-down list with number of extra lines stays disabled. I think that this feature should hide all file lines if they all look identical with selected compare options. Just because there are no differences at all. This should help to see that there are really no differences.

Code: Select all

MIME-Version: 1.0
Content-Type: application/octet-stream; name="test.7z"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="test.7z"

N3q8ryccAASezQmQIgUAAAAAAAAiAAAAAAAAABqIBoLgGywEqF0AF+B8hm8wiPEisjcd5FpI5/+j
RPdYa/ML+ftwYaUBL0Un4gvKDnMxyaf5W8qnbtrrNJXSxArI1n0SM3+mVrIw/oGowmnNMkJaxiZQ
IY9FGFF64J5a1DFrkFBF5lfrghFVbyZkmwHfCZfuQ/34wbnaF1oFrBjJn4rw8LPQlM8Ob2OWx4Dn
VPgYFQ7fFJD6i5Ui+S4zLLxsq4B0+N5yBRnC9nZEq12ik4fBnabbjaPdqZOKvZfpolGYFqrkiUTs
GzOPK7DlTZhXR+5b1w57qiPKHCUQfm445zaAS+72lHpOPTgFCTah/tRr0Cek7GnZcJEusxDY0BUX
UBZlSMNTAXc/yyq8rEYB3VzVA6wOo92HAlLFyn+F76hqWyjyHvuS2vB7SeOT1d3DIRt1JrXv13Ns
DsEj8zW0WN/QjSMPWLXQy/EZajbDHXbvXkIx9ckIjO7lNeh0CEktfx7Bv9pNC4kBFBnYgtNkGdqh
ZEiCCEcVghyJhbZGFL90ZuelDBXtAD3A53sDz8k011fNrojj6h94OUP78hrn/PSye+mUjoat5uwk
8i3CRNMMQT68YAg0hwDwMmDjkZ173iT/AaawIxs33yOPNQA8PtMpNzVI/ZRXHCyl6Fhm0EcrsmKK
aHlZIRj/axJsBYYM3kojasGUTntqAz0QoYv2zyTPqMDfChvhFCrHalmB8V5mnSltUCEHJ03yC5KA
9f+b3W9UvrxF1qJ79GfZXfCRWe3D9qL4fhF9XtMmspMFZs+1UbDwL4DaET0JwMtdERBaLEzAybEo
qSgW0bfDyD4U5cKdSH17Q+IA7DqYnuqiWQwTmX2rlH3cNE31PPZZR9bPUR8cbb0xCI0mr9uRoMux
XL8Q8VDBg28qmhto0u7ctwDhLSllSADdVtO/RtO7VhUfjFsaoU/ZIe1Q6P4+zUrlYMQOokMQhect
sWjr+2vPCr1yw5pLgx8FyEcbikAEedK7AzwJ9cKe3FVkGM5bBqA/wgtTMEECop60tUfRbQDEjAnn
/tPn4fdn/PSv2nzHFmnCYFzGAA+F2QNYF6kRZYkiHiB203nFEttPkYKpzbDGi0EslNf9eL62Nxt3
2ZkrCAiBzjwwBqvNOKTrQlldpULoUerKeEVlMAoiBOBnQHAuJ9BxWYkW7oq3Buk0b8RsaktrVkNC
Dc4DmsLbDkrjBthx7A2/Rltj8UoVxp9AwWdKiRB9GV7RaDpZMZ25E/lVnTzH0aMBa0GYltjC+uLH
oGRiU8nfB/InvQ/QLaSxy7J03m9h0fIzgttcAiBdswrRwASoNTUIeLPvuQCxj9JnwWsnOffMomAu
dUESmHYMCkT2Rv8TfHS2D1RTk+gGS/o48TLqPnIGo6uVqtcUkO2GfXWJ8x+VGedLcsbuQonzx1Vv
yc4Moljuk4fgjRW5Zqb48dmdBgeBN1tyzZLvBhUTLj3R88jy/m9gKfjMbKJFsA9Mq3N38HuxQZ7X
/NM9O73ty543jodbDmdeTLGTFo4z/6mymgeO/V16SUb7odgFJJyHDGiNKJqfoR7m2ssVH3LBwhzC
hmLZeK57AagyuIwjk5qIKVyN1pnRbuJ9MXB/DlU5hTJUrgAAAIEzB64P1Vy5vRck0/6zcBaxVS5y
xUm8Br3zjB8v1mJR4Vt5+QyoCYq8nbj5O45YME9jvkK8PGek+T/XH7Yo1JVP4j0FKpniZ5qMggB8
toiJFgBESzxBD4U7eSjIi9ave5yixmJ2oDQO2AbuB2W2GAAXBoSwAQlyAAcLAQABIwMBAQVdABAA
AAyAlgoB8/uNpQAA

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39604
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.51] Show only differences doesn't work when only whitespaces differ

Post by *ghisler(Author) »

Unfortunately I cannot open your decoded test.7z archive, neither internally nor with 7zfm.exe.

I guess that Total Commander reports "0 differences found" in the footer. In this case, it will not do anything when you try to show only differences.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 9598
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.51] Show only differences doesn't work when only whitespaces differ

Post by *petermad »

Unfortunately I cannot open your decoded test.7z archive, neither internally nor with 7zfm.exe.
Hmm, I have no problems opening it - I have uploaded the decoded file here: https://madsenworld.dk/tcmd/MVVtest.7z
License #524
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.965 (x64)
TC 3.0 on Android 6.0
Get:
Extended Total Commander Menus | TC Languagebar | TC Dark Help | PHSM-Calendar

User avatar
MVV
Power Member
Power Member
Posts: 8486
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.51] Show only differences doesn't work when only whitespaces differ

Post by *MVV »

ghisler(Author),
I can perfectly open this archive with 7-Zip GUI 19 or with internal TC unpacker (with clean INI).

You're right, TC shows '0 differences'. But I think that in such case this option should just show empty panels, current behaviour is buggy. At least because the checkbox gets enabled but combobox doesn't - this is inconsistent.

Anyway, I don't see any sense in such an exclusion for equal files, option 'show only differences' may really do what it is named for - show only differences, and simply show nothing when there are no differences (just because it does what it is named for). This behaviour will be consistent and will not confuse anyone. Combobox for such cases should get enabled (expected when one enables the option) but change nothing (it will be expected too - no differences so no anchors to show some equal lines so combobox selection doesn't matter).

User avatar
petermad
Power Member
Power Member
Posts: 9598
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.51] Show only differences doesn't work when only whitespaces differ

Post by *petermad »

I tend to agree with MVV.
License #524
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.965 (x64)
TC 3.0 on Android 6.0
Get:
Extended Total Commander Menus | TC Languagebar | TC Dark Help | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39604
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.51] Show only differences doesn't work when only whitespaces differ

Post by *ghisler(Author) »

I can confirm that it gets "0 differences". TC shows the entire files in this case, the user would be very confused when nothing at all would be shown, especially when using "show extra lines"...
Author of Total Commander
http://www.ghisler.com

User avatar
MVV
Power Member
Power Member
Posts: 8486
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.51] Show only differences doesn't work when only whitespaces differ

Post by *MVV »

As you can see, a user (me) is confused that option is broken and something wrong is shown when there are no differences and only differences are expected to be shown.
And that checkbox looks to be broken since it doesn't enable combobox. :D

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39604
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.51] Show only differences doesn't work when only whitespaces differ

Post by *ghisler(Author) »

Well, you can never get it right for everyone...
Author of Total Commander
http://www.ghisler.com

User avatar
MVV
Power Member
Power Member
Posts: 8486
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.51] Show only differences doesn't work when only whitespaces differ

Post by *MVV »

But I really don't think that anyone wants to see equal contents if only differences should be shown. :)

Post Reply