(Solved) Wrong size of associated icon loaded

[Sob]

TC 10.00ß1a (both 32/64 bit), icons in file list use default 16x16 size, but TC loads larger associated icon from ico/dll/exe:

Image: http://web.hisoftware.cz/sob/tc/tc1000b1a-associated-icon-bug.png

In this example, extension ".testicon" is associated to notepad.exe and sample icon (http://web.hisoftware.cz/sob/tc/testicon.ico) is set for it. Icon file contains several variants of size and color depth, where all 16x16 look the same and all larger ones look different. Old TCs correctly load 16x16 variant for both .ico and .testicon. Current beta loads 16x16 for .ico, but something larger for .testicon.

[ghisler(Author)]

How is the icon defined, via Windows association or via TC internal association?

[Sob]

It's standard Windows system-wide association.

I did use TC to create it, because I don't know if that's even possible to do using Win10's terrible UI, but it doesn't make a difference. Using own extension was only a test after I noticed that icons for many other types look more or less different after installing beta TC.

And original test was with Windows 10, but same happens also with Windows 7.

[Usher]

And original test was with Windows 10, but same happens also with Windows 7.

The same happens in Windows XP. TC doesn't use 16x16 associated icons in file lists.

[ghisler(Author)]

Several people have reported this problem, but here it all works fine. I will make a code comparison, maybe I find some changes which could cause this in some cases.

[Usher]

2ghisler(Author)
To be honest, some icons look better. Maybe you should add separate option to choose icon used, it should be something like:
"Icon displayed size" [16x16] and "Icon selected size" [32x32]

[Sob]

Update: It's even more complicated, it depends on the source of associated icon (ico or exe).

In fact, not even older TC does it completely correctly:

Code: Select all

size      10.00b1a         9.51
        file   assoc     file   assoc
      ico exe ico exe  ico exe ico exe
16    16  16  32  32   16  16  16  16
24    32  32  32  24   32  32  32  24
32    32  32  32  32   32  32  32  32
48    48  48  32  48   48  48  32  48
64    48  48  32  64   48  48  32  64

size = configured size
file/ico = size loaded from .ico file (when .ico is shown in list)
file/exe = size loaded from .exe file
assoc/ico = size loaded from associated icon when it's .ico
assoc/exe = size loaded from associated icon when it's .exe

But I guess some of it may perhaps be some Windows limitation, because I see Explorer using only 16, 32 or 48 (never 24 or 64).

Here's better icon for testing, with all combinations of sizes (16/24/32/48/64) and color depths (32/24/8/4), where images have texts showing size and color depth: http://web.hisoftware.cz/sob/tc/testicon2.ico

[l0o]

Glad I found this thread...
In W7 icons looks different in 10.00b1a and for sure not better. :/ I use typical (I guess) 16x16.
(E.g. Irfanview's icos from icon plugin, pdfs icons, notepad 2 icons etc)
In 9.51 all was perfect.

[gdpr deleted 6]

2Sob
thanks for putting the effort into trying this out. Hopefully this helps in finding the root cause of the issue.
(Those smudged icons in TC10 really don't look nice... )

[ghisler(Author)]

I found the reason in the meantime. I tried to forbid dangerous paths like $MFT which can crash the system, but instead disallowed all paths except for these in 2 icon functions...

[Samuel]

Have the same problem - looking forward for b2a.

[Plague]

Same Problem (w7x64 +Tested on w10x64)
Left - 9.51/ Right - 10b1a
Image: http://ipic.su/img/img7/fs/Explorer-Icons.1615474813.png

Go back to 9.51

[Plague]

Hooray!
Looks fine in 10b2 (w7x64 1920x1080).
Big Thanks!

[Flint]

Confirm fixed in b2.

[Sob]

Confirmed, behaviour from 9.51 is back. It's still not completely correct (see my previous post), but if nobody had problem with that, I don't either, as I only use 16x16 icons in file list.