Windows 11: after Dark<>Normal switch, the context menu stops react to OS Light/Dark setting

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Slavic
Senior Member
Senior Member
Posts: 290
Joined: 2006-02-26, 15:41 UTC
Location: Montenegro

Windows 11: after Dark<>Normal switch, the context menu stops react to OS Light/Dark setting

Post by *Slavic »

TC can switch from Light (normal) to Dark mode and back by menu Dark<>Normal or global OS setting Light/Dark (Choose your default app mode). The context file/directory menu on TC panels changes its look accordingly. However, if the TC menu switch has been used once, the look of context menu stops react to changes in OS setting. (I suppose this may happen in Windows 10 as well, but cannot check at this moment.)

How to reproduce:
1. Open OS Settings and navigate to "Choose your default app mode". Keep this window on the screen.
2. Launch TC, check the look of context menu. It should have the same theme (mode) as TC window.
3. Switch the mode in OS Settings. TC window changes its look and context menu changes accordingly.
4. Switch the mode in TC settings. TC window changes and context menu changes as well.
5. Switch the mode in OS settings forth and back. TC window changes but context menu remains the same. It no longer reacts to changes in OS setting.
Desktop: Windows 11 Pro 23H2, TC 11.03(RC). Mobile: Pixel 5a, Android 14, TC 3.42b5
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Windows 11: after Dark<>Normal switch, the context menu stops react to OS Light/Dark setting

Post by *ghisler(Author) »

I will check it, thanks. Howerver, the context menu is drawn by Windows itself, so it may not be possible to change this without restarting Total Commander.

I have checked it - it also happens in Windows 10. The problem is that when you switch between dark/normal mode within Total Commander, the mode is switched to manual. When the notification from Windows comes, it remains on manual mode by mistake. I will fix it.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Windows 11: after Dark<>Normal switch, the context menu stops react to OS Light/Dark setting

Post by *ghisler(Author) »

This should be fixed in Total Commander 10.5 beta, please try it!
Author of Total Commander
https://www.ghisler.com
Slavic
Senior Member
Senior Member
Posts: 290
Joined: 2006-02-26, 15:41 UTC
Location: Montenegro

Re: Windows 11: after Dark<>Normal switch, the context menu stops react to OS Light/Dark setting

Post by *Slavic »

I checked this on Windows 11 builds 22000.613 and the last 22000.652.
With default setting (Only when enabled for Windows 10 apps), this bug no longer happens, context menu consistently uses the same mode as main TC UI.

However, I noticed that if the parameter ForceDarkModeOptions=2 is added to wincmd.ini, it results in permanently light context menu. Either change in TC internal or OS default app mode doesn't affect its look. At least this behaviour is not documented in current help. While not a big issue, please check this or add to documentation.
Desktop: Windows 11 Pro 23H2, TC 11.03(RC). Mobile: Pixel 5a, Android 14, TC 3.42b5
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Windows 11: after Dark<>Normal switch, the context menu stops react to OS Light/Dark setting

Post by *ghisler(Author) »

Thanks for confirming the fix!

As the help describes, ForceDarkModeOptions is meant only for older Windows versions, which don't support native dark mode yet.

Option 2 turns off all Windows 10/11 native dark mode functions:
Handle all dark mode functions internally, except for title bar

This includes the dark context menus.

So don't set ForceDarkModeOptions on Windows 10 or 11.
Author of Total Commander
https://www.ghisler.com
Slavic
Senior Member
Senior Member
Posts: 290
Joined: 2006-02-26, 15:41 UTC
Location: Montenegro

Re: Windows 11: after Dark<>Normal switch, the context menu stops react to OS Light/Dark setting

Post by *Slavic »

OK, the situation is clear now. Could you add the last sentence as a recommendation to the help?
After upgrade of old OS (older than Windows 10 1809) to current Windows 10/11, such parameter will be undesirable and should not be used. This can be concluded from current description of Dark <> Normal menu item, but need some logical steps. Or can ForceDarkModeOptions be simply ignored in 10/11?
Desktop: Windows 11 Pro 23H2, TC 11.03(RC). Mobile: Pixel 5a, Android 14, TC 3.42b5
Post Reply