Search in archives: when feeding results to panel listbox put the focus on file focused in Find Files results window

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Search in archives: when feeding results to panel listbox put the focus on file focused in Find Files results window

Post by *DrShark »

Currently Total Commander sets the focus on a first file in panel with search results even if different file was focused in result list attached window of Find Files dialog.

It could be a time saver because user can more quickly start operation on files that in result list are listed near selected one.
User won't have to scroll down in the Total Commander main window panel to desired file/directory. And, if paths are too long for half of a screen, which is close in size of single panel size normally used by users, there will be no need for user additionally to drag panels separator or switch colums view to see the names of desired files - usually it's easier and enough to maximize Find Files window with result list to see the filenames with their wide paths and select desired one.

Edit: Planned to post it as a suggestion, but due to inconsistency can be considered as a bug too.
Reproduce steps are in my next post
Last edited by DrShark on 2021-09-01, 17:16 UTC, edited 2 times in total.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6429
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: Search results: when feeding results to panel listbox put the focus on file focused in Find Files results window

Post by *Horst.Epp »

Thats already done for me.
It always focuses on the selected file from the search results after feed to listbox
Windows 11 Home x64 Version 23H2 (OS Build 22631.3296)
TC 11.03 x64 / x86
Everything 1.5.0.1371a (x64), Everything Toolbar 1.3.2, Listary Pro 6.3.0.69
QAP 11.6.3.2 x64
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Search results: when feeding results to panel listbox put the focus on file focused in Find Files results window

Post by *petermad »

Thats already done for me.
It always focuses on the selected file from the search results after feed to listbox
Same here.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Search in archives: when feeding results to panel listbox put the focus on file focused in Find Files results window

Post by *DrShark »

Horst.Epp wrote: 2021-09-01, 16:35 UTCIt always focuses on the selected file from the search results after feed to listbox
I actually planned to post this in Suggestions forum (my post doesn't look like a bugreport), a but actually TC not always keeps result list's file focus to panel itself. It doesn't happen in following case:
1. Search with "Search in archives" option enabled.
2. In Find Files results list window, select file found inside of some archive (except files of the first archive if such archive is a first item result list).
3. Press Feed to listbox:
in Total Commander panel updir will be focused.

I would expect the focus on archive file of which was selected in Find Files, a behavior similar to one used for "Go to file" Find files function. Current difference for focused file in "Go to file" and "Feed to listbox" functions doesn't look consistent and expected.

Edit: changed topic title to more relevant: "Search in archives: when feeding results to panel listbox put the focus on file focused in Find Files results window"
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
JOUBE
Power Member
Power Member
Posts: 1433
Joined: 2004-07-08, 08:58 UTC

Re: Search in archives: when feeding results to panel listbox put the focus on file focused in Find Files results window

Post by *JOUBE »

DrShark wrote: 2021-09-01, 17:09 UTC1. Search with "Search in archives" option enabled.
2. In Find Files results list window, select file found inside of some archive (except files of the first archive if such archive is a first item result list).
3. Press Feed to listbox:
in Total Commander panel updir will be focused.
F1 -> Help
Find files: General

Feed to listbox
...There are two possible cases when searching in archives: If all files were found in a single archive, the files will be shown in the source file window. Otherwise the archives themselves will be shown.

it is like it is

JOUBE
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Search in archives: when feeding results to panel listbox put the focus on file focused in Find Files results window

Post by *DrShark »

JOUBE wrote: 2021-09-02, 11:47 UTCF1 -> Help
Find files: General

Feed to listbox
...There are two possible cases when searching in archives: If all files were found in a single archive, the files will be shown in the source file window. Otherwise the archives themselves will be shown.

it is like it is
Yes, but this topic is about file which TC focuses panel with Search results. To me expected behavior would be to focus in a panel with search results the same file which is selected in result list window of Find Files, or when in Find Files result window we select a file which is inside archive and it's not from a single archive, it's expected that TC will focus archive itself in TC panel with search results.

And yes, this applies also to a case with single archive - I just tried it:
1. In Total Commander panel select single archive.
2. Start Find Files, check Search in archives.
3. In "Search for:" type some name of a file or directory which exists in archive, but doesn't match archive name iteslf (archive itself should NOT appear in result list!)
4. Start search.
5. When search is finished, in results window select some file except first one.
6. Press Feed to listbox:
in panel with search results the cursor will be on a first file!
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Post Reply