Compare tool

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
AntonyD
Power Member
Power Member
Posts: 1246
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Compare tool

Post by *AntonyD »

3. If I try to compare the same file on left & right panels - compare window is opening. Why? This is identically the same file.. (Open TC dir on both left & right panels and try to compare History.txt)
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Edit: Confirmed after a misunderstanding, see below.

Icfu
Last edited by icfu on 2006-11-04, 16:35 UTC, edited 1 time in total.
This account is for sale
User avatar
AntonyD
Power Member
Power Member
Posts: 1246
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Post by *AntonyD »

Did you try to make all things as i said?
Open TC dir on both left & right panels and try to compare History.txt

In this situation we compare not TWO identical file - but ONE!
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

I had tested with binary identical files with different file names in both panels, sorry!

I can confirm that bug now!

Icfu
This account is for sale
User avatar
Hacker
Moderator
Moderator
Posts: 13064
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

Officially, it is by design, so the user can choose another file to compare.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

There should be a message box in this case:

The files you have compared are identical:
Open the compare dialog nevertheless? OK/Cancel

Default to Cancel.

And I would extend it to ALL identical files, not only identical files in different panels with identical name.

With the present limitation it's confusing imho.

Icfu
This account is for sale
User avatar
Hacker
Moderator
Moderator
Posts: 13064
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

There should be a message box in this case:

The files you have compared are identical:
Open the compare dialog nevertheless? OK/Cancel
Hopefully the default would be Cancel. :D

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Otherwise use AHK! :mrgreen:

Icfu
This account is for sale
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3292
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

I think a msg like
"u r tryin to compare a file with itself!"
would be the best.
Hoecker sie sind raus!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is by design and will not be changed.
Author of Total Commander
https://www.ghisler.com
Franz Müller
Senior Member
Senior Member
Posts: 383
Joined: 2005-05-24, 10:41 UTC
Location: Wien

Post by *Franz Müller »

@ghisler
Can you give an understandable explanation for designing such a strange behaviour?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The idea is that you can still open the dialog, e.g. to choose a file via the >> buttons. In one version, I have just shown an error "the files are identical" and not opened the dialog, and got many complaints from users who use the >> buttons to take files to compare...
Author of Total Commander
https://www.ghisler.com
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

The idea is ok, but please offer it, like written above, for all cases in which files are equal. A message box really shouldn't be hard to add and it would satisfy all users.

Icfu
This account is for sale
Post Reply