TC7: URL icon in panel is not that of the default browser

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

TC7: URL icon in panel is not that of the default browser

Post by *wanderer »

A minor bug in TC7 final.

Default browser: Firefox.

When dropping a URL inside TC's panel, the icon of the created .URL file is IE's not Firefox's. If .URL is copied on desktop, Firefox's icon is shown as it should.

EDIT: Tested on Win2KSP4.
Last edited by wanderer on 2007-06-07, 18:58 UTC, edited 1 time in total.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
User avatar
StickyNomad
Power Member
Power Member
Posts: 1933
Joined: 2004-01-10, 00:15 UTC
Location: Germany

Post by *StickyNomad »

Confirmed.

I'm not sure if that's because I recently updated to IE 7...
User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Post by *wanderer »

StickyNomad wrote:Confirmed.

I'm not sure if that's because I recently updated to IE 7...
Just checked it. It's like that in v6.56 too and in TC7pb1.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

Confirmed (that TC displays a different Icon than Explorer and Desktop).
In Explorer and on the Desktop the Firefox-Icon is displayed, in TC the IE-Icon is displayed.

I wonder how Explorer does this, though, because in TC with "Files / Associate With..." (on my system) you can see, that the IE-Icon is set to be used.
So Explorer seems to ignore this and does something else, while TC does not. :?:
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
petermad
Power Member
Power Member
Posts: 14829
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

URL is by default associated to Internet Shorcut (rundll32.exe shdocvw.dll,OpenURL %l), which again by default uses icon 0 in C:\WINDOWS\system32\url.dll.

So how Explorer and Desktop figures out to use the firefox icon beats me - maybe another undocumented Microsoft "feature ?"
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Post by *wanderer »

petermad wrote:URL is by default associated to Internet Shorcut (rundll32.exe shdocvw.dll,OpenURL %l), which again by default uses icon 0 in C:\WINDOWS\system32\url.dll.

So how Explorer and Desktop figures out to use the firefox icon beats me - maybe another undocumented Microsoft "feature ?"
Hmmm, indeed. Copying the URL to the desktop, it gets icon 1 from firefox.exe though. How about that, another MS "feature". It seems you're right petermad.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48130
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Really strange indeed. I'm using the DefaultIcon entry here. Any ideas?
Author of Total Commander
https://www.ghisler.com
User avatar
HolgerK
Power Member
Power Member
Posts: 5406
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

2ghisler(Author)
Take a look into these two registry entries:

Code: Select all

[HKEY_CLASSES_ROOT\InternetShortcut\DefaultIcon]
@="%SystemRoot%\system32\url.dll,0"

[HKEY_CLASSES_ROOT\InternetShortcut\shellex\IconHandler]
@="{FBF23B40-E3F0-101B-8488-00AA003E56F8}"
Explorer seems to ignore the DefaultIcon key in case of an existing IconHandler key:
1. Rename IconHandler into NOIconHandler
2. Use TweakUi-Repair-RebuildIcons
-> Explorer shows the DefaultIcon

On the other side, if DefaultIcon is renamed to NODefaultIcon, TC shows the correct icon.

HTH,
Holger
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48130
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Indeed TC uses DefaultIcon before the IconHandler. This is by design, so the user can override the (normally quite slow) icon handlers.
Author of Total Commander
https://www.ghisler.com
User avatar
HolgerK
Power Member
Power Member
Posts: 5406
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

Maybe it's by design, but in this case it leads to a wrong icon display.

The IExplorer icon indicates, that the url will be loaded with IE, also if FireFox is set as default browser.

Suggestion:
Is it possible to add a value to:
ShowEXEandLNKicons |= 32
to prefer icon extraction via IconHandlers before using DefaultIcon?

So the user will be able to adjust this behavior to his needs?

Kind regards,
Holger
User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Post by *wanderer »

HolgerK wrote:Is it possible to add a value to:
ShowEXEandLNKicons |= 32
to prefer icon extraction via IconHandlers before using DefaultIcon?

So the user will be able to adjust this behavior to his needs?
A not-so-technical user would expect TC to somehow figure this out and show the correct icon, not go to TC.ini and change stuff so i don't think this idea is "politically correct", even though it may solve the problem. What if tomorrow Microsoft figures another 3 ways of getting the icons? Will all TC users have to go to TC.ini and change more parameters?
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
User avatar
HolgerK
Power Member
Power Member
Posts: 5406
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

2wanderer
Ok, convinced. :wink:

Modified suggestion:
Is it possible to change the default behavior, to extract icons like explorer does?
For compatibly reasons add the possibility to switch to the old behavior by adding a value to "ShowEXEandLNKicons"?

Kind regards,
Holger
User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Post by *wanderer »

HolgerK wrote:2wanderer
Ok, convinced. :wink:

Modified suggestion:
Is it possible to change the default behavior, to extract icons like explorer does?
For compatibly reasons add the possibility to switch to the old behavior by adding a value to "ShowEXEandLNKicons"?

Kind regards,
Holger
Ok, that seems better :wink: . When i noticed this issue, i had selected "All", not "All associated" in Options\Icons though. In any case, neither of them works correctly.

Anyway...
ghisler(Author) wrote:Indeed TC uses DefaultIcon before the IconHandler. This is by design, so the user can override the (normally quite slow) icon handlers.
...if such a thing makes TC slower, it might be better if it's turned off by default.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
Post Reply