Switch view mode after feed to listbox

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

User avatar
StickyNomad
Power Member
Power Member
Posts: 1933
Joined: 2004-01-10, 00:15 UTC
Location: Germany

Switch view mode after feed to listbox

Post by *StickyNomad »

I think I found a little issue. How to reproduce:
(Make sure you have at least one custom column view configured)

1. enable full view (show > full)
2. Search for something that gives some results and feed to listbox
3. change the view to a custom column view
4. change the view mode to 'brief'
-> the search results are still displayed when switching to brief view

Now repeat 1. and 2. After that change the view mode directly to 'brief'
-> The view mode is switched but the search results are lost (the previous folder is displayed).

I wonder why it is possible to switch the search results to brief view after you have selected some custom column view, but not when switching directly from full view. When directly switching from full to e.g. thumbnail view, the search result is still shown as expected.
User avatar
Hacker
Moderator
Moderator
Posts: 13142
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

StickyNomad,
See please Brief view in search results.


HTH
Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50475
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, it's done this way because the user has explicitly switched to a custom view (where it makes sense to keep the search results). If the user switches directly to brief or full view, TC turns off the search result because it expects that the user wants to return to normal file mode.
Author of Total Commander
https://www.ghisler.com
User avatar
Hacker
Moderator
Moderator
Posts: 13142
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

Christian,
If the user switches directly to brief or full view, TC turns off the search result because it expects that the user wants to return to normal file mode.
Ahem, I cannot see the logic behind this. The user switches to Brief view because he wants to switch to Brief view. If the user would like to exit the search result he would exit the search result (force a refresh).

So, I am against this switching.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
StickyNomad
Power Member
Power Member
Posts: 1933
Joined: 2004-01-10, 00:15 UTC
Location: Germany

Post by *StickyNomad »

2Hacker

Thanks for the hint, must have overlooked this thread.

2ghisler(Author)

I totally agree with Hacker. I would prefer a consistent behaviour here: the search results should simply be kept on _any_ view change.

If one really doesn't need the search results anymore, a forced re-read like Hacker said or pressing BACKSPACE does the job fine.

Also imagine this possible scenario: After feeding the search results to listbox, I want to activate comments view with CTRL+SHIFT+F2 (which is currently possible), but miss the SHIFT key or press SHIFT LOCK instead and accidentialy activate Full view: BAM! The search results are gone and I have to do the search again. Not that serious I admit, but - especially after a long search - an annoyance that could be prevented by keeping the search results independent from the chosen view mode.

So I would really appreciate if you would consider to change this behaviour.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50475
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Well, the logic behind this is the following: Initially there was no support for custom columns or thumbnails view, so when the user switched to full or brief view after making a search, it was clear that he wanted to revert to normal view mode. This behaviour was kept, for backwards compatibility (I get many complaints if I change only a small part of the program to which people quickly get used to).

When custom columns view and thumbnails view were added, I had to add the possibility to switch to these modes also after making a search. To give people a way to switch back to the normal view, Show - Full will then keep the search result, and switch it back to how it was before. I hope that this makes it a bit more clear why it behaves in this (a bit strange) way...
Author of Total Commander
https://www.ghisler.com
User avatar
StickyNomad
Power Member
Power Member
Posts: 1933
Joined: 2004-01-10, 00:15 UTC
Location: Germany

Post by *StickyNomad »

2ghisler(Author)

Thanks for your explanation. I can understand your concerns about changing this behaviour, and I don't want to force a change. But also before custom columns and thumbnails view were introduced, I would have expected that changing the view mode after a search does exactly this - change the view mode - and nothing more.

Actually I practically never use brief mode, so this behaviour just came to my attention by coincidence. If I would have been a beta tester when the feed-to-listbox-feature was newly introduced, I surely would have asked if it is intended that the search results are lost after a view mode change.

In addition, when using branch view, TCs behaviour is just as I would expect it. You can change to any view mode and the branch mode is always kept. This is the behaviour I would expect also after a search. By changing the view mode, I intend to change the view onto the _current_ content of the listbox, not change the content itself.

But as I said, I don't want to force anything here, as for me personally the current 'strange' behaviour is no actual annoyance. But nevertheless I consider this to be a general inconsistency - from my point of view.
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Initially there was no support for custom columns or thumbnails view, so when the user switched to full or brief view after making a search, it was clear that he wanted to revert to normal view mode.
Also without custom columns it wasn't "clear" at all. Not being able to switch view without losing search results is a limitation, not a feature, no matter if you can choose between two, three, four or 100 different views.

Icfu
This account is for sale
User avatar
Hacker
Moderator
Moderator
Posts: 13142
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

Christian,
I have to agree with StickyNomad and icfu. I don't see why switching views in the search result should imply wanting to leave the search result. Why should the user not want to view the results in Full view or Brief view?

Roman
Last edited by Hacker on 2007-10-30, 00:52 UTC, edited 1 time in total.
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
StickyNomad
Power Member
Power Member
Posts: 1933
Joined: 2004-01-10, 00:15 UTC
Location: Germany

Post by *StickyNomad »

2Hacker
I have to agree with SanskritFritz and icfu
Erm, Sans? Have I missed a deleted post or is it a little late already? :wink:
User avatar
Hacker
Moderator
Moderator
Posts: 13142
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

StickyNomad,
Bah, sorry.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

Set an INI choice ?

Post by *Clo »

2StickyNomad
2Hacker
2icfu

:) Hello !

• I agree and support a change of that behaviour.
- When I forget to view some file and then change the view, I've to remake the same search… :(
---------------------

2ghisler(Author)

:) Good morning,

• Isn't it possible to add an INI entry to solve that ? Something like :
ChangeViewKeepsSearch=1
- Keeps the result of a search when changing from any view mode to any other (new behaviour, default)
0” : Comes back to the previous directory (old {current} behaviour).
…why it behaves in this (a bit strange) way...
• …“a bit strange” is that we call in French «A sweet euphemism» :roll:

:mrgreen: VG
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
User avatar
petermad
Power Member
Power Member
Posts: 16027
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I agree and support a change of that behaviour.
Me too !
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

Agree and support.
Implemented as an option should also satisfy the people used to the current behaviour, IMHO.

2Clo
- When I forget to view some file and then change the view, I've to remake the same search…
Workaround: To prevent accidents like this you can open a new tab with Ctrl+T,
this creates a second, independent list with search results.
If one is destroyed, there is another left.

This just saved some search results here...
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

Headache-tab…

Post by *Clo »

2StatusQuo

:) Hello !

• I don't use tabs, never ! :P

- I use tabs in the Web¦Images browsers and in some editors where they work “cool” as expected, without aspirin each 5 minutes…

:mrgreen: VG
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
Post Reply