Remove none-last rule in "Plugins" search tab

Here you can propose new features, make suggestions etc.

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
Lefteous
Power Member
Power Member
Posts: 9536
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Remove none-last rule in "Plugins" search tab

Post by *Lefteous »

When changing rules in a saved search there is one thing that annoys me again and again. When I want to remove the first or any other rule which is not the last I have to remove all rules behind that rule. In the worst case this means starting from the beginning.
It's also not clear that "less rules" will remove the last rule in the list.

I see two possible solutions.

1) Add plus and minus buttons right to each rule.
Here is an example screenshot which illustrate how the problem is solved in Mozilla Thunderbirds' filter edit dialog.
http://www.lefteous.de/tc/beta7/bugshots/thunderbird_filter_edit.png

2) Make each rule selectable and change the "less rules" button into "remove this rule".

I'm of course open to any other solution that will improve the current situation.
User avatar
petermad
Power Member
Power Member
Posts: 16030
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

The same applies to the "Change attributes" dialog, where you can only remove the last set of plugin attribues with the "Less attributes" button.

But in the "Change attributes" dialog there already is a [+] button (with another purpose) - so for uniformity I think a "Delete active rule"/"Delete active attributes" would be the best.

It would also conform with the "Delete active column" in the Custom columns setup.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Lefteous
Power Member
Power Member
Posts: 9536
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

But in the "Change attributes" dialog there already is a [+] button (with another purpose)
Yes this is true. Some time ago I requested to move adding fields to an external window which would be much more convenient than the current approach.
User avatar
StickyNomad
Power Member
Power Member
Posts: 1933
Joined: 2004-01-10, 00:15 UTC
Location: Germany

Post by *StickyNomad »

Big fat support! This annoys me too quite often.

2petermad

I absolutely agree in every point! In fact, I was about to post almost exactly what you said, but you were faster, as I saw after previewing my post ;-)

So I also strongly vote for making the rows selectable in the search- and 'change attributes'-dialogs. This would be easy, intuitive and consistent with the custom-column behaviour as you stated.

2Lefteous
Hm, can you specify this a bit more or point me to the thread? I don't get exactly how this should work with an external window...
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50479
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I'm aware of this problem. In the custom columns configuration dialog, you can select the line which you want to remove, would that help?
Author of Total Commander
https://www.ghisler.com
User avatar
Lefteous
Power Member
Power Member
Posts: 9536
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

would that help?
Sure.
User avatar
StickyNomad
Power Member
Power Member
Posts: 1933
Joined: 2004-01-10, 00:15 UTC
Location: Germany

Post by *StickyNomad »

Yes, this would help indeed. I too would go fine with the behaviour as it is implemented in the custom column dialog.
Post Reply