TC ignores 2-page icon for a button…

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

TC ignores 2-page icon for a button…

Post by *Clo »

:) Hello !

• Testing another bug, I needed to add a button using a 2-page icon.
- In the dialogue, TC shows and uses only one format, like one can see ON THAT IMAGE.

• This icon itself is available HERE. It's renamed because the simple one-page icon is also in that server.
• Embedding it in a small 32-bit ICL doesn't help, still the 32² format is seen only… :(

• During this test, I have set the screen as 32 BPP (the icon is 32 BPP).
- The stated icon size in my bars is indeed 24×24 pixels…

:mrgreen: KR
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Works flawlessly with ICL, check this one:
http://icfu.totalcmd.net/Temp/QuickV-VRapide_2-page.icl

Icfu
This account is for sale
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

In situ…

Post by *Clo »

2icfu

:) Hello Jeff !
Works flawlessly with ICL, check this one: …
• Yes, it does, although “flawlessly” is a bit too kind …
In situ, even with 32 BPP screen, the icon looks crappy, like THIS (please, blow up it). But that's another song…

- Anyway, thank you for the test and the ICL.
- Mine is shown correctly in Lister + IclView, though…
- The point is especially to know why the multi-page icons are not supported,
while the same stuff in (some) ICLs is…
- It's incoherent, IMHO.

:mrgreen: VG
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

The filetype ICO is meant to store one single icon in different sizes and colour depths, it's not meant to be used to store differently looking icons. TC displays the icon with the correct resolution automatically, depending on situation.

What would be the advantage if TC would display all contained icons in an ICO file?

Edit: Make sure that you have activated "Small Icons" in the buttonbar. I guess that the help file tells a lot of nonsense regarding this setting...

Icfu
This account is for sale
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

IM_PO_SSIBLE !

Post by *Clo »

2icfu

:) Hi again !
The icon you linked to is not 32x32, it's 30(!)x32, maybe that's the problem?
:?: Where did you see that ? I downloaded my icon in an empty dir >> F3, and please, watch WHAT IS SHOWN
- All viewers¦ icon editors show the same… Hm…
Worn by a rubbing in the Web at your's ? :lol:
…What would be the advantage if TC would display all contained icons in an ICO file?

• Obvious ! To choose the appropriate format to display, like one does in an ICL¦EXE !
- That'ld need to improve the previews in the button config, that are unable to display the real size,
all as 32² (installed and to choose for addition¦change)…

:mrgreen: VG
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Where did you see that ?
This image is 30(!)x32:
http://membres.lycos.fr/charries/relais/in_the_bar.png
Obvious ! To choose the appropriate format to display, like one does in an ICL¦EXE !
This is not needed, check the edited posting above...

Activate "Small Icons" and set size beneath to 24. Set the size at the top of the buttonbar dialog to 28 or so. TC will automatically choose the 24x24 icon in buttonbar then.

Also check this bug report:
http://www.ghisler.ch/board/viewtopic.php?t=18082

;)

Icfu
This account is for sale
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

Broken by ? Let guess !

Post by *Clo »

2icfu
This image is 30(!)x32:
:twisted: This is like TC shows it, while the size is set to 24×24
- On the capture, you have the spacings added (L-R-U-D) The icon is 24² (the black frame).
I display the icons as "flat", and no Xp-Style.

• The icon itself is quite correct, not any doubt !
- In the case, since the 24² is not seen, TC resizes the 32² into the crap I show in the bar…
- Native 24² are bearable.
Edit: Make sure that you have activated "Small Icons" in the buttonbar. …
• We have changed that antiquated wording in French, and all icons are displayed (more or less) properly.
I've read your thread about that.
- There was a big row about that in the ß-forum a long while ago…

• After all, a multi-page *.ICO is also an icon resource, and it could be supported.

:mrgreen: VG
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

This is like TC shows it, while the size is set to 24×24
I only get that crappy look when I disable "Small icons", otherwise your icon is displayed correctly.

These are my settings, you can see correct 24x24 icon in bar and 32x32 icon in preview:
http://img175.imageshack.us/img175/9701/buttonbarye1.png

It also doesn't matter if I disable buttonbar XP-style setting and if I switch among XP theme/classiv style, icon is always correct.

Icfu
This account is for sale
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

Less icons !

Post by *Clo »

2icfu

:) Hi Jeff !

• Here, I don't tick "Icon size" (Small icons), because I miss 4 icons in the bar.
- Whether I use your settings, I get 31 icons in the bar and a damned second row.
- With Button size 24 = the size of the icon, I get 35 icons and no second row.
- Because Button=Icon, I have the minimal (hard coded) spacing.
- Only a 17" CRT and 1024×768 here… :|

:mrgreen: VG
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50475
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Indeed 24x24 icons are loaded only when this size is explicitly set, either in the icon size, or the small icons size. In the icon selection dialog, TC always shows the 32x32 large icons.
Author of Total Commander
https://www.ghisler.com
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

Same*

Post by *Clo »

2ghisler(Author)

:) Good evening,
…either in the icon size, or the small icons size…
• But this is the same ! Just a different wording…

- Using both “Button size” (upper box+field) and “Icon size” (lower box+field)
leads to miss 4 icons per bar with 24², like I said above.
- When a single indication is given, like I do, plus "Flat" ticked, the 24²-page of the chosen icon might be loaded,
instead of loading a larger page (32² in the case), and resizing it, producing ugly icons.
- You have a minimal hard-coded spacing, hence a 24² icon fits always on a "24" button.
- That works indeed fine with 24² one-page icons, but not with two-page (or more) icons, that's the point.

• About the previews, whether we would have a better view, one could force to load the right size in any case,
since each page should be displayed (with its size indicated, of course).
- A long while ago, I suggested a kind of "table" (as a “floating window”) in addition
to choose icons in that way, but no feed-back, AFAIR…

Updated dialogue…
Updated table…

- Other ways can be imagined, like use a Lister window (with an appropriate plugin), a partner-programme and the like…

:mrgreen: VG
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
Post Reply