TC7.02a/FTP Download from list/Downloaded files marked wrong

[white]

FTP Download from list a file with the following contents:

Code: Select all

http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/

After downloading the contents of the file has changed to:

Code: Select all

OK-p://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/

Oops


Another example. FTP Download from list a file with the following contents:

Code: Select all

header: Referer: http://www.ghisler.com/whatsnew.htm
http://www.ghisler.com/download.htm

header: Referer: http://www.ghisler.com/whatsnew.htm
http://www.ghisler.com/

header: Referer: http://www.ghisler.com/index.htm
http://www.ghisler.com/index.htm

After downloading the contents of the file has changed to:

Code: Select all

header: Referer: OK-p://www.ghisler.com/whatsnew.htm
OK-p://www.ghisler.com/download.htm

header: Referer: http://www.ghisler.com/whatsnew.htm
http://www.ghisler.com/

header: Referer: OK-p://www.ghisler.com/index.htm
http://www.ghisler.com/index.htm

Oops

[Hacker]

Where is the bug? Is it that the other files have not been marked OK even though they were downloaded correctly?

Roman

[white]

Where is the bug? Is it that the other files have not been marked OK even though they were downloaded correctly?

It seems like when a file is downloaded correctly the string containing the download URL is searched from the beginning. If the string is found, it gets the "OK-" mark.

So FTP Downloading from list a file with the following contents:

http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/

Would after downloading have the contents:

OK-p://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/thisfiledoesnotexist.htm
http://www.ghisler.com/

The wrong file (first entry) is marked! And the downloaded file (last entry) is not marked!
If a download fails because a web server was temporarily offline. The entry could be marked downloaded by an entry later on!

The search is in any part of the lines, so even if the string is found for instance a header attribute, it is marked downloaded. And the downloaded file is not marked.

Example. FTP Download from list a file with the following contents:

header: Referer: http://www.ghisler.com/whatsnew.htm
http://www.ghisler.com/download.htm
http://www.ghisler.com/index.htm
http://www.ghisler.com/order.htm
http://www.ghisler.com/news.htm
http://www.ghisler.com/

After downloading the contents of the file has changed to:

header: Referer: OK-p://www.ghisler.com/whatsnew.htm
OK-p://www.ghisler.com/download.htm
OK-p://www.ghisler.com/index.htm
OK-p://www.ghisler.com/order.htm
OK-p://www.ghisler.com/news.htm
http://www.ghisler.com/

The header attribute in line 1 is changed because the last file was downloaded.

[white]

30.03.08 Fixed: FTP download from list: match complete name when marking downloaded items with "OK-", to avoid that partial name like http://ghisler.com matches file in that location, or that Referer line is marked

Tested OK in TC 7.03

[ghisler(Author)]

Thanks for trying it! Please report if you find any similar problems with TC 7.03, so I can fix them in TC 7.5. It's a very complex thing, so it's possible that I may have missed some special cases...