sync tool: Presets with "=" dont work

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

sync tool: Presets with "=" dont work

Post by *Samuel »

Should be much longer present than TC 7.5.

Just use the sync tool and create a new preset with the name "text=text"
=> would not be shown... Its in the ini, but the "=" sign makes trouble...
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry, this is a limitation of the ini files.
Author of Total Commander
https://www.ghisler.com
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Post by *Samuel »

I know.
Just remove the "=" sign or show an error. Would be fine. (because otherwise the new preset is just not created...) Will look like a bug for users which are not used to "ini"-files.

But you dont have to do it for me.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I will consider it for one of the next versions.
Author of Total Commander
https://www.ghisler.com
User avatar
TLis
Member
Member
Posts: 111
Joined: 2004-06-02, 16:48 UTC
Location: Szczecin, Poland

Post by *TLis »

If the config file parser splits a line on the '=' character, why don't you just limit the number of splits to 1. Then the '=' character could be present in the entries. So, unless the code for parsing the config file is not yours (some third-party library), I believe it would be a very straightforward change to make and not introducing any side-efects.

Anyway, I agree that restricting the values so that they do not contain any '=' character is an odd limitation ...
User avatar
Hacker
Moderator
Moderator
Posts: 13141
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

TLis,
the config file parser
There is no such thing. This function is handled by Windows.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I will replace the '=' by an underscore '_' in public beta 2.
Author of Total Commander
https://www.ghisler.com
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Post by *Samuel »

Fixed. Thanks. :)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks for confirming the fix!
Author of Total Commander
https://www.ghisler.com
Post Reply