750PB1:Installer,wrong tab order

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4677
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

750PB1:Installer,wrong tab order

Post by *white »

When Total Commander has been installed already, the installer detects this and presents the options to update or to install normally. If you choose to install normally the tab order of the buttons on the following dialog (Select language) is wrong.

Also, there is no space between the "Program info" and the "Back" button.
User avatar
petermad
Power Member
Power Member
Posts: 14914
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

there is no space between the "Program info" and the "Back" button.
That depends on the used Windows theme. But the space is definitely smaller with Windows XP (Luna) theme.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
alm
Junior Member
Junior Member
Posts: 59
Joined: 2006-06-23, 17:25 UTC

Post by *alm »

2white

You mean to say the order is now:
Next (default start) -> Back -> Next -> Cancel -> Program info -> Next again, etc...

You want it to be:
Next (default start) -> Back -> Cancel -> Program info -> Next again, etc?

Then I noticed the buttons show the text in English for all languages except German and French. This might have always been like this, I only notice it now. Probably because all steps have to be translated to have it in the selected language. Not that I really care about it though. ;)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I can confirm the tab order problem, thanks. Unfortunately there isn't enough space to place the buttons differently, sorry. The "Back" and "Next" buttons have to be in the same place as on the following dialogs, and the info button cannot be made any smaller.
Then I noticed the buttons show the text in English for all languages except German and French. This might have always been like this, I only notice it now. Probably because all steps have to be translated to have it in the selected language.
Indeed the languages are currently hard-coded, sorry. It cannot be translated to other languages at this time.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4677
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

alm wrote: You mean to say the order is now:
Next (default start) -> Back -> Next -> Cancel -> Program info -> Next again, etc...

You want it to be:
Next (default start) -> Back -> Cancel -> Program info -> Next again, etc?
The order is now:
Listbox with languages -> Back -> Next -> Cancel -> Program info (-> start at the beginning)
Back before Next is inconsistent with the other dialogs.

The order in the next dialog (install other languages) is:
Next -> Cancel -> Back -> Groupbox (-> start at the beginning)

The order in the next dialog (target directory) is:
Editbox -> ... -> Next -> Cancel -> Back (-> start at the beginning)

The order in the next dialog (change ini file location) is:
Next -> Change ini file location -> Cancel -> Back (-> start at the beginning)
This is inconsistent with the previous dialogs.
User avatar
white
Power Member
Power Member
Posts: 4677
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:and the info button cannot be made any smaller.
Perhaps you can use caption "Info" instead of "Program info" and make the button smaller?
User avatar
petermad
Power Member
Power Member
Posts: 14914
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Perhaps you can use caption "Info" instead of "Program info" and make the button smaller?
Good idea, Support++
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4677
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

HISTORY.TXT wrote:24.04.09 Fixed: Button spacing and tab order in installer (language selection page)
Button spacing looks better now.
white wrote: The order is now:
Listbox with languages -> Back -> Next -> Cancel -> Program info (-> start at the beginning)
Back before Next is inconsistent with the other dialogs.

..

The order in the next dialog (change ini file location) is:
Next -> Change ini file location -> Cancel -> Back (-> start at the beginning)
This is inconsistent with the previous dialogs.
The tab order is still inconsistent with the other dialogs.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The tab order is now following the button order:
Language list -> Program info -> Back -> Next -> Cancel.

You are probably confused because the "Next" button is shown as default when the Language list has the focus...
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4677
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:The tab order is now following the button order:
Language list -> Program info -> Back -> Next -> Cancel.

You are probably confused because the "Next" button is shown as default when the Language list has the focus...
No, I am not confused. The order you mention is inconsistent with the following dialogs.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

With so many buttons I prefer to keep it as it is now.
Author of Total Commander
https://www.ghisler.com
Post Reply