7.5 pb2: incorrect association breaks whole system

[m^2]

1. Create a wincmd.ini like this:

Code: Select all

[configuration]
UseIniInProgramDir=7
FirstTime=0
[Associations]
Filter1=>wrong_search
Filter1_open=some_command
Filter2=*.txt
Filter2_open=notepad "%1"
Filter2.icon="%COMMANDER_PATH%\TOTALCMD.EXE"

2. Go to a directory containing a text file.
It should have a TC icon, while TC loads a system one.

In general, all associations after a broken one don't work. I think that TC should failover and continue searching. Maybe show a warning.
It works well with colouring.

[ghisler(Author)]

What does "wrong_search" contain? If it matches, TC uses its settings, and if no icon is defined, TC uses system icon...

[m^2]

Nothing. What I posted above is whole wincmd.ini.
It's very possible that incorrect search matches everything. (EDIT: no, see below)
I found it by deleting a "_tmp" search from my wincmd.ini (something created for testing purposes) and finding that associations don't work at all.

ADDED: when I add
Filter1.icon="%COMMANDER_PATH%\TOTALCMD.EXE"
strange things happen:
Filter1 doesn't match any file. But filter2 works again.

[ghisler(Author)]

Strange, I will check that.

[karlchen]

Hi, m^2, hi, Christian.

I am not quote sure that I created the broken association the right way. Here is my [Associations] section (T.C. 7.50 PB3 wincmd.ini):

[Associations]
Filter1=>wrong_search
Filter1_open="notepad.exe "%1""
Filter2=>PDFFiles
Filter2_open=""%COMMANDER_PATH%\..\PDFReader\Foxit Reader.exe" "%1""
Filter2.icon=%COMMANDER_PATH%\..\PDFReader\Foxit Reader.exe,1
Filter3=>PlainTextFiles
Filter3_open=""%COMMANDER_PATH%\..\PFE\PFE32.EXE" "%1""
Filter3.icon=%COMMANDER_PATH%\..\PFE\PFE32.EXE,4

>wrong_search simply does not exist, i.e. there is no entry in the [searches] section named >wrong_search.
The associations defined for >PDFFiles and >PlainTextFiles work as expected.

Does this suggest that an issue has been fixed or that I have not been able to reproduce it because I tried it in the wrong way?

<Added a few minutes later (brain switched on by now)>
OK, found the answer myself by putting the same [Associations] section inside the wincmd.ini of T.C. 7.50 PB2.
Now the associations defined for >PDFFiles and >PlainTextFiles do not correctly work any longer:
+ >PlainTextFiles will be processed by FoxitReader which cannot read them
+ >PDFFiles will be opened by Notepad which does not make too much sense, either.
</Added a few minutes later>

T.C. 7.50 PB3, however, seems to ignore the broken association and interprets the remaining two correct associations correctly:
>PDFFiles will be opened by FoxitReader
>PlainTextFiles will be opened by PFE.

So the reported issue has been fixed by T.C. 7.50 PB3.

+ Total Commander 7.50 PB3
+ Windows XP Prof SP1, 32bit, ger

Kind regards,
Karl

[ghisler(Author)]

Great, thanks! Indeed when "wrong_search" was missing, the operations were shifted by one filter in beta 2 and earlier.

[m^2]

Fix confirmed.

[ghisler(Author)]

Thanks for confirming it too!