TC suggests wrong path for plugin installation

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

TC suggests wrong path for plugin installation

Post by *MVV »

There are 4 kings of plugins. When you install a new one, TC suggests path of already installed plugins of this kind as base path to put new plugin's folder. E.g. if I have some packer plugin installed to %COMMANDER_PATH%\Plugins\Packer\SomePlugin, TC will try to suggest path %COMMANDER_PATH%\Plugins\Packer\SomeNewPlugin for SomeNewPlugin.

But this works very strangely in some cases. E.g. I have installed plugin Imagine that has Imagine.wcx in its folder. Install location is %COMMANDER_PATH%\Plugins\Lister\Imagine. I don't have this packer plugin installed. Now when I'm trying to install new packer plugin TC suggests %COMMANDER_PATH%\Plugins\Lister path as base path for this kind of plugins instead of %COMMANDER_PATH%\Plugins\Packer where all installed packer plugins placed! If I remove Imagine.wcx from %COMMANDER_PATH%\Plugins\Lister\Imagine folder, all works fine again.

I think TC should detect base paths only by checking paths of really installed plugins - i.e. in wincmd.ini - and not to search for files of this kind in plugins folder.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50532
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks for your suggestion, I will consider it. However, it wouldn't help if Imagine.wcx is actually installed.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

I agree that TC should treat Imagine.wcx's path as packer path if Imagine.wcx is associated with some extension.

I think there are some ways to get default folder. First one is just to read base path of first plugin of same kind (first entry of corresponding INI section) - quick and easy, and every user may manually change plugins order to change base dir (e.g. move line with Imagine.wcx down). Second one is to find base dir that is used for most plugins of same kind (hard way, reguires to build list of folders and counting references).
User avatar
white
Power Member
Power Member
Posts: 5807
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

Can this thread please be moved to Suggestions?
ghisler(Author) wrote:Thanks for your suggestion, I will consider it. However, it wouldn't help if Imagine.wcx is actually installed.
I think that if TC finds out that a packer plugin has been installed in a folder named "wlx", "wdx", etc. then TC should suggest to install in "wcx" instead.
User avatar
Flint
Power Member
Power Member
Posts: 3506
Joined: 2003-10-27, 09:25 UTC
Location: Belgrade, Serbia
Contact:

Post by *Flint »

Bumping. The current behaviour is quite annoying, users have to manually search and delete all files from plugins' dirs that are of wrong types in order to make TC install plugins correctly.…
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 11.03 / Win10 x64
User avatar
Balderstrom
Power Member
Power Member
Posts: 2148
Joined: 2005-10-11, 10:10 UTC

Post by *Balderstrom »

Behaviour should be forced, unless
1) User overrides a given plugin-type default install-path (ini-setting)
2) The plugin in question is already installed elsewhere.

Thus all (new) plugins will be installed into the appropriate WDX,WCX,WLX,WFX subdir of plugin-base-path.

e.g., override WLX plugin path.
[Config]
[Plugins]
pluginDefaultWLX=Lister
*BLINK* TC9 Added WM_COPYDATA and WM_USER queries for scripting.
Post Reply