[8.0ß14-x64] Colors by filetype for encrypted files

[kicko]

Colors for encrypted files doesn't work in x64 version ... it works in x86 version.

Defined selection type:
Plugin: tc
Property: ecrypted
OP: =
Value: Yes

[Flint]

Confirm, searching for files by this condition returns just empty list in 64-bit version. BTW, it seems all other attributes cannot be searched this way too. I checked Compressed and System, found nothing though the files with these attributes are present (and can be found if I search for them using the Attributes checkbox instead of tc plugin).

[Horst.Epp]

Confirmed for 8.0 b15 x64
Without plugin, search by attributes works.

[petermad]

Confirmed too.

Also - but I don't know if this is a missing feature or a bug - but color by filetype inside archives doesn't work either when the search is done by plugin. But this also applies to TC 8.0b15 32bit and TC 7.56a, so it is probably a missing feature.

[ghisler(Author)]

Thanks, that's actually a bug in Free Pascal! It returns false if two BOOL variables are both true, but one is stored internally as a=BOOL(1) and one as b=BOOL(-1). Then a=b returns false...

[MVV]

Well, usually BOOL (which is simply integer) variable is false if it is equals to zero or true if not. So 1 and -1 are both true values. The only problem that such comparison is incorrect for them...

[ghisler(Author)]

Well, in Delphi "a=b" always returns true if both a and b are true - that's what you would expect, right? In FPC, a=b only returns true if they both have the same numeric value.

[MVV]

You're right, Delphi really processes BOOL variables in special way.

Code: Select all

var
   a, b: BOOL;
   a1, b1: LongInt;
   c: boolean;
begin
  a := BOOL(1);
  b := BOOL(-1);
  c := a = b; // c becomes true
end;

[ghisler(Author)]

Yes, that's how it would be expected - true=true should give true independent from the internal representation...

[Flint]

Confirm fixed in 8.0β16.

[petermad]

I cannot test with encrypted files, since I only have the "Home" version of Windows 7, but I could reproduce the bug for compressed files, and can confirm that search for attributes by plugin now works in TC 8.0b16 x64

[ghisler(Author)]

Thanks!

[kicko]

Thank you guys ... you're great