[TC 8.0b17a x32] Different Tabulation in Main menu in Win7

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
LonerD
Senior Member
Senior Member
Posts: 381
Joined: 2010-06-19, 20:18 UTC
Location: Makeyevka, Russia
Contact:

[TC 8.0b17a x32] Different Tabulation in Main menu in Win7

Post by *LonerD »

TC 8.0b17a x32
Windows 7 x64 SP1

Different Tabulation in Main menu with and without separator in same menu.

Code: Select all

POPUP "Menu1"
MENUITEM "Get Selection from Mem&ory\tNum /", cm_RestoreSelection
END_POPUP
POPUP "Menu2"
MENUITEM "Get Selection from Mem&ory\tNum /", cm_RestoreSelection
MENUITEM SEPARATOR
END_POPUP
Menu1 Image: http://i32.fastpic.ru/big/2012/0129/a1/626802920378534ba53296143c9c64a1.png
Menu2 Image: http://i31.fastpic.ru/big/2012/0129/fb/ba0787530474e804ebd2b812a9fe14fb.png
Last edited by LonerD on 2012-01-30, 17:43 UTC, edited 1 time in total.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

What's the problem?
Author of Total Commander
https://www.ghisler.com
User avatar
LonerD
Senior Member
Senior Member
Posts: 381
Joined: 2010-06-19, 20:18 UTC
Location: Makeyevka, Russia
Contact:

Post by *LonerD »

No problem, but look wrong.
On first screen popup menu without separator - tabulation approximately equal to one space. On second screen - popup menu with separator - tabulation a lot more.
Why? Bug or feature?
"I used to feel guilty in Cambridge that I spent all day playing games, while I was supposed to be doing mathematics. Then, when I discovered surreal numbers, I realized that playing games IS math." John Horton Conway
User avatar
sqa_wizard
Power Member
Power Member
Posts: 3864
Joined: 2003-02-06, 11:41 UTC
Location: Germany

Post by *sqa_wizard »

May a left alignment vs. right alignment ?
#5767 Personal license
User avatar
LonerD
Senior Member
Senior Member
Posts: 381
Joined: 2010-06-19, 20:18 UTC
Location: Makeyevka, Russia
Contact:

Post by *LonerD »

sqa_wizard
In main menu right alignment.
Windows 7 SP1 x64.

Apropos - why the same menu in the same TC8 alignment left in WinXP and right in Win7? It bug or feature?
"I used to feel guilty in Cambridge that I spent all day playing games, while I was supposed to be doing mathematics. Then, when I discovered surreal numbers, I realized that playing games IS math." John Horton Conway
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

LonerD wrote:Apropos - why the same menu in the same TC8 alignment left in WinXP and right in Win7? It bug or feature?
Compare menu in Notepad in these two OSes.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I can confirm that there is more space to the RIGHT of "Num /" when using:

Code: Select all

POPUP "Menu2"
MENUITEM "Get Selection from Mem&ory\tNum /", cm_RestoreSelection
MENUITEM SEPARATOR
END_POPUP
as compared to using:

Code: Select all

POPUP "Menu1"
MENUITEM "Get Selection from Mem&ory\tNum /", cm_RestoreSelection
END_POPUP
This is on Windows XP 32bit with TC 8.0b17a tested Luna Theme

On Windows 7 x64 the space is the same in both 64bit and 32 bit TC 8.0b17a tested with both Aero and Luna theme.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
LonerD
Senior Member
Senior Member
Posts: 381
Joined: 2010-06-19, 20:18 UTC
Location: Makeyevka, Russia
Contact:

Post by *LonerD »

2Flint
Compare menu in Notepad in these two OSes.
And compare menu in TC7. :wink: It looks the same under XP and 7 - with left aligment.
Apparently, from TS8 was deleted a piece of code responsible for the alignment of the same menu under different operating systems.

2petermad
I don't understand.
Under Win7 x64 - you confirmed my screenshots or no?
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

LonerD wrote:And compare menu in TC7. It looks the same under XP and 7 - with left aligment.
Right. That's exactly why it was fixed in version 8.0.

Look at hotkeys in the context menu of SyncDirs tool in TC7 — they're right-aligned, because controlled by the OS. The main menu, to the contrary, is drawn by TC, that's why it was left-aligned in TC7 (TC just did not know it should right-align hotkeys in Vista+).
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2petermad
I don't understand.
Under Win7 x64 - you confirmed my screenshots or no?
Just so there is no misunderstanding what I see:

Under Windows XP 32bit
http://madsenworld.dk/tcmd/winxp_x86_1.png
http://madsenworld.dk/tcmd/winxp_x86_2.png

Under Win 7 x64 with 32bit TC 8.0b17a:
http://madsenworld.dk/tcmd/win7_x86_1.png
http://madsenworld.dk/tcmd/win7_x86_2.png

Under Win 7 x64 with 64bit TC 8.0b17a:
http://madsenworld.dk/tcmd/win7_x64_1.png
http://madsenworld.dk/tcmd/win7_x64_2.png


BTW If I click you links in the first post in FireFox, Seamonkey Google Chrome and Safari, .html is added to the link, and I am taken to a site with russian sluts.

IF I Use IE8 or Opera, your images are shown as expected, and the same are they, if I copy and paste the link into the address bar of the other browsers - Could this forum be contaminated?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

petermad wrote:BTW If I click you links in the first post in FireFox, Seamonkey Google Chrome and Safari, .html is added to the link, and I am taken to a site with russian sluts.

IF I Use IE8 or Opera, your images are shown as expected, and the same are they, if I copy and paste the link into the address bar of the other browsers - Could this forum be contaminated?
Hm… I confirm the observation (tested with Opera and FF), but the forum is not the source of the problem. If I copy-paste the link into FF, the picture is loaded. But when I press F5, it is redirected to the HTML page with the same picture framed by all those ads. I checked with Proxomitron, and it's fastpic itself that initiates redirection (returns 302 HTTP code).
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I have checked what the reason is: the horizontal line is NOT owner-drawn, but the text is. Windows seems to calculate the width of the texts by itself for ALL lines when there is at least one not owner-drawn line, and Windows and TC get different results. I will increase the space a bit in my own calculations, but I will not be able to get the exact same value as Windows does.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

01.02.12 Fixed: Main menu: Increased distance between command and hotkey a bit when there are no separators (32/64)
Confirmed that the distance is increased in TC 8.0b18.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply