[8.50ß12] TC crashes after calling 'cm_UnloadPlugins'

[Bluestar]

Hi,

I noticed it several times, but wasn't able to check where the crash comes from: now its clear.

After using the good ol' "Startup Guard" plugin for TC (which still works flawlessly even under W7SP1!) and calling the "cm_UnloadPlugins" command (even after 'exiting' the plugin and navigating to somewhere else) TC just crashes pretty bad.

Some of the exception logs (ran it several times):

01.
Exception EAccessViolation in module TOTALCMD.EXE at 065637C8.
Access Violation at address 06964A08. Read of address 06964A08.

02.
Exception EAccessViolation in module TOTALCMD.EXE at 035A8614.
Access Violation at address 039A9854. Read of address 039A9854.

03.
Exception EAccessViolation in module TOTALCMD.EXE at 01F18614.
Access Violation at address 02319854. Read of address 02319854.


Not sure if anything could be done to prevent this from the side of TC, but I thought it worths a post - maybe it can be improved somehow(?).
I guess the source of the problem is inside the plugin itself, since I couldn't reproduce it using any other of wfx till this moment.

P.S.: Maybe that doesn't helps that much, but a new exception error dialog pops up every 5 second until the end of time (maybe related to some timer?).
[screenshot]

Tested & successfully crashed under 8.50ß12, 7.57a & 7.56a.

Regards,
Bluestar

[Skif_off]

Tested & successfully crashed under 8.50ß12, 7.57a & 7.56a.

8.01 too. Look at the RedGUARD

[MVV]

Unloading is the operation that any DLL does every time when program is closed but some plugins cause bugs on unloading.

BTW I'm using Sysinternals Autoruns when I need to analyze autorun entries, and I can start it elevated in contrast to plugin.

[Bluestar]

@Skif_off:
I use RedGUARD too, but it misses some core functions which exists in StartupGuard and not in Red. Its not a real replacement until these are implemented...

@MVV:
I know Autoruns as well & use it a lot, but it takes ages to load up all these entries. Sometimes I just need the HKLM/HKCU ones, and thats when a wfx plugin comes handy.

Dunno what StartupGuard does (or what it misses to do..) that leads to this bad crash, but would be nice to know if anything could be done from the side of TC or not - maybe some other plugins are affected as well.

Edit: Uh-oh. I fear Christian is aware of the problem.

Code: Select all

13.08.09 Release Total Commander 7.50 RC1
12.08.09 Fixed: Crash on exit after using Startup Guard plugin (due to a bug in the plugin, still occurs when using cm_UnloadPlugins)

Thats it end of story nothing could be done you're free to close the topic thx. (not_TC's_fault_confirmed)
(btw I still wonder what exactly has been fixed on exit? Couldn't it be done for cm_UnloadPlugins as well?)

[MVV]

Bluestar,
Try to start Autoruns and press Ctrl+Tab, it will switch to Logon tab with only Run registry keys and Startup main menu folders, quite fast.

[Bluestar]

@MVV:
Still took 4 seconds to list all my logon entries, which is exactly 4 seconds more than the time I have for this simple action (wfx does it instantly).
(btw the whole scanning/initialization of autoruns took more than 8 secs...)

[ghisler(Author)]

Unfortunately all these addresses aren't in TC itself, so it probably crashes in a misbehaving plugin...

[Bluestar]

@ghisler(Author):
Thanks for checking it, so its StartupGuard that'd really need a bugfix...