[TC9b3] Ugly and unnecessary line on classic theme

Dalai · Post by *Dalai » 2016-06-23, 20:31 UTC

Hi there

There's a really ugly line in the status bar on TC9 beta3 on WinXP when classic theme is used and at least two tabs are opened. See the following pictures:
Two tabs opened
No tab open

This may also be the case when the option "Show tab header also when there is only one tab" is enabled. Sometimes (when changing directory) the line is hidden, sometimes it's visible (after refreshing the same directory via Ctrl+R).

This does not happen on Win7 with classic theme. [EDIT] Oops, tested with the wrong version. This bug also applies to Win7! [/EDIT]

Regards
Dalai

MVV · Post by *MVV » 2016-06-23, 20:57 UTC

This line is a border of tab control... Well, maybe it is really better to remove it.

Dalai · Post by *Dalai » 2016-06-23, 21:08 UTC

Well, it may be some border but I don't think it should be there when command line is hidden. It may serve some purpose when command line is displayed, but I don't see any when the command line is hidden, which is true for all of my systems; I open the command line via Alt+F8 or Cursor-right only when necessary.

Regards
Dalai

Sob · Post by *Sob » 2016-06-23, 21:14 UTC

It just has wrong color. The whole tab control is raised and this bottom border should have same color (clBtnShadow) as right border. Then it wouldn't stick out.

Dalai · Post by *Dalai » 2016-06-23, 21:26 UTC

This line is not visible at all when themes are enabled. So, either the line has wrong color AND wrong placement or just wrong placement on classic theme. It's not just the color, but two lines adjacent to each other is just wrong. But you're partially right: when themes are enabled the line changes its color when tabs are opened/closed; this is more noticable on XP Luna theme.

Regards
Dalai

Sob · Post by *Sob » 2016-06-23, 22:19 UTC

If you look closely, themed TC actually removes the line from bottom bar with function keys, not the one with wrong dark color from tab control. In fact, it seems to remove it unconditionally, it's not there even with command line enabled (tested with Windows XP, 7, 8.1 and 10). Only with Classic theme it's still there.

Previously TC 8.x had the bottom of tab control strangely cut off. But it worked fine for you without command line and also for those with it, because both command line and function keys had own top line. I mean Classic theme, it wasn't very nice with others.

Dalai · Post by *Dalai » 2016-06-23, 23:22 UTC

Sob wrote:If you look closely, themed TC actually removes the line from bottom bar with function keys, not the one with wrong dark color from tab control. In fact, it seems to remove it unconditionally, it's not there even with command line enabled (tested with Windows XP, 7, 8.1 and 10). Only with Classic theme it's still there.

You're right.

Previously TC 8.x had the bottom of tab control strangely cut off.

Yes, I noticed that, too, but it never bothered me and I never considered this a bug big enough to complain about it.

I mean Classic theme, it wasn't very nice with others.

No, but it was consistent. No line there in TC8 when command line is hidden, regardless of the number of tabs.

Regards
Dalai

Dalai · Post by *Dalai » 2016-07-07, 01:14 UTC

Unfortunately this is still not fixed in TC9 beta4

.

MVV · Post by *MVV » 2016-07-07, 08:39 UTC

It should be definitely painted with lighter color, just like right tab control border...

Dalai · Post by *Dalai » 2016-07-07, 13:37 UTC

Yep. The following might have something to do with this.

Enable themes
Open at least two tabs in one TC panel, close all tabs on the other panel
If you look closely on the line below the file list, you can see that the line of the panel showing tabs is drawn 1px above the line of the panel without the tabs. Here's a screenshot; I've added a red line to make it easier to spot.
This gets more visible when you open and close tabs on one panel repeatedly. The line is not drawn at the same place but one pixel down/up respectively when tabs are opened/closed.

Maybe this is the same line that's black on classic theme.

Regards
Dalai

Post by *ghisler(Author) » 2016-07-07, 14:41 UTC

Seems that I misunderstoode the initial report. Do you mean that I should remove the line you marked in red?

Dalai · Post by *Dalai » 2016-07-07, 14:56 UTC

ghisler(Author) wrote:Do you mean that I should remove the line you marked in red?

No. I've added this red line so you can spot the 1px difference of the two panels easier. Like I said, I don't know whether this difference has something to do with the black line that is shown on classic theme, it's just a guess.

Regards
Dalai

Sob · Post by *Sob » 2016-07-08, 00:46 UTC

If I may help a little:

1) With Classic theme, when there are more than one tab open in panel, bottom line (1) should have same color (clBtnShadow) as right line (2):
Image: http://web.hisoftware.cz/sob/tc/tc9-file-panel-bottom-line.png
Easy fix, just change the color.

2) With Aero themes, panels with and without multiple tabs have different frames. Which may be expected, because panel with multiple tabs gets its border from tab control, while panel without tabs gets it either from list control or you perhaps draw it yourself (just guessing). Unfortunately, the dark line in multi-tab panel is at position by one pixel higher and the light line is either hardly visible (Windows 7) or not visible at all (Windows 8.1 and 10, where it has same color as background). So it gives an impression like they are misaligned. Screenshot from Windows 7:
Image: http://web.hisoftware.cz/sob/tc/tc9-file-panels-different-frames.png
I don't know if there's some easy way to make it look better. Perhaps making panel without tabs lower (shorter) by one pixel might do the trick?

Post by *ghisler(Author) » 2016-07-11, 07:40 UTC

The lines above the red line cannot be removed -they are part of the folder tab panels, and are drawn by Windows.

MVV · Post by *MVV » 2016-07-11, 07:54 UTC

But why do these lines have non-standard color?