Icon for tab header not applied in default view

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Icon for tab header not applied in default view

Post by *Lefteous »

When assigning an icon to the default view mode it's not used in the tab header. Storing of the setting works fine, other settings like tab header background color are applied correctly.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Indeed the default view mode doesn't currently support icons. I will check whether I can add it or have to disable the control.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Same thing applies to the tab header color - you can set it (the control is not disabled) - but the change doesn't stick - it wouild be nice to be able to set a color for <Standard> view.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Actually it's a bug in 64-bit version: The default view mode should neither have icons nor colors! The colors for default view mode are defined via Configuration - Options - Color. 32-bit version correctly disables these controls for default mode.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

The colors for default view mode are defined via Configuration - Options - Color.
Yes, but you cannot set the color of the folder tabs there.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

No, default view mode should leave the tabs uncolored. They should really be used to signal something special like ZIP, FTP etc.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Hmm I think it would be nice to be able to make the folder tab color match the default background color which is not necessarily white
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2ghisler(Author)

I fully agree about leaving the icons uncolored in default mode. I'm not sure if I agree about the icons though. Having tab headers with and without icons leads to a visual imbalance.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

For now I have disabled color and icon configuration for the default view mode. I agree that it could be a good idea to allow icons, so I will investigate whether this can be done when I find the time.
Author of Total Commander
https://www.ghisler.com
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2ghisler(Author)
I agree that it could be a good idea to allow icons, so I will investigate whether this can be done when I find the time.
It seems displaying an icon in the tab header using the <default> view mode works fine starting beta 4. Thank you!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I haven't explicitly changed that, but it may have been a side effect of other changes I made. If it does indeed work, I will make it configurable via settings.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

It seems displaying an icon in the tab header using the <default> view mode works fine starting beta 4.
Hmm I don't see that - here it is still disabled for the <default> view mode. And even if I set it manually in wincmd.ini, it is shown in the configuration dialog, but not on the tabs.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2petermad
Hmm I don't see that - here it is still disabled for the <default> view mode.
I configured it like that in a previous version where it wasn't disabled.
And even if I set it manually in wincmd.ini, it is shown in the configuration dialog, but not on the tabs.
That's strange. Manually setting it should really work. This is the defined view mode:

Code: Select all

0_name=Standard
0_icon=shell32.dll,3
0_options=6|0|0||-1|-1|-1
I also found out that it works for all inactive tabs when starting TC but as soon as you click on such a tab the icon is gone...
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I also found out that it works for all inactive tabs when starting TC
Ahh, I dont have any tabs open when I start my TC, so that's why I didn't see it. If I have saved tabs, I can confirm your observation.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

No, it's not working properly yet - I had to make a small change so it works when you go from a view mode with icon back to default view mode.
Author of Total Commander
https://www.ghisler.com
Post Reply