[9.0ß6] Auto Switch rule names displayed with vertical line

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3506
Joined: 2003-10-27, 09:25 UTC
Location: Belgrade, Serbia
Contact:

[9.0ß6] Auto Switch rule names displayed with vertical line

Post by *Flint »

1. Open Configuration -> Auto Switch Mode.
2. Create a new rule with at least two sub-rules.
3. Combine the sub-rules with OR => TC will display the rule title as

Code: Select all

+||+
4. Combine the sub-rules with AND => TC will display the rule title as

Code: Select all

+|&+
I'm not sure what the original intention was, but the "|&" looks definitely wrong. It should be either || and && for OR and AND, respectively (like in C-like programming languages), or single-character | and & (like in TC interface). The latter looks more consistent, I think.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 11.03 / Win10 x64
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

I don't see why this should be a bug. The first pipe is a separator, the second is the logical operator. The behavior seems to be just fine. So it's not a bug.

I totally agree that it doesn't look right though. Why all kind of things have to be displayed in the same way as they are stored in the INI file? Why not omit the first pipe and add a space before and after the logical operator?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, they are displayed as they are stored. It's a good idea to make them a bit more readable.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This has been changed in beta 7, please let me know what you think.
Author of Total Commander
https://www.ghisler.com
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

Showing just the operator without the pipe is really better - thank you :-)

However there is almost no rule defined here where I can fully read all rule elements. In some rules I cannot even see the first operator. Please consider my suggestion to make this dialog a subdialog of the view modes dialog and fully resizable.
http://www.ghisler.ch/board/viewtopic.php?p=309061#309061
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I have considered it, but it would take even more clicks then to change it, so people would use it even less. :(
Author of Total Commander
https://www.ghisler.com
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

Why do you think people are not using? It's really well done.

In case the user creates a rule after creating the view mode it's not even an extra click. When creating it later it would be nice to avoid an extra click (though not a big deal). This could be achieved by adding a new menu item to the right click tab menu that would display this dialog directly. This could actually boost usage of the auto-switch feature as it's one the same menu as the most common way to use the manual switch.
User avatar
Flint
Power Member
Power Member
Posts: 3506
Joined: 2003-10-27, 09:25 UTC
Location: Belgrade, Serbia
Contact:

Post by *Flint »

ghisler(Author)
Confirm that now only single character is displayed.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 11.03 / Win10 x64
Post Reply