TC shows only the first 87 icons from a custom Wcmicon_x.dll

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

TC shows only the first 87 icons from a custom Wcmicon_x.dll

Post by *ts4242 »

I don't know if this is a bug or by design (i consider it is bug)

1- Set custom Wcmicon_x.dll contains more than 87 icons as default library
2- Open Change button bar dialog
3- Add internal command has entry in Wcmicons.inc e.g. cm_Copy
4- Icon file: field shows wcmicons.dll (That's OK, i know it is intended)
5- TC shows only the first 87 icons from the custom dll, so there is no chance to select any icon beyond the first 87 icons except if manually browse for Wcmicon_x.dll
User avatar
Ovg
Power Member
Power Member
Posts: 756
Joined: 2014-01-06, 16:26 UTC

Post by *Ovg »

Confirmed on both versions of TC 9.0a RC1
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 11.01 x64, Windows 7 SP1 x64
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Also confirmed in prior beta versions of TC9

But it is only true if the icon-index of the internal command is the same as the icon-index in wcmicons.inc. If the iconlib has its own .inc file and the index of the command is above icon 87, then all the icons in the iconlib is shown.

So in a way there is no bug, because if the index of the command is found in wcmicons.inc TC always uses wcmicons.dll as the reference - in order to have the icons changed when you change iconlib and hence don't need more than the 87 icons.

Notice that if the em_command has the same index in wcmicons.inc and the iconlib's .inc file, then TC shows wcmicons.dll as the iconfile in the "Change button bar" dialog - only if the em_command has a different index in wcmicons.inc and the iconlib's .inc file is the iconlib's .dll file shown in the "Change button bar" dialog.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, icon dll with different icon arrangement (or more icons) than original needs to use a separate inc file.
Author of Total Commander
https://www.ghisler.com
Post Reply