TC4A TCMP: restore playlist and removed tracks

Support for Android version of Total Commander

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

TC4A TCMP: restore playlist and removed tracks

Post by *DrShark »

Since TC4A v. 2.80 TCMP restores playlist if the player reopened (for example using a button with command 137) after being closed using red X button or Android Navigation Bar buttons/keys.

However, what I see wrong in this feature is that it also restores the tracks explicitly removed from playlist by user using the "Remove"/"Remove all"/"Remove all above" track context menu items. I think such tracks shouldn't be restored.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Hmm, I'm not so sure about that - consider the situation where a user deletes the entire list and closes the player.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark »

ghisler(Author) wrote:consider the situation where a user deletes the entire list and closes the player.
if user removes entire playlist using one of mentioned "Remove..." options, it's supposed one may want to make it empty (for example to add new files later using player's "Add files" ("+" button) option.)

If user wants to have playlist restored later, it's possible to just close the player using player's X button.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, changed that in the latest beta 8! Please try it.

Play store:
https://www.ghisler.com/betatc
APK:
https://www.ghisler.com/tcbeta.apk
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark »

ghisler(Author) wrote:OK, changed that in the latest beta 8! Please try it.
history2.txt wrote:2017-08-27 Fixed: Media player: Save playlist on exit even after deleting tracks, just not after "delete all"
That just not after "delete all" part means that at least one track is always restored in playlist, so the use case described in previous post is not covered by such solution (it's possible to get the emtpy playlist saved/restored using re-adding by Open with -> TotalCmd (Queue) a single track in playlist, but too many steps required to achive it this way.)
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, that's intentional - it's just when you choose to remove all tracks - it could be by accident. If you remove one by one, the empty list should be stored.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark »

ghisler(Author) wrote:If you remove one by one, the empty list should be stored.
I cannot confirm it:
a) if I remove tracks one by one using Remove context item and restart the player using either a button with internal command 137 or button TotalCmd (Queue) activity as a command, all tracks are restored;
b) if I remove tracks all tracks except one using either Remove all above or Remove all below context menu item, and then remove last track usilon Remove context item, and restart the player using either a button with internal command 137 or button TotalCmd (Queue) activity as a command, the last track restored.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, it's an additional measure to never store empty list.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark »

That are false statments then:
ghisler(Author) wrote:If you remove one by one, the empty list should be stored.
history2.txt wrote:2017-08-27 Fixed: Media player: Save playlist on exit even after deleting tracks, just not after "delete all"
because:
DrShark wrote:if I remove tracks one by one [or] [...] using either Remove all above or Remove all below context menu item, and then remove last track using Remove context item, and restart the player using either a button with internal command 137 or button TotalCmd (Queue) activity as a command, the last track restored.
ghisler(Author) wrote:Yes, it's an additional measure to never store empty list.
The whole point of this topic is to let user have playlist restored as is (even empty!) after intentional removing the tracks using "Remove ..." track context menu items. Can you try at least add an option to have desired behavior?
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Post Reply