Shift+F7 - strange behavior

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Shift+F7 - strange behavior

Post by *MarcinW »

Steps to reproduce:

1) select any file
2) press Shift+F7
3) press Esc
4) selection is moved to the opposite panel

I suppose that moving the selection is not intentional in case of cancelling the operation.

Regards
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I have considered moving the focus back, but decided against it for consistency between OK and Cancel.

What do other users think?
Author of Total Commander
https://www.ghisler.com
jberry910
Junior Member
Junior Member
Posts: 25
Joined: 2010-02-08, 02:43 UTC
Location: Illinois, USA

Post by *jberry910 »

For me, leaving the focus in the initial panel would be more consistent with the way I would use this. So, if I use Shift-F7 from the right panel to create a new folder in the left panel, I would expect the focus to stay in the right panel.
Joe
Central Illinois, USA
User avatar
Dalai
Power Member
Power Member
Posts: 9364
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

Mmh, for me, cancelling an operation should restore the previous state, in this case returning the focus to the panel it was before - i.e. when pressing Shift+F7 when the left panel is active, the left panel should have the focus after cancelling but the right panel may have the focus when the operation is executed.

However, I don't think that it's a big deal because the opposite panel is just a TAB away ;).

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
Stefan2
Power Member
Power Member
Posts: 4133
Joined: 2007-09-13, 22:20 UTC
Location: Europa

Post by *Stefan2 »

ghisler(Author) wrote:I have considered moving the focus back, but decided against it for consistency between OK and Cancel.

What do other users think?

Since nothing is done in the other panel in such case, I would like it to be like that:
jberry910 wrote:For me, leaving the focus in the initial panel would be more consistent ...




 
User avatar
Hacker
Moderator
Moderator
Posts: 13052
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

I agree, when cancelling then it should not have any effect such as focus change.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I think that the focus should stay on the source, but the cursor in the target side should be moved to the new directory, so that a press on Tab will highlight the new dir.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

I agree with cancel shouldn't change the focus.

There is a workaround by creating the following extended command and assign <Shift+F7> to it

Code: Select all

[em_MkDirOther]
cmd=cm_MkDirOther, cm_FocusTrg
menu=Make directory in target panel
button=wcmicons.dll,29
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, the cursor is now returned to the source when you press ESC in beta 5!

Furthermore, the dialog will be shown over the panel in which the directory will be created. Not centered, but moved a bit to the center of the main window.
Author of Total Commander
https://www.ghisler.com
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

This feature with de-centered dialog window is great! :)

Original problem fixed.

Regards
User avatar
Hacker
Moderator
Moderator
Posts: 13052
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

Confirm fixed.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Much more intuitive in TC 9.20b5 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

Good addition, but it is not take panel arrangement into account viewtopic.php?p=342190#342190
Post Reply