This forum uses cookies. Click X button to hide this message. What is stored? / Privacy
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Incorrect file length count in "long name" warning
Goto page Previous  1, 2
 
Post new topic   Reply to topic    Total Commander Forum Index -> TC9.1x bug reports (English) Printable version
View previous topic :: View next topic  
Author Message
MarcinW
Power Member
Power Member


Joined: 23 Jan 2012
Posts: 836
Location: Poland

PostPosted: Thu May 24, 2018 9:17 am    Post subject: Reply with quote

UPDATE: still not fully fixed - try to set file name with 256 colons (:::::::::::::::: ...).

You still get the "please remove write protection" message.

Regards
Back to top
View user's profile Send private message Send e-mail
Dalai
Power Member
Power Member


Joined: 28 Jan 2005
Posts: 6046
Location: Meiningen (Südthüringen)

PostPosted: Thu May 24, 2018 9:48 am    Post subject: Reply with quote

Well, it seems that invalid characters are checked before the file name length. Makes sense to me. However, the error message needs improvement; it's always been this meaningless - but that's really OT now.

Regards
Dalai
_________________
#101164 Personal licence
Athlon X4 880K, 16 GiB RAM, Gigabyte F2A88X-D3HP, Win7 x64

Plugins: Services2, Startups
Back to top
View user's profile Send private message Send e-mail
MarcinW
Power Member
Power Member


Joined: 23 Jan 2012
Posts: 836
Location: Poland

PostPosted: Thu May 24, 2018 10:27 am    Post subject: Reply with quote

History.txt wrote:
21.05.18 Fixed: When copying/moving/renaming a file, show "Invalid name" error when Windows reports an invalid name or path (error 123 or 161) (32/64)

I just wanted to say that - when you call MoveFile API to set file name to :::::::: - you get error code 123, but the error message is still "please remove write protection" (as it was before) - NOT "Invalid name", as it was intended (and described History.txt). So there must be still some problem with the current implementation.

Regards
Back to top
View user's profile Send private message Send e-mail
MarcinW
Power Member
Power Member


Joined: 23 Jan 2012
Posts: 836
Location: Poland

PostPosted: Thu Jun 14, 2018 6:21 am    Post subject: Reply with quote

I made a quick research. When entering a proper new name for the file, the MoveFileEx API is called to do its work.

But when entering ::::::: as a file name, MoveFileEx call is not reached - so it has no chance to return error code 123 (which would display the "Invalid name" error).

Instead, some earlier TC code rejects ::::::: as a file name, displaying the "please remove write protection" error (instead of the expected "Invalid name" error).

Regards
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC9.1x bug reports (English) All times are GMT - 6 Hours
Goto page Previous  1, 2
Page 2 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Imprint/Impressum: This site is maintained by Ghisler Software GmbH
Privacy Policy | Datenschutzerklärung | Politique de Confidentialité

Using phpBB © phpBB Group