This forum uses cookies. Click X button to hide this message. What is stored? / Privacy
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

1-minute improvement in "Change attributes" dialog

 
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs Printable version
View previous topic :: View next topic  
Author Message
MarcinW
Power Member
Power Member


Joined: 23 Jan 2012
Posts: 841
Location: Poland

PostPosted: Sat Jun 09, 2018 5:34 am    Post subject: 1-minute improvement in "Change attributes" dialog Reply with quote

Currently, empty Date / Time fields are valid in "Change attributes" dialog and mean "no change here". But the problem is when there is some space inserted into these fields (even by mistake) - it can't be easily seen by the user, and TC displays an error message, that can be misleading:
Code:
---------------------------
Change attributes
---------------------------
Invalid input!

Date: 
Time: 
---------------------------
OK   
---------------------------

The user may think, that empty fields are not allowed (although they are not in fact empty, but the user may think so).



So my suggestion is:

Could you please remove spaces (trim them from both left and right) first, when processing strings entered by the user in Date / Time fields?

Regards
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35761
Location: Switzerland

PostPosted: Mon Jun 11, 2018 7:30 am    Post subject: Reply with quote

Thanks, it's indeed a good idea to remove all leading and trailing spaces.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
MarcinW
Power Member
Power Member


Joined: 23 Jan 2012
Posts: 841
Location: Poland

PostPosted: Thu Jun 14, 2018 4:58 am    Post subject: Reply with quote

Now works properly, thanks!
Back to top
View user's profile Send private message Send e-mail
Hacker
Moderator
Moderator


Joined: 06 Feb 2003
Posts: 10893
Location: Bratislava, Slovakia

PostPosted: Thu Jun 14, 2018 5:28 am    Post subject: Reply with quote

Moderation:
Moved to the English forum.

Hacker (Moderator)

_________________
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
Back to top
View user's profile Send private message Send e-mail
MarcinW
Power Member
Power Member


Joined: 23 Jan 2012
Posts: 841
Location: Poland

PostPosted: Thu Jun 14, 2018 5:42 am    Post subject: Reply with quote

@Hacker

I'm not sure if this topic contains any information, that could be helpful to the users. I suppose, that "Fixed Bugs" would be a better place for this topic...

Regards
Back to top
View user's profile Send private message Send e-mail
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7799
Location: Valsted, Denmark

PostPosted: Thu Jun 14, 2018 7:07 am    Post subject: Reply with quote

Quote:
"Fixed Bugs" would be a better place for this topic...

I agree...
_________________
#524
Danish Total Commander Translator
TC 9.20rc1 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b3 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Hacker
Moderator
Moderator


Joined: 06 Feb 2003
Posts: 10893
Location: Bratislava, Slovakia

PostPosted: Thu Jun 14, 2018 7:59 am    Post subject: Reply with quote

MarcinW,
Yeah well, was it a bug...?
OK, let's say it was.

Roman
_________________
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
Back to top
View user's profile Send private message Send e-mail
Hacker
Moderator
Moderator


Joined: 06 Feb 2003
Posts: 10893
Location: Bratislava, Slovakia

PostPosted: Thu Jun 14, 2018 8:00 am    Post subject: Reply with quote

Moderation:
Moved to the Fixed bugs forum.

Hacker (Moderator)

_________________
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Imprint/Impressum: This site is maintained by Ghisler Software GmbH
Privacy Policy | Datenschutzerklärung | Politique de Confidentialité

Using phpBB © phpBB Group