cm_FileSync results -- bug

English support forum

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
MarkFilipak
Member
Member
Posts: 106
Joined: 2008-09-28, 01:00 UTC
Location: Mansfield, Ohio

cm_FileSync results -- bug

Post by *MarkFilipak » 2019-07-27, 05:44 UTC

I upgraded from 9.21a to 9.22a with the hope that a bug had been fixed. I hasn't. Here's the bug:
Function: 'cm_FileSync'
cm_FileSync appears to not work. Result status is wrong.

Example of wrong result: "Files found: 0/178 (Identical: 0/178, Different: 0, Unique left: 0, Unique right: 0)"

Zero files found? The left & right file lists are identical, yet TC says "Files found: 0/178"

Steps to reproduce:
Left directory is original. Right directory is back-up.
Copy left to right (I copied 178 files).
Perform 'cm_FileSync'
See "Files found: 0/178" status.

Is the 'cm_FileSync' actually happening? Or is it broken?

Warm Regards,
Mark.
Hi Christian! Delighted customer since 1999. License #37627

User avatar
Stefan2
Power Member
Power Member
Posts: 2643
Joined: 2007-09-13, 22:20 UTC
Location: Europa

Re: cm_FileSync results -- bug

Post by *Stefan2 » 2019-07-27, 08:01 UTC

Hi Mark.
MarkFilipak wrote:
2019-07-27, 05:44 UTC

Example of wrong result: "Files found: 0/178 (Identical: 0/178, Different: 0, Unique left: 0, Unique right: 0)"

Zero files found? The left & right file lists are identical, yet TC says "Files found: 0/178"

What do you expect instead?

> "The left & right file lists are identical," ..... so "Files found: 0/178" for to sync. No need to sync at all.


You are in the sync tool, so "Files found:" is related to files indicate to be different.


Or do I miss smtg here?



 
Inofficial FAQs || WIKI (Deu/Eng) || TC Home (What's new? // FAQ // Download // Order // Addons // Tools // Plugins)
Erst wenn der letzte Baum gefällt oder die letzte Biene verendet ist, werden die Leute verstehen warum Umweltschutz wichtig ist.

User avatar
petermad
Power Member
Power Member
Posts: 8867
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: cm_FileSync results -- bug

Post by *petermad » 2019-07-27, 08:10 UTC

"Files found: 0/178"
This means: 0 out of 178 files are found that will be synchronized.
Try and change one of the files - then it will say: "Files found: 1/178".
License #524 (1994)
Danish Total Commander Translator
TC 9.5b3 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
sqa_wizard
Power Member
Power Member
Posts: 3502
Joined: 2003-02-06, 11:41 UTC
Location: Germany

Re: cm_FileSync results -- bug

Post by *sqa_wizard » 2019-07-27, 09:48 UTC

Files found: 0/178 (Identical: 0/178
The main reason to show "Identical: 0/178" is: You have disable the [=] button and therefore excluded the display of identical files!
Just enable it and you will see "Identical: 178/178" :)
#5767 Personal license

User avatar
MarkFilipak
Member
Member
Posts: 106
Joined: 2008-09-28, 01:00 UTC
Location: Mansfield, Ohio

Re: cm_FileSync results -- bug

Post by *MarkFilipak » 2019-07-27, 17:40 UTC

Stefan2 wrote:
2019-07-27, 08:01 UTC
... What do you expect instead?
"Files found: 178/178 (Identical: 178/178, Different: 0, Unique left: 0, Unique right: 0)"

The status doesn't say "Files found that need to be synched: 0/178".

And certainly "Identical: 0/178" in the case that there are 178 identical files makes no sense to me.
Hi Christian! Delighted customer since 1999. License #37627

User avatar
MarkFilipak
Member
Member
Posts: 106
Joined: 2008-09-28, 01:00 UTC
Location: Mansfield, Ohio

Re: cm_FileSync results -- bug

Post by *MarkFilipak » 2019-07-27, 17:59 UTC

sqa_wizard wrote:
2019-07-27, 09:48 UTC
Files found: 0/178 (Identical: 0/178
The main reason to show "Identical: 0/178" is: You have disable the [=] button and therefore excluded the display of identical files!
Just enable it and you will see "Identical: 178/178" :)
Yes, I understand that, but think about it a moment. If I have [=] enabled, the main window shows me that there are 178 identical files, so in that case, the status line merely shows a summary of what's already in the main window. If that's the case, I don't need the summary at all, do I? It's redundant.

Now, suppose that I have [=] enabled and instead of 178 files, I have 17800 files? In that case, the main window is almost useless because finding the non-matches in a list of 17800 files is very tedious. That's the usual case when I use 'cm_FileSync' as a back-up tool.

If the status is an adjunct to the main window, then it's redundant. However, if the status always shows the results of the comparison irrespective of the [=] setting, then it's consistent and always valid.

I actually never enable [=]. Why would I? But in the future I guess I'll have to momentarily enable [=] in order to assure myself that, indeed, a full comparison was made and that all files were actually found.

PS: By the way, you know who suggested the current display: [->] [==] [!=] [<-] ?
Me. I wrote to Christian many years ago and suggested it. I could probably find the actual message (I save all email). Christian implemented it in the next version.

Perhaps the best solution is as follows:
[### ->] [### ==] [### !=] [### <-]
where ### is the actual number of files in each category. It occurs to me that such would satisfy everyone. What do you think? What does Christian think?
Hi Christian! Delighted customer since 1999. License #37627

User avatar
Dalai
Power Member
Power Member
Posts: 6753
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: cm_FileSync results -- bug

Post by *Dalai » 2019-07-27, 18:56 UTC

The first pair of numbers after "Files found" is the total sum of everything, which is then further broken down, explained and counted in the brackets after that. Note that the number before the slash depends on what is shown (defined by the options set in the Show group).

Example (enabled all buttons except equal files):

Code: Select all

Files found: 22/1253 (Identical: 0/1231, Different: 22, Unique left: 0, Unique right: 0)
1231 identical files plus 22 different files equals 1253 files in total. I don't see any issue here.

After synchronizing, TC shows this

Code: Select all

Files found: 0/1253 (Identical: 0/1253, Different: 0, Unique left: 0, Unique right: 0)
So, still 1253 files in total, but no difference anymore. I still don't see a problem.

If you're confused by the phrase "Files found", I'm pretty sure that it can be changed via the language files. Maybe "Files shown" would be better. On the other hand, you have to keep in mind that found files also depend on the files filter in the upper middle part of the TC sync window, meaning it indeed is "Files found" based on that filter (and probably the TC ignore list).

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups

User avatar
MarkFilipak
Member
Member
Posts: 106
Joined: 2008-09-28, 01:00 UTC
Location: Mansfield, Ohio

Re: cm_FileSync results -- bug

Post by *MarkFilipak » 2019-07-27, 20:04 UTC

Dalai wrote:
2019-07-27, 18:56 UTC
... I still don't see a problem.
When a file compare program (or any program, really) says "Files found: 0", the natural conclusion is that zero files were found and that the program therefore had nothing to do, and consequently did nothing.

I posted the topic starter believing that "Files found: 0" was an error (not by design). That it is by design seems screwy to me, but I can live with it; like I wrote earlier, I'll simply press [=] to confirm all files were actually found and compared. I don't think that filters (if any) are relevant to "Files found: 0".
Hi Christian! Delighted customer since 1999. License #37627

User avatar
Dalai
Power Member
Power Member
Posts: 6753
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: cm_FileSync results -- bug

Post by *Dalai » 2019-07-27, 21:08 UTC

MarkFilipak wrote:
2019-07-27, 20:04 UTC
When a file compare program (or any program, really) says "Files found: 0", the natural conclusion is that zero files were found
But TC doesn't say that. You're ignoring half of the numbers TC shows. It says 0/XY, where XY is the total sum and 0 is the number of files shown in the list.

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups

User avatar
MarkFilipak
Member
Member
Posts: 106
Joined: 2008-09-28, 01:00 UTC
Location: Mansfield, Ohio

Re: cm_FileSync results -- bug

Post by *MarkFilipak » 2019-07-28, 03:52 UTC

Dalai wrote:
2019-07-27, 21:08 UTC
MarkFilipak wrote:
2019-07-27, 20:04 UTC
When a file compare program (or any program, really) says "Files found: 0", the natural conclusion is that zero files were found
But TC doesn't say that.
It surely does.
You're ignoring half of the numbers TC shows.
That's true. I'm confused by the status.

If I said "Money found: 0/10€", would you conclude that there's no money there, or that it just wasn't found?

The full status is:
"Files found: 0/178 (Identical: 0/178, Different: 0, Unique left: 0, Unique right: 0)"
To me that says no files were found, none are identical, none are different, none are unique. I really don't know what to make of that. What makes sense to me is:
"Files found: 178/178 (Identical: 178/178, Different: 0, Unique left: 0, Unique right: 0)"

We're just going to have to agree to disagree.
Hi Christian! Delighted customer since 1999. License #37627

User avatar
MarkFilipak
Member
Member
Posts: 106
Joined: 2008-09-28, 01:00 UTC
Location: Mansfield, Ohio

Re: cm_FileSync results -- bug

Post by *MarkFilipak » 2019-07-28, 04:09 UTC

Dalai wrote:
2019-07-27, 18:56 UTC
... Example (enabled all buttons except equal files):

Code: Select all

Files found: 22/1253 (Identical: 0/1231, Different: 22, Unique left: 0, Unique right: 0)
1231 identical files ...
To me it says zero of 1231 files are identical.

PS: How about this?
Files to sync: 22 (Identical: 1231, Different: 22, Unique left: 0, Unique right: 0)
Another case:
Files to sync: 22 (Identical: 1231, Different: 19, Unique left: 2, Unique right: 1)
Another case:
Files to sync: 0 (Identical: 1253, Different: 0, Unique left: 0, Unique right: 0)
Hi Christian! Delighted customer since 1999. License #37627

vdijken
Junior Member
Junior Member
Posts: 80
Joined: 2016-07-30, 14:07 UTC
Location: The Netherlands

Re: cm_FileSync results -- bug

Post by *vdijken » 2019-07-28, 06:16 UTC

You forgot to activate the button "double". When you keep the cursor on that button, the explanation "Files that exist on both sides" pops up and that is what you miss.

User avatar
Dalai
Power Member
Power Member
Posts: 6753
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: cm_FileSync results -- bug

Post by *Dalai » 2019-07-28, 15:11 UTC

2MarkFilipak
To change the text, create a file %COMMANDER_PATH%\Language\wcmd_eng.lng in with the following contents:

Code: Select all

English
1321="Files shown/found:"
Next, select that language (file) in Configuration > Options > Language.

This way, is exactly says what TC shows.

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups

Post Reply