Feature request: make the color of the cursor of the inactive panel setable

English support forum

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
SSc
Junior Member
Junior Member
Posts: 67
Joined: 2015-10-27, 10:12 UTC
Location: Karlsruhe

Feature request: make the color of the cursor of the inactive panel setable

Post by *SSc »

First of all many thanks to Mr. Ghisler for the 9.50 Beta 1 (and especially the Dark Mode). Very nice inceed!

The Dark Mode brings me to an old topic for which I would like to submit a suggestion for improvement. In Dark Mode I personally find the frame color of the cursor line of the inactive panel too bright. Sometimes it happens to me that I identify the inactive panel optically as an active panel.

It would therefore be great if you could set the frame color of the cursor line of the inactive panel yourself (an ini entry would be completely sufficient for me). The screenshot will hopefully make it clear what I mean

Thanks for listening,
Stefan

Image: https://ibb.co/9bpw1kp
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *petermad »

You can control it with the parameter InactiveFocus
InactiveFocus=0 Set to 1 or RGB value (see description of BackColor below) to show cursor in the target panel too. Accepts hex in form $BBGGRR.
Add $1000000 = dashes, $2000000=dashes/dots, $3000000=solid frame
I recommend InactiveFocus=1 - then you will have a dashed outline where the color is reverted in Dark Mode - otherwise you will have to find a color that works in both Dark and Normal mode (in case you till wants to also use Normal Mode).
Last edited by petermad on 2019-10-18, 19:36 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
SSc
Junior Member
Junior Member
Posts: 67
Joined: 2015-10-27, 10:12 UTC
Location: Karlsruhe

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *SSc »

Brilliant, thanks a lot! That's exactly what I needed! 👍
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *Usher »

Still there should be separate settings for InactiveFocus in dark mode:
1. Properly set dark mode IS NOT just simple reversing colors and reusing font settings. Many people need to set bold or larger font in dark mode to keep good visibility. It also means, that they may use different colors for active/inactive cursor.
2. In older Windows people will probably set manually separate themes for normal and dark and modes so all colors, including InactiveFocus, should be defined separately.
3. There is NO reason to exclude ANY color setting from availability in any mode or in GUI configuration. On the contrary, separate settings for active/inactive cursor in bothe modes are needed for completeness.
Andrzej P. Wozniak
Polish subforum moderator
polle452
Junior Member
Junior Member
Posts: 32
Joined: 2013-10-09, 20:40 UTC

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *polle452 »

It looks like InactiveFocus only works if placed in the [Configuration] section of wincmd.ini.
Moving InactiveFocus inside the [Colors]&[ColorsDark] sections should take care of the InactiveFocus color in normal vs dark mode.
Hopefully this would also work if one uses the RedirectSection=%COMMANDER_INI%-%PROCESSOR_ARCHITECTURE% allows for color selection(s) based upon CPU type.
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *Usher »

2polle452
Do read carefully, please. It's a FEATURE REQUEST here. We know that currently we have InactiveFocus in [Configuration] section, but we don't like such a common option. Redirection won't help, it will stay a stranger in the night.
We want to have separate options InactiveFocusColor in [Colors] section and InactiveFocusColorDark in [ColorsDark] section.
Andrzej P. Wozniak
Polish subforum moderator
polle452
Junior Member
Junior Member
Posts: 32
Joined: 2013-10-09, 20:40 UTC

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *polle452 »

2Usher
I think my 2nd line above, states about the same - short some specific names.
I'm not particularly fond of Dark Mode; but I use separate background and other colors based upon x86/64 version of TC. This is my reason to mention the Redirect.
All in all, I believe we are on the same page.
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *Usher »

2polle452
I see. I proposed names which should be easy understood and follow the rules for names used in [Colors*] sections.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *MVV »

I agree that InactiveFocus should be added to [Colors] section, so similar option would appear in [ColorsDark] section. Old one in [Configuration] section may be left for compatibility and used if new one is not set.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *MVV »

There is also SelectionFocus key that should be moved to [Colors] and [ColorsDark] sections.
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *Usher »

Finally implemented in TC 10.50:
HISTORY.TXT wrote: 18.05.22 Release Total Commander 10.50 beta 6
(...)
12.05.22 Fixed: wincmd.ini [Configuration], the two new values SelectionFocusDark and InactiveFocusDark didn't use the values of SelectionFocus and InactiveFocus as the default (32/64)

11.05.22 Release Total Commander 10.50 beta 5
(...)
09.05.22 Added: wincmd.ini [Configuration], two new values SelectionFocusDark and InactiveFocusDark: As SelectionFocus and InactiveFocus, but for dark mode. Use the value from normal mode when not set (32/64)
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *ghisler(Author) »

I didn't move them to [Colors] / [ColorsDark] sections because they are more than just a color, they are an on/off switch for the option.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Feature request: make the color of the cursor of the inactive panel setable

Post by *Usher »

For me it's OK now, though I would add some explanation in Help for [Colors] and [ColorsDark] section.
Andrzej P. Wozniak
Polish subforum moderator
Post Reply