Same problem hereOvg wrote: ↑2020-01-07, 07:49 UTC There isn't property wcpatcher in dropdown list ...
https://yadi.sk/i/v4ZsvAINXubATw
[WCP] Accelerator for archives browsing
Moderators: white, Hacker, petermad, Stefan2
Re: [WCP] Accelerator for archives browsing
Windows 11 Home x64 Version 23H2 (OS Build 22631.3593)
TC 11.03 x64 / x86
Everything 1.5.0.1376a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.78
QAP 11.6.3.3 x64
TC 11.03 x64 / x86
Everything 1.5.0.1376a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.78
QAP 11.6.3.3 x64
Re: [WCP] Accelerator for archives browsing
Field "Property" may be empty: Image: https://i.imgur.com/F2W0WaL.jpgOvg wrote: ↑2020-01-07, 07:49 UTC There isn't property wcpatcher in dropdown list ...
https://yadi.sk/i/v4ZsvAINXubATw
-
- Junior Member
- Posts: 84
- Joined: 2006-11-07, 16:36 UTC
- Location: Trieste, Italy
- Contact:
Re: [WCP] Accelerator for archives browsing
I guess you are not using a supported TC version?Ovg wrote: ↑2020-01-07, 07:49 UTC There isn't property wcpatcher in dropdown list ...
https://yadi.sk/i/v4ZsvAINXubATw
Re: [WCP] Accelerator for archives browsing
You are wrong, I use TC 9.50 β11 (as stated in my signature) with plugin v 0.6
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 11.01 x64, Windows 7 SP1 x64
#259941, TC 11.01 x64, Windows 7 SP1 x64
Re: [WCP] Accelerator for archives browsing
I also use TC 9.50 β11 as one can see in my signature.
The property if definitely empty.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3593)
TC 11.03 x64 / x86
Everything 1.5.0.1376a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.78
QAP 11.6.3.3 x64
TC 11.03 x64 / x86
Everything 1.5.0.1376a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.78
QAP 11.6.3.3 x64
-
- Junior Member
- Posts: 84
- Joined: 2006-11-07, 16:36 UTC
- Location: Trieste, Italy
- Contact:
Re: [WCP] Accelerator for archives browsing
Yes I had a try installing and configuring as Admin, putting it as the first content plugin, nothing works in 9.50B11 x64 and 32 bit
Last edited by mikedepetris on 2020-01-08, 07:47 UTC, edited 2 times in total.
Re: [WCP] Accelerator for archives browsing
For viewing log use DbgView++mikedepetris wrote: ↑2020-01-07, 20:47 UTC Yes I had a try installing and configuring as Admin, putting iot as the first contect plugin, nothing works in 9.50B11 x64 and 32 bit
Also may try increase log level via INI-file.
- ghisler(Author)
- Site Admin
- Posts: 48162
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Re: [WCP] Accelerator for archives browsing
I don't recommend that you use this plugin for general use: While the plugin speeds up the opening of the archive, the list of all files created by TC is also needed in other places, e.g. when unpacking entire subdirectories. I have optimized the reading of the linear list in beta 12, so it should be considerably faster (although not as fast as this plugin, this would require a lot of internal changes).
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
Re: [WCP] Accelerator for archives browsing
WCP-plugin does not change the list of all files created by TC.ghisler(Author) wrote: ↑2020-01-08, 11:39 UTC ... the list of all files created by TC is also needed in other places, e.g. when unpacking entire subdirectories.
The plugin only replaces this list for a short time, when a list of elements is formed for display on the panel.
This replacement has no effect on the unpacking process!
Even the process of adding and removing is not affected, but the visual glitches are stunning.
Re: [WCP] Accelerator for archives browsing
Test results for TotalCmd 9.50b12 32-bit (test conditions are the same):ghisler(Author) wrote: ↑2020-01-08, 11:39 UTC I have optimized the reading of the linear list in beta 12, so it should be considerably faster (although not as fast as this plugin, this would require a lot of internal changes).
Code: Select all
Old algo | New algo | WCP-plugin | items | comment/directory
------------|-------------|-------------|--------|--------------------------
46527.07 ms | 18235.67 ms | 3958.95 ms | 506900 | file collection building
4615.79 ms | 298.40 ms | 0.17 ms | 1 | [root dir]
4830.28 ms | 40.43 ms | 3.11 ms | 130 | [AP\kernel\kernel]
5653.89 ms | 321.66 ms | 4.66 ms | 188 | [AP\external]
But you can increase the speed by another 30% by using the StrCmpIW function!
Re: [WCP] Accelerator for archives browsing
Addon for imgcfg.ini for support 9.50b12a
; TotalCmd 9.50b12a 32-bit
[2020-01-10]
g_WcxItemList=0x7C1D50
WcxProcessor=0x694E3C
WcxProcessor_loop_end=0x69678E
TcCreateFileInfo_dd=0x695F78
tc_wcsicmp=0x780A04
; TotalCmd 9.50b12a 64-bit
[2020-01-10-x64]
g_WcxItemList=0xC79490
WcxProcessor=0x527260
WcxProcessor_loop_end=0x5297E2
TcCreateFileInfo_dd=0x528BC7
tc_wcsicmp=0x41F9C0
[2020-01-10]
g_WcxItemList=0x7C1D50
WcxProcessor=0x694E3C
WcxProcessor_loop_end=0x69678E
TcCreateFileInfo_dd=0x695F78
tc_wcsicmp=0x780A04
; TotalCmd 9.50b12a 64-bit
[2020-01-10-x64]
g_WcxItemList=0xC79490
WcxProcessor=0x527260
WcxProcessor_loop_end=0x5297E2
TcCreateFileInfo_dd=0x528BC7
tc_wcsicmp=0x41F9C0
- ghisler(Author)
- Site Admin
- Posts: 48162
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Re: [WCP] Accelerator for archives browsing
2remittor
Thanks for the tests with beta 12!
I'm reluctant to use StrCmpIW because I don't know what it does internally. For example, it might return "identical" for some strings, e.g. one user had the problem that StrCmpLogicalW returns identical for strings starting with a dash and string without, e.g. "-test.txt" and "test.txt".
I tried to implement a tree for just the directories, but it was very slow. How do you store directories within a directory? Do you use a balanced tree for that too? I only tried with a linear list.
Thanks for the tests with beta 12!
I'm reluctant to use StrCmpIW because I don't know what it does internally. For example, it might return "identical" for some strings, e.g. one user had the problem that StrCmpLogicalW returns identical for strings starting with a dash and string without, e.g. "-test.txt" and "test.txt".
I tried to implement a tree for just the directories, but it was very slow. How do you store directories within a directory? Do you use a balanced tree for that too? I only tried with a linear list.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
Re: [WCP] Accelerator for archives browsing
Function StrCmpIW logically performs the same as your function tc_wcsicmp.ghisler(Author) wrote: ↑2020-01-13, 10:44 UTC I'm reluctant to use StrCmpIW because I don't know what it does internally.
shlwapi.dll@StrCmpIW from disasm
Code: Select all
int __stdcall StrCmpIW(LPCWSTR psz1, LPCWSTR psz2)
{
return CompareStringW(GetThreadLocale(), NORM_IGNORECASE, psz1, -1, psz2, -1) - CSTR_EQUAL;
}
StrCmpIW from ReactOS
Code: Select all
int __stdcall StrCmpIW(LPCWSTR psz1, LPCWSTR psz2)
{
return wine_compare_string(NORM_IGNORECASE, psz1, strlenW(psz1), psz2, strlenW(psz2));
}
Function StrCmpLogicalW works differently: https://docs.microsoft.com/en-us/windows/win32/api/shlwapi/nf-shlwapi-strcmplogicalwghisler(Author) wrote: ↑2020-01-13, 10:44 UTC For example, it might return "identical" for some strings, e.g. one user had the problem that StrCmpLogicalW returns identical for strings starting with a dash and string without, e.g. "-test.txt" and "test.txt".
See: https://www.ghisler.ch/board/viewtopic.php?f=14&t=54681&p=367899#p367899ghisler(Author) wrote: ↑2020-01-13, 10:44 UTC I tried to implement a tree for just the directories, but it was very slow. How do you store directories within a directory?
See methods: find_directory, get_next.
I am currently working on porting this code to the PAXZ-plugin. And it became clear that need to implement a recursive version of the function get_next, so that can get a complete list of all the elements.
TREE-like structures for PAXZ wcx-plugin
Balanced trees are not needed at all.ghisler(Author) wrote: ↑2020-01-13, 10:44 UTC Do you use a balanced tree for that too? I only tried with a linear list.
And without this, the search is very fast, because the hash of the name is used: https://github.com/remittor/wcpatcher/blob/935fe73c025ec03497c9fc51ad165b10d92102c6/src/wcp_filetree.cpp#L121-L154
Last edited by remittor on 2020-01-16, 14:15 UTC, edited 4 times in total.
Re: [WCP] Accelerator for archives browsing
2ghisler
Today I added unnecessary functions to WCP-plugin. But they will be needed in the WCX-plugins (PAXZ).
get_path: Constructs the full path to the specified element. To do this, build the entire branch, starting from the root.
get_next: Enumeration of all elements starting from the specified dir (in this case, it is possible to limit the depth). class TTreeEnum
Today I added unnecessary functions to WCP-plugin. But they will be needed in the WCX-plugins (PAXZ).
get_path: Constructs the full path to the specified element. To do this, build the entire branch, starting from the root.
get_next: Enumeration of all elements starting from the specified dir (in this case, it is possible to limit the depth). class TTreeEnum
Re: [WCP] Accelerator for archives browsing
impressive! what WCP stand for, by the way, never heard of it before.