Lister: the problem of colors in the media bar

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, Stefan2, white

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

Indeed I must have misunderstood you. What do you mean with "sane"?
Author of Total Commander
https://www.ghisler.com
Fla$her
Senior Member
Senior Member
Posts: 348
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

ghisler(Author) wrote: 2022-05-12, 15:13 UTCWhat do you mean with "sane"?
Adequate. Correct and proportional from the point of view of interface formation.
So that the centers of the buttons are on the central axis of the volume bar. I.e. +3 pixels up. And on the left +4 pixels.
And + 2-3 pixels above progress playbar.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

Unfortunately there is no way to align the play bar/volume bar with buttons, because its look depends on the current Windows theme. Windows does not tell programs where the bar has its base line. I can add arbitrary borders, but I don't really know what to use here.
Author of Total Commander
https://www.ghisler.com
Fla$her
Senior Member
Senior Member
Posts: 348
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

ghisler(Author) wrote: 2022-05-13, 10:02 UTCI can add arbitrary borders, but I don't really know what to use here.
Well, let them be arbitrary. And which ones, I suggested above in pixels.
Fla$her
Senior Member
Senior Member
Posts: 348
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

add arbitrary borders
Not yet.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

I will use a border of 3*current_dpi/72 in the next beta.
Author of Total Commander
https://www.ghisler.com
Fla$her
Senior Member
Senior Member
Posts: 348
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

ОК. Thanks. Indent (margin) only. And above progress playbar too?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

Yes, also between all elements, vertically and horizontally.
Please try it when the next beta comes out and check whether I missed anything.
Author of Total Commander
https://www.ghisler.com
Fla$her
Senior Member
Senior Member
Posts: 348
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

I checked. It's clearly gotten better. Still, no indentation was added above progress playbar. And the margin on the left is shorter than the margin on the bottom. Therefore, I suggested above that on the left +4, because there was already an indent of 1 pixel from the bottom. Please correct it.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

Strange, I use the same values for top, left and the button distances.
Here are the dimensions I use:
DShowPlayerDelta is 3 on a 96 DPI screen.
DShowPlayerHeight is the height of a single button (not of the entire panel).
rect is the rectangle of the panel.
PlayTrackbar is the top progress bar.
Afterwards come the buttons.

I think the names are rather self-explanatory:

Code: Select all

  PlayTrackbar.left:=DShowPlayerDelta;
  PlayTrackbar.top:=DShowPlayerDelta;
  PlayTrackbar.width:=max(0,rect.right-rect.left-2*DShowPlayerDelta);
  PlayTrackbar.height:=PlayPauseButton.height-2;

  PlayPauseButton.top:=DShowPlayerHeight+DShowPlayerDelta;
  PlayPauseButton.left:=DShowPlayerDelta;
  SlowerButton.top:=DShowPlayerHeight+DShowPlayerDelta;
  SlowerButton.left:=PlayPauseButton.left+PlayPauseButton.width+DShowPlayerDelta;
  RateButton.top:=DShowPlayerHeight+DShowPlayerDelta;
  RateButton.left:=SlowerButton.left+SlowerButton.width+DShowPlayerDelta;
  FasterButton.top:=DShowPlayerHeight+DShowPlayerDelta;
  FasterButton.left:=RateButton.left+RateButton.width+DShowPlayerDelta;
  SingleStepButton.top:=DShowPlayerHeight+DShowPlayerDelta;
  SingleStepButton.left:=FasterButton.left+FasterButton.width+DShowPlayerDelta;
  JumpButton[0].top:=DShowPlayerHeight+DShowPlayerDelta;
  JumpButton[0].left:=SingleStepButton.left+SingleStepButton.width+DShowPlayerDelta;
  for i:=1 to 3 do begin
    JumpButton[i].top:=DShowPlayerHeight+DShowPlayerDelta;
    JumpButton[i].left:=JumpButton[i-1].left+JumpButton[i-1].width+DShowPlayerDelta;
  end;
  VolumeTrackbar.width:=5*DShowPlayerHeight;
  VolumeTrackbar.height:=DShowPlayerHeight-2;
  VolumeTrackbar.left:=rect.right-rect.left-VolumeTrackbar.width-labelstartpos;
  VolumeTrackbar.Top:=DShowPlayerHeight+DShowPlayerDelta;
  MuteButton.left:=VolumeTrackbar.left-MuteButton.width-DShowPlayerDelta;
  MuteButton.top:=DShowPlayerHeight+DShowPlayerDelta;
  AlbumArtButton.left:=MuteButton.left-AlbumArtButton.width-DShowPlayerDelta;
  AlbumArtButton.top:=DShowPlayerHeight+DShowPlayerDelta;
Author of Total Commander
https://www.ghisler.com
Fla$her
Senior Member
Senior Member
Posts: 348
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

2ghisler(Author)
Please look at the screenshot with the disproportions.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

Sorry, I don't know what I should change. As you can see in my code, I'm using the same distances everywhere.
Author of Total Commander
https://www.ghisler.com
Fla$her
Senior Member
Senior Member
Posts: 348
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

ghisler(Author) wrote: 2022-05-25, 16:56 UTCDShowPlayerDelta is 3 on a 96 DPI screen.
I use 120 DPI. Maybe that's the problem?
Can you set PlayPauseButton.left:=DShowPlayerDelta+2; ?
Notice also the 7 and 11 px. In these places it's better to equalize the distance.
And why is the slider itself narrowed? Before that, it was wider, it was easier to get into it with the mouse.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

I use 120 DPI. Maybe that's the problem?
As described above, the calculation is 3*dpi/72, so for 120 this would result in DShowPlayerDelta=5.
It's still the same value in all locations.
Author of Total Commander
https://www.ghisler.com
Fla$her
Senior Member
Senior Member
Posts: 348
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

ghisler(Author) wrote: 2022-05-29, 08:51 UTCIt's still the same value in all locations.
Good. Can you adjust what I pointed out?
Post Reply