Copy folder, skip existing files: size is not updated, slow copy

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, Stefan2, white

Post Reply
nice
Junior Member
Junior Member
Posts: 21
Joined: 2018-03-12, 23:58 UTC

Copy folder, skip existing files: size is not updated, slow copy

Post by *nice »

Copy folder, skip existing files:
1. size is not updated
- if it shows only copied files then the ratio copied/total as well as lower progress bar is incorrect
- file names is not synchronous with files count (when the file names changes, file count is not changed)
- when the files are "copied" (1) (skipping existing files) (without counting count/size), after that the new (non-existing in the target folder) files are copied (2), and after that the same (already existing files) are "copied" (skipped) second time with counting of size (3)
- at the stage (1), Cancel doesn't show a confirmation dialog
- on the normal copy, Cancel alternately shows the old dialog with the red cross (Interrupted by user), with two buttons, and new dialog with three buttons, with different sounds
2. slow copy
- when another file manager skips 1000's of existing files per second, total commander skips 10's files per second
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43131
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Copy folder, skip existing files: size is not updated, slow copy

Post by *ghisler(Author) »

1. Sorry, I don't understand what you mean
2. I cannot reproduce that. Maybe a virus scanner problem?
Author of Total Commander
https://www.ghisler.com
nice
Junior Member
Junior Member
Posts: 21
Joined: 2018-03-12, 23:58 UTC

Re: Copy folder, skip existing files: size is not updated, slow copy

Post by *nice »

why?
* copy folder with 10000's of files
* stop in the half
* copy in same location, skip existing files
* files in "from:/to:" changed, file count and size is not updated
* sometimes file count is updated, size is not updated
https://www.youtube.com/watch?v=gXwpwalHeDQ
* pressing Cancel does not give confirmation on this step

why the other file manager is not affected by antivirus?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43131
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Copy folder, skip existing files: size is not updated, slow copy

Post by *ghisler(Author) »

Total Commander tries to skip all files where there is a collision and only ask the user at the end.
why the other file manager is not affected by antivirus?
When you copy executable files like EXE/DLL, and use the option to only copy newer (skip older), then TC compares the version info of the file and not just the time stamp. This takes longer because each file needs to be opened to read the version info. When I copy e.g. JPG files, I can skip 10'000 files in a fraction of a second (just tested).
Author of Total Commander
https://www.ghisler.com
nice
Junior Member
Junior Member
Posts: 21
Joined: 2018-03-12, 23:58 UTC

Re: Copy folder, skip existing files: size is not updated, slow copy

Post by *nice »

It scans all files, not just exe, and with "skip all" option (not "skip older")

put several files in folder
the 1,2 are safe, the 3 is malicious exe
rename exe to zip
copy all files to second folder so that both folders are identical
turn antivirus on
select copy from first folder to second
it asks you to skip on first (safe) file
select "skip all"
on third (malicious) file will be antivirus warning
so it tried to open it instead of skip

Fast skipping is because of the cache
It is necessary to clear the cache

Folder without exe, dll (70k files, 9k folders) skips with 2:28; with double commander it's 35 sec (antivirus is enabled)

The progress bar is not updated at all

I never noticed that it is asking at the end. Rather, at the beginning.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43131
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Copy folder, skip existing files: size is not updated, slow copy

Post by *ghisler(Author) »

I never noticed that it is asking at the end. Rather, at the beginning.
It depends on whether there is a collision within the first 10 seconds or not. If not, TC assumes that the user may no longer be there and delays the questions to the end.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43131
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Copy folder, skip existing files: size is not updated, slow copy

Post by *ghisler(Author) »

Moderator message

Moved to "will not be changed"
Author of Total Commander
https://www.ghisler.com
nice
Junior Member
Junior Member
Posts: 21
Joined: 2018-03-12, 23:58 UTC

Re: Copy folder, skip existing files: size is not updated, slow copy

Post by *nice »

why? have you checked my tests? with opening Every file, even if skip all?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 43131
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Copy folder, skip existing files: size is not updated, slow copy

Post by *ghisler(Author) »

Sorry, I cannot fix something I can't reproduce.
Author of Total Commander
https://www.ghisler.com
Post Reply