Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Post by *Usher »

1. Run TC with clean ini, go to Options -> Operation and turn ON "Select only the filename when renaming". Click OK and start tests.
2. Create directory test with the following structure inside:

Code: Select all

test
|   EMPTY
|   EMPTY.TXT
|   EMPTY.TXT.bak
|   
+---0dot
|       0EMPTY
|       0EMPTY.TXT
|       0EMPTY.TXT.bak
|       
+---1.dot
|       1EMPTY
|       1EMPTY.TXT
|       1EMPTY.TXT.bak
|       
\---2.dot.s
        2EMPTY
        2EMPTY.TXT
        2EMPTY.TXT.bak
Observe that there are files and directories wth no dot in name, file and directories with one dot in name and with 2 dots in name.
3. Stay in test directory and press Ctrl+B to get flat view. Now stand on any file an press Shift+F6 for inplace rename. As you can see, only the filename without part after the last dot is selected. It's OK so far.
4. Now move up and down and you should see that all goes wrong: file without extension is unselected, files in subdirectories are selected with the full path and extension... Note that results may be different depending on the file you have started navigation up-down.

5. Press Ctrl+B again to finish flat view, go back to test directory and now use Alt+F7 without any parameters. Just press Alt+F7, then click "Feed to listbox" button.
6. Repeat actions described in p.3,4 and observe different behaviour wnen navigating up and down after pressing Shift+F6.

This behaviour seems to be present in TC from the very beginning of navigating up-down (in TC9 alpha?):
history.ini wrote:08.04.15 Added: Shift+F6 inplace rename: Press up or down arrow to rename and switch to previous/next file (32/64)
Andrzej P. Wozniak
Polish subforum moderator
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Post by *Usher »

HISTORY.TXT wrote:17.06.22 Fixed: When using the option "Select only the file name when renaming", the wrong part of the name would get selected in branch view or search results on cursor up/down (32/64)
One case is NOT fixed yet.
Press Ctrl+B, go to 0EMPTY file and use Shift+F6. In this case the whole line 0dot\0EMPTY is selected instead of 0dot\0EMPTY only. You have to navigate down and back to get the proper selection.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Post by *ghisler(Author) »

Strange, it works with my current wincmd.ini but not with a fresh ini when I just enable the option "Select only names"...
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Post by *Usher »

The problem is visible only when you start renaming from the file without extension located in subdirectory without extension. You can change sort order to get the file 0dot\0EMPTY first.
And there's one more strange thing. After pressing Ctrl+B and Shift+F6 the status bar stops on the selected file and isn't refreshed during navigation before you finish editing. But when you turn on Quick View, the status bar is always refreshed during navigation with Shift+F6. With normal view (without Ctrl+B) the status bar isn't refreshed even for Quick View turned on.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Post by *ghisler(Author) »

the status bar stops on the selected file and isn't refreshed
I can reproduce it too.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Post by *ghisler(Author) »

This should be fixed in RC4, please test it!
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Post by *petermad »

history.txt wrote:28.06.22 Fixed: Rename with Shift+F6, go to next/previous file with cursor keys: Footer wasn't updated, e.g. in brief view or branch view (32/64)
24.06.22 Fixed: When using the option "Select only the file name when renaming", the whole relative path+name was selected when they didn't contain any dots (32/64)

I can confirm both bugs in TC 10.50rc3 and that they are fixed in TC 10.50rc4 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Post by *Usher »

Confirmed fixed!
Andrzej P. Wozniak
Polish subforum moderator
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Select only the filename when renaming - wrong behaviour in flat view (Ctrl+B)

Post by *white »

Moderator message from: white » 2022-06-30, 22:55 UTC

Moved to Fixed bugs.
Post Reply