Solved [TC 10.50] Missing parameter for cm_commands in Help

[petermad]

21.09.16 Added: For the sorting commands like CM_SRCBYNAME, add parameter 4 to sort by additional columns, e.g. CM_SRCBYSIZE 5 adds sort by size, ascending (32/64)

This feature is not mentioned in the Help file (dlg_choosecommand.htm)

[white]

Moreover, -1 seems to do the same as 6. And 1 and 2 are not described accurately. (1=sort ascending, 2=sort descending)

CM_*BYNAME, CM_*BYEXT, CM_*BYSIZE, CM_*BYDATETIME, CM_*NEGORDER
0 or no parameter=toggle, 1=set, -1 or 2=reset
8: Store current sort order, sort direction and additional sort columns internally
9: Restore all sort order parameters stored with option 8

[petermad]

2white

-1 seems to do the same as 6

Confirmed - there is a bug there - it goes all the way back to TC 9.0 beta 15 where the feature was intruduced.

[white]

2petermad

20.09.16 Added: The following internal commands now accept parameters 0 (toggle, default), 1 (true), and 2 (false), except in main menu (* stands for LEFT, RIGHT, and SRC): CM_VERTICALPANELS,CM_*THUMBS,CM_*BYNAME,CM_*BYEXT,CM_*BYSIZE,CM_*BYDATETIME,CM_*NEGORDER (32/64)

I think parameter -1 was not added and the current behavior is a side effect and the bug is that the help says -1 is supported.

[petermad]

2white
I meant the feature of adding 4 - mentioned in my first post - was intruduced.

[petermad]

Confirmed that:

4: When added, sort by additional columns, e.g. CM_SRCBYSIZE 5 adds sort by size, ascending

Is added to the Help in TC 10.51 rc1

BUT - the bug that CM_SRCBYSIZE -1 and CM_SRCBYSIZE 6 has the same effect still persists. CM_SRCBYSIZE -1 should have the same effct as CM_SRCBYSIZE 2 - according to the old Help (TC 10.50)

On the other hand -1 is no longer mentioned as a parameter for the CM_*BY* parameters in the Help for TC 10.51 - and -1 was never mentioned in history.txt for the CM_*BY* parameters.

But since -1 is still accepted as a parameter - i think it should do the same as 2 - to match parameters for commands like CM_*COMMENTS
CM_DIRBRANCH and CM_LEFTDIRBRANCH

And maybe using undocumented parameters like 3 (works as 0), and 7 (works like 6 and -1) and -2 (works as 6) - should result in an error message - or should all work as 0...

[ghisler(Author)]

On the other hand -1 is no longer mentioned as a parameter for the CM_*BY* parameters in the Help

Exactly. -1 interferes with the possibility to add values like 4 to the total parameter. Therefore it's no longer mentioned. What happens when you pass it to the command is not defined.

[white]

Help erroneously states that parameters 4,5,6 are supported for CM_*NEGORDER and that 1=ascending and 2=descending for these commands as well.

CM_*NEGORDER should be described separately:

0 or no parameter=toggle, 1=set, -1 or 2=reset.
8: Store current sort order, sort direction and additional sort columns internally
9: Restore all sort order parameters stored with option 8

[ghisler(Author)]

I agree.

[petermad]

2ghisler(Author)

What happens when you pass it to the command is not defined.

-1 works like 6
3 works like 0
7 works like -1 and 6
-2 works like 6

[petermad]

Help confirmed fixed in TC 10.51rc2:

CM_*BYNAME, CM_*BYEXT, CM_*BYSIZE, CM_*BYDATETIME
0 or no parameter=toggle, 1=ascending, 2=descending
4: When added, sort by additional columns, e.g. CM_SRCBYSIZE 5 adds sort by size, ascending
8: Store current sort order, sort direction and additional sort columns internally
9: Restore all sort order parameters stored with option 8

CM_*NEGORDER 0 or no parameter=toggle, 1=set, -1 or 2=reset
8: Store current sort order, sort direction and additional sort columns internally
9: Restore all sort order parameters stored with option 8

16.08.22 Fixed: Ignore commands CM_*BYNAME, CM*BYSIZE etc. when the parameter passed to it is negative (32/64)

Confirmed fixed in TC 10.51rc2

[white]

Confirmed fixed in TC 10.51rc2

Confirmed.

Moderator message from: white » 2022-08-17, 15:40 UTC

Moved to Fixed bugs.