TC 10.50 - Dark mode for delete temporary file dialog

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
iteg
Junior Member
Junior Member
Posts: 62
Joined: 2016-07-28, 08:36 UTC

TC 10.50 - Dark mode for delete temporary file dialog

Post by *iteg »

There is no "Dark mode" implementation for the delete temporary file dialog.
The dialog can be called when opening a file for editing from an archive (F4).

Example: https://ibb.co/kD2gp39
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 10.50 - Dark mode for delete temporary file dialog

Post by *ghisler(Author) »

That's odd, it's a regular Delphi dialog so it should work in dark mode. I will check it.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 10.50 - Dark mode for delete temporary file dialog

Post by *ghisler(Author) »

This should be fixed in TC 10.51 RC1, please test it.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: TC 10.50 - Dark mode for delete temporary file dialog

Post by *white »

Tested using TC10.51rc1 32bit and 64bit and Notepad++.

I opened Notepad++ and then tried to edit a file in a .zip file.

The delete temp file dialog is now in dark mode. However the buttons are initially in normal mode. When the Notepad++ window is not over the dialog the buttons are white. When the Notepad++ window is over the dialog and I press Alt+Tab, the dark dialog is shown but doesn't have focus and the buttons are white. If I close Notepad++ or click the dialog the buttons become dark.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 10.50 - Dark mode for delete temporary file dialog

Post by *ghisler(Author) »

However the buttons are initially in normal mode.
NOT confirmed. Which Windows version do you use? Does it happen with a fresh wincmd.ini just with dark mode enabled?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: TC 10.50 - Dark mode for delete temporary file dialog

Post by *white »

Windows 11 Pro, build 22000.856
fresh ini with dark mode enabled and editor set to: "C:\Program Files\Notepad++\notepad++.exe" "%1"
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 10.50 - Dark mode for delete temporary file dialog

Post by *ghisler(Author) »

I see now - here the editor was covering the Total Commander window, so when I closed it or returned to TC, the buttons were drawn correctly. It does happen when I move the editor out of the way after opening the first file, so I can see the dialog immediately when seing the second. The reason is that the buttons get subclassed when the dialog gets the focus, which doesn't happen in this case until you return to TC.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: TC 10.50 - Dark mode for delete temporary file dialog

Post by *white »

Tested OK using TC10.51rc2 32bit and 64bit.

Moderator message from: white » 2022-08-17, 16:08 UTC

Moved to Fixed bugs.
iteg
Junior Member
Junior Member
Posts: 62
Joined: 2016-07-28, 08:36 UTC

Re: TC 10.50 - Dark mode for delete temporary file dialog

Post by *iteg »

Fixed.
Post Reply