[tc10.51rc2] ZipFromList, zip file in Command and later in Parameters field

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4618
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[tc10.51rc2] ZipFromList, zip file in Command and later in Parameters field

Post by *white »

I have noticed strange behavior when environment variables (existing or not) have been used in combination with ZipFromList.

It's hard to reproduce consistently, but I may have found a way to consistently reproduce it.

Preparations:
  • Create a new folder with 1 small file named "test.txt".
  • Create the following 2 butttons:

    Code: Select all

    TOTALCMD#BAR#DATA
    zipfromlist
    "test.zip" %UF
    wcmicons.dll,60
    Button1: Create test.zip
    
    
    -1
    

    Code: Select all

    TOTALCMD#BAR#DATA
    zipfromlist "%test%.zip"
    %UF
    wcmicons.dll,60
    Button 2: Create %test%.zip
    
    
    -1
    
Testing:
  • Select the file "test.txt"
  • Click Button 1
  • Delete "test.zip"
  • Select the file "test.txt" again (might be already selected)
  • Click Button 2
  • Delete "%test%.zip"
  • Select the file "test.txt" again (might be already selected)
  • Click Button 1 again
  • Error "File not found!" is displayed.
Last edited by white on 2022-08-24, 08:52 UTC, edited 1 time in total.
Reason: Changed subject of the topic
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6481
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: [tc10.51rc2] ZipFromList and environment variables

Post by *Horst.Epp »

Confirmed.
Only after restarting TC I can use the Button 1 again.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3447)
TC 11.03 x64 / x86
Everything 1.5.0.1372a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.73
QAP 11.6.3.2 x64
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [tc10.51rc2] ZipFromList and environment variables

Post by *petermad »

I can confirm this, but only with a fresh ini file, not with my work ini file. I will try and find the culprit

EDIT:
I found the reason why I could not reproduce the bug with my work ini - it was due to these two settings in combination:

Code: Select all

[Searches]
Kommentar_SearchFor=
Kommentar_SearchIn=
Kommentar_SearchText=
Kommentar_SearchFlags=0|002002000020|||||||||0000|||
Kommentar_Plugin=tc.comment != ""

[Colors]
.
.
.
ColorFilter16=>Kommentar
ColorFilter16Color=40704
used for coloring files with comments.

Notice if I add a comment to one of the other files in the test directory, then I can also reproduce the bug even with the [Searches] and [Colors] settings shown above.

If I add a description to test.txt and I have the ini settings shown above it is simply impossible to use button 1 even after restart of TC.

If I use a frech ini file only with this added:

Code: Select all

[searches]
Comment_SearchFor=
Comment_SearchIn=c:\test3
Comment_SearchText=
Comment_SearchFlags=0|002002000020|||||||||0000|||
Comment_plugin=tc.comment != ""

[Colors]
ColorFilter1=>Comment
ColorFilter1Color=6472704
ColorFilter1ColorDark=13040018,6472704
then I don't even have to use button 2 to get the error message - I can just use button 1 two or more times.
Last edited by petermad on 2022-08-23, 18:15 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: [tc10.51rc2] ZipFromList and environment variables

Post by *funkymonk »

I can also confirm white's observation with a fresh and with my regular ini.

As Horst.Epp wrote, Button 1 works again after a restart. Sometimes(!) it is sufficient to leave and re-enter the directory to make Button 1 work again...

Even more strange: I get one out of two different error messages when pressing Button 1 -- though I cannot tell which one appears under which circumstances:

https://ibb.co/kHh52L2

https://ibb.co/BwGzyDy
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [tc10.51rc2] ZipFromList and environment variables

Post by *ghisler(Author) »

The problem isn't the % sign here, it's that you pass the zip file via parameter field in button 1, and appended to the command in button 2. I will fix it.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4618
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [tc10.51rc2] ZipFromList and environment variables

Post by *white »

ghisler(Author) wrote: 2022-08-24, 08:08 UTC The problem isn't the % sign here, it's that you pass the zip file via parameter field in button 1, and appended to the command in button 2.
Confirmed. I changed the subject of the topic accordingly.
User avatar
white
Power Member
Power Member
Posts: 4618
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [tc10.51rc2] ZipFromList, zip file in Command and later in Parameters field

Post by *white »

Tested OK using TC10.52rc3 32bit and 64bit.

Moderator message from: white » 2022-08-24, 13:42 UTC

Moved to Fixed bugs.
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [tc10.51rc2] ZipFromList, zip file in Command and later in Parameters field

Post by *petermad »

history.txt wrote:24.08.22 Fixed: The ZIPFROMLIST command could fail when called once with the zip name in the parameters field and once with the zip name in the command field (32/64)
Confirmed fixed in TC 10.51rc3 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply