[TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
Dalai
Power Member
Power Member
Posts: 9364
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *Dalai »

As hi5 quoted from the history.txt this was intentionally changed. One argument for this change is that TC doesn't execute all selected EXE files when pressing Enter, so it shouldn't react to all selected checksum files either. Previously if other files were selected in addition to checksum files and pressing Enter on one of the latter, TC just showed the message "Please select only SFV, MD5 or SHA files", which is not helpful either.

Use the menu Files > Verify Checksums to verify multiple checksum files.

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
Gral
Power Member
Power Member
Posts: 1460
Joined: 2005-01-26, 15:12 UTC

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *Gral »

Dalai wrote: 2023-05-23, 20:32 UTC Use the menu Files > Verify Checksums to verify multiple checksum files.
Right. Or assign keyboard shortcut to cm_CRCCheck or command for the appropriate extensions to Internal Association.
User avatar
Hacker
Moderator
Moderator
Posts: 13052
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *Hacker »

Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *ghisler(Author) »

For beta 4 I have now implemented the suggestion by user MCorey here:
https://www.ghisler.ch/board/viewtopic.php?p=424109#p424109

In short, when the double clicked checksum file is selected too, then all selected checksum files will be checked, otherwise just the double clicked one.
Author of Total Commander
https://www.ghisler.com
cpp64
Junior Member
Junior Member
Posts: 83
Joined: 2023-05-12, 16:03 UTC

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *cpp64 »

hi5 wrote: 2023-05-23, 19:21 UTC Perhaps

Release Total Commander 10.52 release candidate 1 (RC1)
27.09.22 Fixed: Double click on checksum file (.md5, .sha1 etc) now checks only that file, not the currently selected files (which will be unchecked) (32/64)

https://www.ghisler.ch/board/viewtopic.php?t=77530


I found it.


In TC 10.51

The bug occurs when using [use right mouse button (as in NC) - context menu after 1 second], not using [Let mouse button (Windows standard)].

When using [Let mouse button (Windows standard)], the bug doesn't happen.

A mouse click cancels the selected files.

So the mouse double click doesn't generate the bug.


ghisler!

Can you restore the feature checking multiple checksum files at once with 'ENTER' when using [Let mouse button (Windows standard)].

I miss the 'ENTER' very much.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *ghisler(Author) »

2cpp64
Please read my reply above your post.
Author of Total Commander
https://www.ghisler.com
cpp64
Junior Member
Junior Member
Posts: 83
Joined: 2023-05-12, 16:03 UTC

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *cpp64 »

ghisler(Author) wrote: 2023-05-24, 09:40 UTC 2cpp64
Please read my reply above your post.
Yes, I have read your post.

Thank you for your hard work!


--------------------------------------------------------------------------------
ps.

When I was writing my post, I didn't see your post.

When I finished my post, four posts, including yours, were posted before mine.

When I read your post, my post was not in the right place.

# Blake3 file pop-up
https://www.ghisler.ch/board/viewtopic.php?t=77530

But I noticed that the link didn't mention "as in NC" and "Windows standard".

So instead of deleting it, I decided to keep it.


--------------------------------------------------------------------------------
ps2.

I understand this situation because my post came after yours.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *ghisler(Author) »

Can anyone test this change, please?
For beta 4 I have now implemented the suggestion by user MCorey here:
https://www.ghisler.ch/board/viewtopic.php?p=424109#p424109

In short, when the double clicked checksum file is selected too, then all selected checksum files will be checked, otherwise just the double clicked one.
Author of Total Commander
https://www.ghisler.com
cpp64
Junior Member
Junior Member
Posts: 83
Joined: 2023-05-12, 16:03 UTC

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *cpp64 »

2ghisler(Author)

-----
1.blake3
2.sha3
3.sha
4.sha256

1.txt
2.txt
3.txt
4.txt
-----

All *.txt are modified, so all checksum files are wrong.

The 'Bold' means 'selected'.

in the NC(Norton Commander) mouse mode:
MessageBox only appears when "3.sha or 4.sha256" is double-clicked when "3.sha, 4.sha256, 3.txt and 4.txt" are selected.
In all other possible cases, I couldn't see any MessageBox.

in the Windows Standard mouse mode:
Single 'left click' clears all selected files.
So I couldn't see any MessageBox in all possible cases.

in the Keyboard:
The keyboard worked the same as in NC mouse mode.

I think you've implemented it well.


------------------------------------------------------------
ps. About blake3 file pop-up.

# blake3 file pop-up
viewtopic.php?p=424109#p424109

The "Why the warning pop-up appears" is that the keyboard and mouse behave the same in NC Mouse mode.
left double click == keyboard enter,
single right click == keyboard sapce.
I am using the Windows Standard mouse mode.
before TC 10.52, when I saw the same warning pop-up when using the keyboard in the same situation,
I just pressed 'Control+NumpadMinus' or single-left-clicked anywhere.
In Windows Standard mouse mode, single 'left click' clears all selected files.
So, I didn't consider it a bug at all.

However, *TheOwner seems to be using NC mouse mode.
When he encoutnered the same situation, he may not have press 'Control+NumpadMinus'.
And because He is using NC mouse mode, the single left click is meaningless.
So he probably considered it a bug.
Last edited by cpp64 on 2023-05-27, 08:31 UTC, edited 20 times in total.
User avatar
Hacker
Moderator
Moderator
Posts: 13052
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *Hacker »

cpp64,
Wow :shock:
I am afraid this will take longer to decrypt than it took to write.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
cpp64
Junior Member
Junior Member
Posts: 83
Joined: 2023-05-12, 16:03 UTC

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *cpp64 »

2Hacker

All *.txt files are modified, so all the checksum files are wrong.

In NC mouse mode,

the MessageBox only appears when you select the Selected Checksum of [ 1 ] "selected checksum files + selected target files".

And the rest is fine.
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *AntonyD »

2cpp64
My suggestion = make a video. so - all could understand all what you wanted to show by this "test process".
This is certainly important - because it is written below that everything works as it should - as stated.
So your behavior should be something significantly different: to reflect this is best just a video fit!
Last edited by AntonyD on 2023-05-26, 18:43 UTC, edited 1 time in total.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *petermad »

history.txt wrote:24.05.23 Added: Double click on checksum file (.md5, .sha1 etc) now checks again all selected files if the double clicked checksum file was selected too (32/64)
It works as described for me in TC 11.00b4 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b3] Checking multiple checksum files at once with ENTER was removed

Post by *ghisler(Author) »

I think the complaint is that after verifying checksum files and some files are modified, those modified files will then be selected.
When you then select another checksum file and double click on it, you will get an error that only checksum files should be selected.
That was the main reason why I disabled checking all selected checksum files when double clicking.
But I still think that this is better now than just checking the double clicked file.
Author of Total Commander
https://www.ghisler.com
Post Reply