Consistency on CTRL shortcuts

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Eugensyl2
Junior Member
Junior Member
Posts: 43
Joined: 2023-05-20, 15:12 UTC

Consistency on CTRL shortcuts

Post by *Eugensyl2 »

Consistency on CTRL shortcuts definition:

- the new lists of tabs and/or dir history have definition of shortcuts menu item with "Control" instead of "Ctrl" as usual everywhere: menu, bars, language, etc.
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Consistency on CTRL shortcuts

Post by *petermad »

Support++++

Strings 2117, 2118, 2119 and 2126 should all have Control replaced with Ctrl to match all other menus.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Eugensyl2
Junior Member
Junior Member
Posts: 43
Joined: 2023-05-20, 15:12 UTC

Re: Consistency on CTRL shortcuts

Post by *Eugensyl2 »

petermad wrote: 2023-05-28, 12:58 UTC Support++++

Strings 2117, 2118, 2119 and 2126 should all have Control replaced with Ctrl to match all other menus.
Yes, the all you mentioned.
I think, it worth add
2124="List of all Tabs on active panel\tCtrl+Shift+A"
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Consistency on CTRL shortcuts

Post by *petermad »

2124="List of all Tabs on active panel\tCtrl+Shift+A"
String 2124 in the Internal English is:

Code: Select all

2124, "Show list of all tabs\tCtrl+Shift+A"
so that one is already OK. Notice it does not say " on active panel" - https://tcmd.madsenworld.dk/string2124.png
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Eugensyl2
Junior Member
Junior Member
Posts: 43
Joined: 2023-05-20, 15:12 UTC

Re: Consistency on CTRL shortcuts

Post by *Eugensyl2 »

petermad wrote: 2023-05-28, 15:59 UTC
2124="List of all Tabs on active panel\tCtrl+Shift+A"
String 2124 in the Internal English is:

Code: Select all

2124, "Show list of all tabs\tCtrl+Shift+A"
so that one is already OK. Notice it does not say " on active panel" - https://tcmd.madsenworld.dk/string2124.png
Ok.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Consistency on CTRL shortcuts

Post by *ghisler(Author) »

What about string 5282? It has been "Control +" for a long time...
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Consistency on CTRL shortcuts

Post by *petermad »

What about string 5282? It has been "Control +" for a long time...
I think it should be "Ctrl +" too - it has been like that in the Danish translations for a long time.

I checked the .lng files - out of 50 files 25 uses Control , 22 uses Ctrl, 2 uses Strg and 1 uses Vald - so it is fifty-fifty using an abbreviated variant.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Eugensyl2
Junior Member
Junior Member
Posts: 43
Joined: 2023-05-20, 15:12 UTC

Re: Consistency on CTRL shortcuts

Post by *Eugensyl2 »

ghisler(Author) wrote: 2023-05-29, 09:34 UTC What about string 5282? It has been "Control +" for a long time...
"Ctrl +" seem to be the right choice, IMHO.

If you keep "Control +" also you must change
5283="Alternate +"

Short is better because on most US keyboard the keys are named Ctrl and Alt.
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Consistency on CTRL shortcuts

Post by *petermad »

history.txt wrote:30.05.23 Fixed: Unified some hotkey names in English (Control->Ctrl) and German (Umsch->Umschalt) (32/64)
Confirmed fixed in TC 11.00b5 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply