beta4: ZIPFROMLIST "-0" is annoying

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Eugensyl2
Junior Member
Junior Member
Posts: 43
Joined: 2023-05-20, 15:12 UTC

beta4: ZIPFROMLIST "-0" is annoying

Post by *Eugensyl2 »

TC11beta3
ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list (supports parameters -m, -o, -c0-3 and 0-9)

TC11beta4
ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list (supports parameters -m, -o, -c0-3 and -0-9)

I think the minus before 0 is annoying.
Maybe -0 ... -9 is ok if (-)minus sign is for parameters.
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *petermad »

It corresponds to: -c0-3 = -c0...-c3

It was me who asked for the - before 0 - otherwise people might think they could just write 0 instead of -0 as parameter
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Eugensyl2
Junior Member
Junior Member
Posts: 43
Joined: 2023-05-20, 15:12 UTC

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *Eugensyl2 »

petermad wrote: 2023-05-26, 19:07 UTC It corresponds to: -c0-3 = -c0...-c3

It was me who asked for the - before 0 - otherwise people might think they could just write 0 instead of -0 as parameter
I know that.
But (-) before zero for me is not ok.
If you want a better solution I suggest

ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list (supports parameters -m, -o, -c0-3 and -0.. -9)
or
ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list [supports parameters -m, -o, -c0-3 and -(0...9)]

The meaning is very simple: that you can choose between 0 to 9 compression rate an minus is just a separator of parameters.

Into Dialog box: Configuration - Change button bar now it is:
5. With the command ZIPFROMLIST, you can create a zip file from a list of files. The command field must contain the zip file name, and the parameters field the name of the list file. Alternatively, the zip file name may be put at the start of the parameters field, surrounded by double quotes "" if it contains a space. The list file must contain a list of files to be packed, one file per line (ANSI, UTF-16 or UTF-8, with byte order marker BOM). A parameter like %F may be used for the selected files in the active panel.
Supports the following parameters, put in front of the zip file name (only in the field 'Command'): -m move, -o overwrite without asking, -0 .. -9 compression rate, -c0 encrypt (zip20), -c1 AES128, -c2 AES192, -c3 AES256, -c0pass .. -c3pass encrypt with given password

So, the parameter (compression rate) -0 .. -9 is very clear expose. Exactly what I aks: to be like into help file, witch is very clear. It's a must to have consistency.
BTW, I saw that into TOTALCMD.INC the parameter %F is not mentioned.
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *petermad »

If you want a better solution I suggest

ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list (supports parameters -m, -o, -c0-3 and -0.. -9)
That's OK with me, but then it should be:
ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list (supports parameters -m, -o, -c0..-c3 and -0..-9)
to be consistent. (and without space after ..)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4619
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *white »

How about:

Code: Select all

ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list (supports parameters -m, -o, -c[0-3] and -[0-9])
Eugensyl2
Junior Member
Junior Member
Posts: 43
Joined: 2023-05-20, 15:12 UTC

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *Eugensyl2 »

petermad wrote: 2023-05-27, 09:53 UTC
If you want a better solution I suggest

ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list (supports parameters -m, -o, -c0-3 and -0.. -9)
That's OK with me, but then it should be:
ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list (supports parameters -m, -o, -c0..-c3 and -0..-9)
to be consistent. (and without space after ..)
I'm ok with this.
Eugensyl2
Junior Member
Junior Member
Posts: 43
Joined: 2023-05-20, 15:12 UTC

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *Eugensyl2 »

white wrote: 2023-05-27, 10:49 UTC How about:

Code: Select all

ZIPFROMLIST <archive name> <filelist>=-26;Pack files from list (supports parameters -m, -o, -c[0-3] and -[0-9])
Better!
Should be put also in Help file in the same manner.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *ghisler(Author) »

How about simply
-c0..3 and -0..9
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1246
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *AntonyD »

How about simply
but not more intuitively than it was before.
petermad made a really good suggestion again:

Code: Select all

-c0..-c3 and -0..-9
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *ghisler(Author) »

OK, I can live with that.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *petermad »

Confirmed changed in TC 11.00b5 :-)

But in wcmd_deu.inc the line:
-26="Dateien aus Liste packen (unterstützt Parameter -m, -o, -c0..-c3 and -0..-9)"
should be:
-26="Dateien aus Liste packen (unterstützt Parameter -m, -o, -c0..-c3 und -0..-9)"
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: beta4: ZIPFROMLIST "-0" is annoying

Post by *ghisler(Author) »

OK, German translation fixed, no need for a new bug report.
Author of Total Commander
https://www.ghisler.com
Post Reply