QuickSearch eXtended

Discuss and announce Total Commander plugins, addons and other useful tools here, both their usage and their development.

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Re: QuickSearch eXtended

Post by *Samuel »

Update. Version 2.3.1 is available.

Code: Select all

Version 2.3.1
- Added: Meanwhile in the Total Commander 11 betas there is no way to differentiate if the search is opened from open tabs or from file panel. So QuickSearch eXtended ignores a leading "*" and filters the whole path (instead of the filename only) everywhere.
Sorry, I will not examine the above/under topic. Code contributions are welcome.

I am aware that the additional GUI in the new beta is not visible when filtering open tabs of the right panel. I currently do not plan to add code here. Code contributions are welcome.
massor
Junior Member
Junior Member
Posts: 24
Joined: 2022-05-01, 18:30 UTC

Re: QuickSearch eXtended

Post by *massor »

OneDrive said: "Sorry, there was a problem downloading this file: QuickSearch Extended.zip - Failed". What I'm doing wrong? I must have an account and to login in OneDrive?
User avatar
Wawuschel
Senior Member
Senior Member
Posts: 338
Joined: 2003-02-11, 17:00 UTC

Re: QuickSearch eXtended

Post by *Wawuschel »

Samuel wrote: If you have problems downloading the files try to checkmark two or more files, then they are packed together and you can download them as a full package.
GIF animation: https://abload.de/img/download1yiwk.png
Last edited by Wawuschel on 2023-06-12, 12:39 UTC, edited 1 time in total.
TCmd 11.02 (64 bit) unter Windows 10 (64 bit)
#76996
iana
Senior Member
Senior Member
Posts: 345
Joined: 2010-07-27, 22:00 UTC

Re: QuickSearch eXtended

Post by *iana »

you need to be logged in to a microsoft account (hotmail, outlook, maybe github might work) to be able to download, it could be free traffic was used up.
User avatar
dmocha
Junior Member
Junior Member
Posts: 52
Joined: 2013-05-05, 19:09 UTC
Location: Poland

Re: QuickSearch eXtended

Post by *dmocha »

I confirm, without logging in it is not possible to download any file.
regards
dmocha
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: QuickSearch eXtended

Post by *white »

dmocha wrote: 2023-06-11, 19:04 UTC I confirm, without logging in it is not possible to download any file.
Not confirmed, have you tried as described to select 2 files and download 2 files at once?
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Re: QuickSearch eXtended

Post by *Samuel »

I need to change this, thanks Wawuschel and white for helping out.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: QuickSearch eXtended

Post by *ghisler(Author) »

I have a question about this:
- Added: Meanwhile in the Total Commander 11 betas there is no way to differentiate if the search is opened from open tabs or from file panel. So QuickSearch eXtended ignores a leading "*" and filters the whole path (instead of the filename only) everywhere.
I have tested this with my own tcmatch.dll which I wrote for PinYin search, and it works just fine with the * passed to it:
1. When searching in a normal file list, TC passes just the file names to the dll, so it will only search in the names.
2. When searching in the history list, TC only passes the full path when the user entered a *, so it will search just in names without the *, and in the full path with the *, just as TC does.
So where exactly is your problem that you refuse to even talk about it?
Author of Total Commander
https://www.ghisler.com
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Re: QuickSearch eXtended

Post by *Samuel »

I tried to talk about it here:
viewtopic.php?t=79240

I think we both are right. I use the MatchGetSetOptions 4 here, you probably don't:

Code: Select all

int __stdcall MatchGetSetOptions(int Status) {
    //returns sum of:
    // 1: override internal search                                          -> always do this
    // 2: no leading/trailing asterisk                                      -> always do this
    // 4: file name with path, not just name                                -> always do this
    // 8: allow empty result: longer search strings can return more results -> depends on ini-entry
    int                                                         sum = 7;
    if(INI_allow_empty_result)                                  sum += 8;
    return                                                      sum;
}
I added debugging output to my plugin, so I could see what is given into it. That made me pretty sure about there is no way to differentiate.
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: QuickSearch eXtended

Post by *AntonyD »

2Samuel
By the way, why is the plug-in dialog itself made in a separate executable file and constantly hanging in processes?
After all, if the plugin is called locally, then it can determine where it should draw its window. What happens in the current version? The window "jumps" or something along the coordinates? And when "jumping" - does the code of the programming language 'AutoHotkey' used take into account that the window should be shown again on top of everything?
Last edited by AntonyD on 2023-06-16, 15:57 UTC, edited 1 time in total.
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: QuickSearch eXtended

Post by *ghisler(Author) »

I think we both are right. I use the MatchGetSetOptions 4 here, you probably don't:
Ah, that makes sense!
I could pass two asterisks ** at the start of the search name when the user wants to search the entire path and MatchGetSetOptions 4 is set, would that help? This way it would not break older tcmatch.dll versions.
Or alternatively the plugin could request another option, e.g. MatchGetSetOptions 16 which would tell TC to send ** at the start.
Any better ideas which don't break compatibility?
Author of Total Commander
https://www.ghisler.com
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Re: QuickSearch eXtended

Post by *Samuel »

In my plugin by default "*" already had/has a meaning. So a search for "*abc" activates a special search type.
So I am against using something like "**".

I think there are 2 ways one could go:

1. Keep it as it is now. This is not so bad:
QuickSearch eXtended ignores a leading "*" and filters the whole path (instead of the filename only) everywhere.
2. I would propose to change and use:

Code: Select all

int __stdcall MatchFileW(WCHAR* wcFilter, WCHAR* wcFilename)
to something like

Code: Select all

int __stdcall NewMatchFileW(WCHAR* wcFilter, WCHAR* wcFilename, int Source)
if MatchGetSetOptions returns the 16 flag.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: QuickSearch eXtended

Post by *ghisler(Author) »

1. Keep it as it is now. This is not so bad:
QuickSearch eXtended ignores a leading "*" and filters the whole path (instead of the filename only) everywhere.
Hmm, I thought that the problem was that it didn't search the whole path? Then the situation is indeed not bad...
Author of Total Commander
https://www.ghisler.com
Pawel
Junior Member
Junior Member
Posts: 82
Joined: 2018-12-18, 11:54 UTC
Location: Poland
Contact:

Re: QuickSearch eXtended

Post by *Pawel »

2Samuel
Is it possible to add Dark Mode for QuickSearch eXtended Interface?
https://ibb.co/xFQ5RB1
-Pawel
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Re: QuickSearch eXtended

Post by *Samuel »

Personally I don't like Dark Mode, so it is not planned.
Feel free to contribute.
Post Reply