Wrong chekmark when cm_SwitchHidSys is used in the menu

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Wrong chekmark when cm_SwitchHidSys is used in the menu

Post by *petermad »

This is not a new bug/inconsistency.

If I use the command cm_SwitchHidSys in the menu, it will show a checkmark for enabled also if either showing hidden OR system files is disabled.

I think cm_SwitchHidSys should only show a chekmark if ShowHiddenSystem=1 in wincmd.ini.

And if only one of the two options showing hidden and system files is enabled (ShowHiddenSystem=2 or ShowHiddenSystem=3), using cm_SwitchHidSys should set ShowHiddenSystem=1. Likewise only if ShowHiddenSystem=1 should cm_SwitchHidSys set ShowHiddenSystem=0
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Wrong chekmark when cm_SwitchHidSys is used in the menu

Post by *ghisler(Author) »

There is no right way in this case. A button with cm_SwitchHidSys can never show the right status when only one of the two options is checked. It can only show the right status when either both are set or both aren't. The other cases are a question of definition. I set it when either of the two is enabled (OR), but it would also be legit to check it when both are set (AND). But it is consistent that when you invoke cm_SwitchHidSys while only one of the two is set, it will disable both, and the button gets unchecked.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Wrong chekmark when cm_SwitchHidSys is used in the menu

Post by *petermad »

OK.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply