Fixed [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Galizza
Member
Member
Posts: 167
Joined: 2018-09-07, 05:21 UTC

Fixed [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *Galizza »

 
Hi, if i copy directories on branchview mode using cm_copy /R1, directories dates are not preserved,. Best regards.
 
 
Tc 11.00b9 32Bits // Windows 10 22H2 32Bits
 
Last edited by Galizza on 2023-07-05, 17:15 UTC, edited 1 time in total.
User avatar
petermad
Power Member
Power Member
Posts: 14810
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *petermad »

Confirmed. Both on NTFS and FAT partitions.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *ghisler(Author) »

This is normal: TC does not copy directories in branch view, there are none shown. Missing directories will be created on demand, not copied.
Author of Total Commander
https://www.ghisler.com
Galizza
Member
Member
Posts: 167
Joined: 2018-09-07, 05:21 UTC

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *Galizza »

ghisler(Author) wrote: 2023-06-29, 10:04 UTC This is normal: TC does not copy directories in branch view, there are none shown. Missing directories will be created on demand, not copied.
 

Hi, i think that i didn't explain myself properly or i'm wrong about what cm_copy /R1 should do.

Lets say that this directory structure exist on my system

C:\Wincmd\Plugins\WDX\SHELLDETAILS\


On the left panel i place inside C:\Wincmd\ and i activate branch view, then i select all files and i use  cm_copy /R1 to copy them all to an empty directory on the right panel.

But when i do such thing directory \SHELLDETAILS\ show current date and not original date on right panel.

Maybe i am wrong, but i thought that cm_copy /R1 will work like COPYTREE 1.3 plugin (with his copy timestamps of directories option activated), thank you very much.





 
Last edited by Galizza on 2023-06-29, 11:26 UTC, edited 1 time in total.
User avatar
petermad
Power Member
Power Member
Posts: 14810
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *petermad »

2ghisler(Author)
Missing directories will be created on demand, not copied.
It would be nice though if the date of the created directories could be synchronized with the date of the source after copying, if feasible.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
sa16
Senior Member
Senior Member
Posts: 217
Joined: 2021-09-10, 07:15 UTC

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *sa16 »

2petermad
And if the target directory already exists?
User avatar
petermad
Power Member
Power Member
Posts: 14810
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *petermad »

And if the target directory already exists?
I think that in that case the date of the target directory should be left untouched, just like it is when copying normally between two panels.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *ghisler(Author) »

It's difficult to add, but should be doable:
1. Put the paths of all the newly created directories in a list
2. Sort the list so the deepest directories come first
3. At the end of copying, go through the list and copy the folder dates
The question is whether the dates should still be copied when the user aborts the copy operation. It could take a lot of time when there are 1000s of new directories...
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14810
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *petermad »

The question is whether the dates should still be copied when the user aborts the copy operation.
That would be prefereable. If not,, then maybe give a warning in the abort dialog: "Folder dates will not be updated"
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *Usher »

For me current timestamp of a directory means that operations for this directory weren't completed (f.e. copy operation was aborted).

There's another problem: What to do with timestamps when you see a message with "Skip", "Retry", "Skip all", "Abort" buttons.
Last edited by Usher on 2023-07-02, 20:23 UTC, edited 1 time in total.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *ghisler(Author) »

There's another problem: What to do when you see a message with "Skip", "Retry", "Skip all", "Abort" buttons.
What problem do you mean?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14810
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *petermad »

What problem do you mean?
I guess with "Skip All" and "Abort": should the already written directories have their timestamp synchronized?.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *Usher »

2petermad
Agree, and leave current timestamp for every "Skip"ped case...
Andrzej P. Wozniak
Polish subforum moderator
Galizza
Member
Member
Posts: 167
Joined: 2018-09-07, 05:21 UTC

Re: Fixed [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *Galizza »

 
Fixed on Tc 11.00b10 32Bits // Windows 10 22H2 32Bits
User avatar
petermad
Power Member
Power Member
Posts: 14810
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Fixed [Tc 11.00b9] cm_copy /R1 ; Directory dates are not preserved,

Post by *petermad »

history.txt wrote:02.07.23 Added: Copy files, branch view: Also keep directory time stamps when copying with the background transfer manager (32/64)
30.06.23 Added: Copy files, branch view: When using option "Keep relative paths", copy directory timestamps of directories which didn't exist yet (32/64)
Confirmed fixed in TC 11.00b10 x64 and x86 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply