[TC 11.00rc1] Background Transfer Manager: focus rectangle issues

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *white »

Issue 1:
  • Use TC in normal mode (not dark mode)
  • Open the Background Transfer Manager using the mouse
  • Press the Tab key repeatedly
  • The focus shifts to the different controls, but there is not focus rectangle.
This doesn't happen in dark mode or when the Background Transfer Manager is opened using the keyboard.


Issue 2:
In dark mode, the focus rectangle around "Speed limit" has full width instead of the width of the text.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *petermad »

The focus shifts to the different controls, but there is not focus rectangle.
Not confirmed - tested with TC 11.00rc1 32bit and 64bit on Windows 7 and 10.

In dark mode, the focus rectangle around "Speed limit" has full width instead of the width of the text.
Confirmed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Dalai
Power Member
Power Member
Posts: 9393
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *Dalai »

IIRC the focus rectangle only appears when the system option to show underlined characters is enabled (maybe it's also shown when the Alt key is pressed). How is it configured on your system?

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *white »

Dalai wrote: 2023-07-15, 16:23 UTC IIRC the focus rectangle only appears when the system option to show underlined characters is enabled (maybe it's also shown when the Alt key is pressed).
Confirmed. On my system underlined characters are hidden. In all other dialogs the rectangle seems to appear when pressing Tab.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *petermad »

I can confirm that the rectangle is not shown when underlining hotkeys is disabled (Win 7) other wise it works fine: https://tcmd.madsenworld.dk/btmtab.mp4
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *ghisler(Author) »

It only seems to happen when opening the background transfer manager via mouse, not via keyboard.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *white »

I think it has to do with the way you do keyboard handling in that dialog. If I add an access key to the string "Speed limit" in that dialog, the underlining also doesn't appear when pressing Alt and the access key doesn't work.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *ghisler(Author) »

Indeed it seems that I have to send WM_UPDATEUISTATE myself to the dialog when Alt or Tab is being pressed. This shows the focus and underlines. It's strange that I don't have to do this for regular forms, just for these dialogs created via Windows functions.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *white »

HISTORY.TXT wrote:17.07.23 Fixed: Background transfer manager: When opened via mouse, pressing Tab didn't show focus rectangles for buttons (must call WM_UPDATEUISTATE when Tab or Alt is being pressed) (32/64)
Tested OK using TC 11.00rc2 32-bit and 64-bit.
I also tried adding an access key to the text Speed limit. The access key now becomes underlined when pressing Alt. So underlining and focus rectangle work now in this dialog. By the way, using the access key does not work.
white wrote: 2023-07-15, 14:24 UTC Issue 2:
In dark mode, the focus rectangle around "Speed limit" has full width instead of the width of the text.
Unchanged.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *petermad »

history.txt wrote:17.07.23 Fixed: Background transfer manager: When opened via mouse, pressing Tab didn't show focus rectangles for buttons (must call WM_UPDATEUISTATE when Tab or Alt is being pressed) (32/64)
Confirmed fixed in TC 11.00rc2

white wrote:I also tried adding an access key to the text Speed limit. The access key now becomes underlined when pressing Alt.
Yes, but the access key still does not work - only gives an error sound.

white wrote: Issue 2:
In dark mode, the focus rectangle around "Speed limit" has full width instead of the width of the text.
Confirmed not fixed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *ghisler(Author) »

Yes, but the access key still does not work - only gives an error sound.
Sorry, underlined hotkeys are currently not supported in these native dialogs. I don't currently have any plans to add this.
In dark mode, the focus rectangle around "Speed limit" has full width instead of the width of the text.
I tried to find a way to implement this, but it's not so easy. I'm drawing the text and the focus myself, but I don't know what distances are used by Windows on checkboxes around text, so I simply draw it at the control boundaries.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *white »

2ghisler(Author)
OK, call it known issues then and move it to Behaviour which will not be changed?

BTW, are there more dialogs where you do this? Or is this the only one?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *ghisler(Author) »

The only native Windows dialogs are the background transfer manager, then the background copy dialog (F5-Enter-Background) and the "Wait" dialog when you open multiple files one by one with F4 in a multiple document editor.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Background Transfer Manager: focus rectangle issues

Post by *ghisler(Author) »

Moderator message

Moved to will not be changed
Author of Total Commander
https://www.ghisler.com
Post Reply