[TC 11.00rc2] CD Tree - Tabstop for F2 re-scan tree, placement of Quick search label+button

[white]

* Open menu option Commands/CD Tree (Alt+F10)

Issue 1
The TabStop property is not set for the "F2 re-scan tree" button. I understand why the Quick search editbox doesn't have a tab stop, but "F2 re-scan tree" is unrelated and should have a tab stop.

Issue 2
Resize the dialog window and pay attention to the position of the Quick search label and the Quick search editbox.
The Quick search label and the Quick search editbox belong together, but do not stay together.
If it is possible, perhaps it is better to make the "F2 re-scan tree" right aligned and put the Quick search editbox at a fixed position or limit its movement.

[Horst.Epp]

2. There is no such effect here.
The label and the edit box stay in line whatever I do with the window.

[white]

The label and the edit box stay in line whatever I do with the window.

They stay in line, but not together, do they?

[Horst.Epp]

The label and the edit box stay in line whatever I do with the window.

They stay in line, but not together, do they?

That's right

[ghisler(Author)]

The behaviour is intentional. Let me explain:
1. I want to keep the cursor in the list of directories for scrolling, quick search etc. Therefore the quick search field isn't an edit box, it cannot be focused. It just shows what you type. The refresh button is also just a "speed button" which can't be focused either - just press the hotkey shown on it instead.

2. I could make the label right aligned, but then the start of the text would be lost when you make the dialog too narrow.

[white]

1. .. The refresh button is also just a "speed button" which can't be focused either - just press the hotkey shown on it instead.

But there is no reason for it to be a speed button.
BTW, F2 doesn't work when the focus is on one of the buttons at the bottom.

The behaviour is intentional. Let me explain:
2. I could make the label right aligned, but then the start of the text would be lost when you make the dialog too narrow.

Well, if you make the window very narrow, more things happen. The option "Everything" is no longer visible and "Quick search" is wrapped showing only the top of the "h".
Either you should make the minimum width larger or don't care about things falling off.

[ghisler(Author)]

I have made the following changes, please check them:
23.07.23 Fixed: Alt+F10 Tree: Support hotkeys F1, F2 and Ctrl+R also when the input focus wasn't on the listbox (32/64)
23.07.23 Fixed: Alt+F10 Tree: Made "quick search" label right-aligned (32/64)

[Horst.Epp]

Looks good now

[white]

23.07.23 Fixed: Alt+F10 Tree: Support hotkeys F1, F2 and Ctrl+R also when the input focus wasn't on the listbox (32/64)
23.07.23 Fixed: Alt+F10 Tree: Made "quick search" label right-aligned (32/64)

Tested OK using TC 11.00rc3.

While testing, I thought the Tree dialog (Alt+F10) looked better on 32-bit TC. So I compared to see what was different. It turns out, it's the position of the Everything option which is more to the right on 32-bit TC. Because the gab is wider on 32-bit TC, it stands out more as a separate option. Screenshot

I also noticed the default width of the dialog is smaller on 32-bit TC. If you start 32-bit TC with a clean ini, the "F2 re-scan tree" doesn't fit in the window. If you start 64-bit TC with a clean ini, all the buttons fit in the window. Screenshot

If you start 64-bit with a clean ini, open the Tree (Alt+F10), close the Tree, execute cm_Exit 2, open the Tree (Alt+F10), you see that there is more room after the "F2 re-scan tree" button. That's because the button is a bit smaller on 32-bit TC. Screenshot

[ghisler(Author)]

Thanks for confirming the fixes!

While testing, I thought the Tree dialog (Alt+F10) looked better on 32-bit TC. So I compared to see what was different. It turns out, it's the position of the Everything option which is more to the right on 32-bit TC. Because the gab is wider on 32-bit TC, it stands out more as a separate option.

I will move it a bit to the right.

I also noticed the default width of the dialog is smaller on 32-bit TC.

Strangely it's wider in 32-bit in the designer, 419 vs 405 pixel. It's because Delphi counts the borders as part of the window, Lazarus doesn't. I will keep it as it is for now.

the button is a bit smaller on 32-bit TC.

I will make it the same width as in 64-bit.

[ghisler(Author)]

Due to differences between Delphi and Lazarus, I was unable to make the 2 dialogs 100% identical, sorry.

Moderator message

Moved to will not be changed