Not a bug: Sync Dirs Tool behaviour when pressing F4

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Galizza
Member
Member
Posts: 167
Joined: 2018-09-07, 05:21 UTC

Not a bug: Sync Dirs Tool behaviour when pressing F4

Post by *Galizza »

 
Hi, i have encountered a strange behavior if by mistake you press F4 on a directory name.

If you press F4 on a directory that shows the arrow  <-  nothing happens.

If you press F4 on a directory that shows the arrow  ->  the directory is unmarked for copying and Notepad opens showing the message "File not found C:\Directory Name\.txt.  Do you want to create a new one ?"

And if you press F4 on a directory that does not show any arrow, Notepad opens showing the message "File not found C:\Directory Name\.txt.  Do you want to create a new one ?"

Similar behaviour happens with F3, best regards.

Tc 11.02 x86
 
Last edited by Galizza on 2023-12-27, 12:08 UTC, edited 1 time in total.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Sync Dirs Tool behaviour when pressing F4

Post by *ghisler(Author) »

F3 and F4 open the selected files and folders on the left side, while
Shift+F3 and F4 open the selected files and folders on the right side.

The selection gets removed so you don't copy it by accident after editing it manually.
Edit: It should not remove the selection from directories, so I will change that.

While it may not be logical to also open directories, it may be useful in some cases. For example, there are Lister plugins which allow to view directories, e.g. VisualDirSize. If I remove that now, I'm sure to get complaints from other users, so I prefer to keep it.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Not a bug: Sync Dirs Tool behaviour when pressing F4

Post by *ghisler(Author) »

The copy direction should no longer be removed in Total Commander 11.03 RC1 when you press F4 on a folder, please check it!
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Not a bug: Sync Dirs Tool behaviour when pressing F4

Post by *ghisler(Author) »

Can anyone test this please?
1. Open the "Synchronize dirs" tool with two directories which each contain at least one subdirectory not present on the other side
2. Compare with option "Subdirs" and "Empty Directories"
3. Place cursor on a directory only present on the left side (has arrow left to right)
4. Press F4
-> In older version, this would remove the arrow, in 11.03RC1 it doesn't. It does open the directory in the editor, but most can't handle that.
5. Press Shift+f4
-> nothing happens because there is no directory on the right
6. Place cursor on a directory only present on the right side (has arrow right to left)
7. Press F4
-> nothing happens because there is no directory on the left
8. Press Shift+f4
-> In older version, this would remove the arrow, in 11.03RC1 it doesn't. It does open the directory in the editor, but most can't handle that.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: Not a bug: Sync Dirs Tool behaviour when pressing F4

Post by *JOUBE »

ghisler(Author) wrote: 2024-01-22, 08:08 UTC Can anyone test this please?
Tc11.03RC1 32bit: works well as you descripted and expected: no remove of arrows, editor is opened.
Tc11.03RC1 64bit: works well as you descripted and expected: no remove of arrows, editor is opened.

This is fixed.

But:

I myself do not use this function. So I do not know:

Is it ok, that all files in the subfolders of the selected folder are also opened in the editor at pressing F4/Shift+F4? (In my case I opened a folder with F4/Shift+F4 which have a saved webpage ('page.html' file and folder 'page-Dateien') in it: All files (*.css, *.js, images ...) of the subfolder 'page-Dateien' are also opened with the text-editor at F4/Shift+F4 on the patent folder of that subfolder)

Joube
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Not a bug: Sync Dirs Tool behaviour when pressing F4

Post by *ghisler(Author) »

Thanks for confirming the fix!

It depends on your editor what happens when you pass a directory to it instead of a file name. Nothing happens with notepad, but some multiple document editors may open all files in that directory.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: Not a bug: Sync Dirs Tool behaviour when pressing F4

Post by *JOUBE »

ghisler(Author) wrote: 2024-01-22, 10:30 UTC It depends on your editor what happens when you pass a directory to it instead of a file name. Nothing happens with notepad, but some multiple document editors may open all files in that directory.
So is it desirable that all files in the subdirectories are also opened? My editor opens all, all, all, all... Or is it not better not to pass the subfolders?

[Edit]
2ghisler(author)
An answer is not required. I don't use the function anyway and those who noticed it here should take care of it because they use it. So my question is to be understood more as a hint.
[/Edit]

Requested answer for the bug is: Yes, fixed.

Joube
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Not a bug: Sync Dirs Tool behaviour when pressing F4

Post by *ghisler(Author) »

So is it desirable that all files in the subdirectories are also opened? My editor opens all, all, all, all... Or is it not better not to pass the subfolders?
Some users may find this useful, so I'm not going to remove it.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: Not a bug: Sync Dirs Tool behaviour when pressing F4

Post by *JOUBE »

So, confirmed fixed. Ready to move to "fixed bugs forum".
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Not a bug: Sync Dirs Tool behaviour when pressing F4

Post by *ghisler(Author) »

Moderator message

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
Post Reply