[11.50 b1] Problem to set word size for internal packer

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
MaxX
Power Member
Power Member
Posts: 1117
Joined: 2012-03-23, 18:15 UTC
Location: UA

[11.50 b1] Problem to set word size for internal packer

Post by *MaxX »

Subj.
I try to set 273 - nothing happens. Also any "7ZwordSizeLZMA2_9" string gets removed from wincmd.ini.
I try to set 256 - it shows as saved. Also I get 7ZwordSizeLZMA2_9=273 in wincmd.ini.
I try to set 128 - it shows as saved. Also I get 7ZwordSizeLZMA2_9=192 in wincmd.ini.
Same for regular LZMA.

Please, see also this screen capture:
https://i.imgur.com/kd6Tsxp.gif

p.s.
Lots of thanks for internal 7zip.
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
petermad
Power Member
Power Member
Posts: 15561
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *petermad »

I can confirm that 7ZwordSizeLZMA2_x, 7ZwordSizeLZMA_x, 7ZwordSizePPMd_x are always set one level higher in wincmd.ini than what is shown in the dialog - and the highest level cannot be set.

Also 7ZdictSizePPMd_x is set one level too high (but not 7ZdictSizeLZMA2_x and 7ZdictSizeLZMA_x).

When setting 7ZdictSizePPMd_x to default in the dialog it is set to -64 in wincmd.ini instead of being removed.
License #524 (1994)
Danish Total Commander Translator
TC 11.50b4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1383a
TC 3.60b4 on Android 6, 13 & 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
AntonyD
Power Member
Power Member
Posts: 1387
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [11.50 b1] Problem to set word size for internal packer

Post by *AntonyD »

Also in this GIF I see some visual glitch for the combobox "Solid block size:"
The top border of this object is not drawn.
And for label "/16" on a right side of the combobox "Number of CPU threads" - it's too close.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 15561
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *petermad »

Also in this GIF I see some visual glitch for the combobox "Solid block size:"
The top border of this object is not drawn.
Already reported here: https://ghisler.ch/board/viewtopic.php?t=84080
License #524 (1994)
Danish Total Commander Translator
TC 11.50b4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1383a
TC 3.60b4 on Android 6, 13 & 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49243
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *ghisler(Author) »

This should be fixed in 11.50 beta 2, please check!
Author of Total Commander
https://www.ghisler.com
User avatar
MaxX
Power Member
Power Member
Posts: 1117
Joined: 2012-03-23, 18:15 UTC
Location: UA

Re: [11.50 b1] Problem to set word size for internal packer

Post by *MaxX »

Confirm fixed. Now gui shows the same as in ini. Thanks.
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49243
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *ghisler(Author) »

Thanks for checking!

Moderator message from: ghisler(Author) » 2024-10-17, 07:19 UTC

Moved to fixed bugs.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 15561
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *petermad »

Not quite fixed yet. When setting the word size for PPMd to default in the config dialog, the 7ZdictSizePPMd_<rate> is not removed from wincmd.ini - it is set to -256

For the 3 other methods the 7ZdictSize<method>_<rate> is removed from the .ini file when set to default.

Moderator message from: petermad » 2024-10-17, 12:17 UTC

Moved from "TC fixed bugs" back to "TC11.x bug reports (English)"
License #524 (1994)
Danish Total Commander Translator
TC 11.50b4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1383a
TC 3.60b4 on Android 6, 13 & 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49243
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *ghisler(Author) »

I didn't notice that, thanks for reporting.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 15561
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *petermad »

history.txt wrote:17.10.24 Fixed: Configuration - Options - 7-Zip packer: 7ZdictSizePPMd_<rate>=value wasn't removed when setting PPMD dictionary size to 'Default' (32/64)
Only partly confirmed.

In TC 11.50b1 when I changed the compression ration, then the "Dictionary size" and "Word size" changed to the saved size for that compression ratio - but not son in beta2 and beta3 - as they should

But in TC 11.50b2-b3 - for all 3 compression methods the values shown in the conf. dialog are saved correctly to the .ini file for each compression ratio, but the 7ZdictSize and 7ZwordSize are not read from the .ini file when the compression ratio is changed in the Conf. dialog.

For example if I have:

Code: Select all

7zRate=9
7zMethod=LZMA
7ZdictSizeLZMA_9=-64
7ZwordSizeLZMA_9=8
7ZdictSizeLZMA_6=-256
7ZwordSizeLZMA_6=12
then when opening the Conf. dialog, a compresion ratio of 9, and Compression method LZMA with a Dictionary size of 256k and a Word size of 12 is shown as expected.

But if I the change the compression ratio to 6 in the conf. dialog, then the Dictionary and Word size are not changed even though they should be changed to 64k and 8.

If I change the Compression method to for example LZMA2, then change the compression ratio to 6 and change the method back to LZMA, then the Dictionary and Word size are read correctly and show 64k and 8.
License #524 (1994)
Danish Total Commander Translator
TC 11.50b4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1383a
TC 3.60b4 on Android 6, 13 & 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49243
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *ghisler(Author) »

But if I the change the compression ratio to 6 in the conf. dialog, then the Dictionary and Word size are not changed even though they should be changed to 64k and 8.
Only partially confirmed - when I change the value in the edit box "other", then it gets loaded from the ini, but not when clicking on the radio buttons.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 15561
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *petermad »

when I change the value in the edit box "other", then it gets loaded from the ini
Confirmed.
License #524 (1994)
Danish Total Commander Translator
TC 11.50b4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1383a
TC 3.60b4 on Android 6, 13 & 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 15561
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *petermad »

history.txt wrote:24.10.24 Fixed: Configuration - Options - 7-Zip packer: Clicking on compression rate radio buttons didn't load previously saved values into comboboxes (32/64)
Confirmed fixed in TC 11.50b4 :-)

Currently I have to click "Apply" when I have set the value for one compression rate and shift to another, otherwise the values are not saved. Maybe the values in the combo boxes should be automatically saved when the user changes the compression rate.
License #524 (1994)
Danish Total Commander Translator
TC 11.50b4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1383a
TC 3.60b4 on Android 6, 13 & 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49243
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *ghisler(Author) »

Thanks for confirming the fix!
Maybe the values in the combo boxes should be automatically saved when the user changes the compression rate.
I don't think that anything should be saved automatically in this dialog.
It would be nice to temporarily keep the not visible values, but that would make the whole thing far more complex, so I have to decline.

Moderator message from: ghisler(Author) » 2024-10-30, 19:42 UTC

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 15561
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.50 b1] Problem to set word size for internal packer

Post by *petermad »

OK - it was just a thought :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.50b4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1383a
TC 3.60b4 on Android 6, 13 & 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply