solved [TC 11.50b4] Conflicting hotkeys in string 5215 and 5216

[petermad]

In the internal English there is a conflicting hotkey D in string 5215 and the new string 5216::

Code: Select all

5215="&Drag&&Drop (copying files with mouse)"
5216="&Drag&&Drop to the button 'F8 Delete'"

May I suggest to change string 5216 to:

Code: Select all

5216="Drag&&Drop to the &button 'F8 Delete'"

Updated Dglrange.txt files: https://tcmd.madsenworld.dk/Dglrange1150b4.zip

[ghisler(Author)]

This should be fixed in beta 5, please check!

[petermad]

Confirmed fixed in TC 11.50b5

String changed to:

Code: Select all

5216="Drag&&Drop to the 'F8 Delete' &button"

Moderator message from: petermad » 2024-11-06, 19:25 UTC

Moved to "TC fixed bugs" from "TC11.x bug reports (English)"

[sa16]

2petermad
It doesn't work for me:

Code: Select all

5216="Drag&&Drop to the 'F8 Delete' &button"

That's how it works:

Code: Select all

5216="Drag and Drop to the 'F8 Delete' &button"

Apparently due to && before &b.

[white]

It doesn't work for me:

Code: Select all

5216="Drag&&Drop to the 'F8 Delete' &button"

Confirmed for 32-bit only.

[sa16]

2white
Yes, I only checked on x32.

[petermad]

2petermad
It doesn't work for me:

Code: Select all

5216="Drag&&Drop to the 'F8 Delete' &button"

well "Drag&&Drop to the 'F8 Delete' &button" is the string used by Internal English, not something I made up myself.

But it is correct that in 32bit TC the b-hotkey does not work for neither internal English nor for external wcmd_eng.lng

There 5 are other strings with && in them, and they all work in 32bit TC:

Code: Select all

5215="&Drag&&Drop (copying files with mouse)"
5381="C&ustom column configurations (sort with drag&&drop):"
6268="&Compare left && right\tCtrl+F3"
6502="&File types (sort by using drag&&drop, edit with <spacebar>):"
6612="Searc&h && Replace"

But except for string 6268 (which is in a menu) they ONLY work because the hotkey is placed before &&. If I move the hotkey behind && then they ALSO don't work in 32bit TC - so there is a bug in 32bit TC's handling of &&

[sa16]

If I move the hotkey behind && then they ALSO don't work in 32bit TC

Exactly:

Apparently due to && before &b.

[ghisler(Author)]

Confirmed, will be fixed in the next beta.

[white]

08.11.24 Fixed: Alt+underlined letter hotkeys not working if the string contained && before &hotkey (32)

Tested OK using TC 11.50b6 32-bit and the option "Drag&&Drop to the 'F8 Delete' &button".

[petermad]

Confirmed fixed for these strings:

Code: Select all

5215="&Drag&&Drop (copying files with mouse)"
5216="&Drag&&Drop to the 'F8 Delete' &button"

But if I change these strings:

Code: Select all

5381="C&ustom column configurations (sort with drag&&drop):"
6502="&File types (sort by using drag&&drop, edit with <spacebar>):"
6612="Searc&h && Replace"

to:

Code: Select all

5381="Custom column configurations (sort with drag&&dr&op):"
6502="File types (sort by using drag&&dr&op, edit with <spacebar>):"
6612="Search && Repl&ace"

where the hotkey is AFTER && - then these hotkeys doesn't work but give an error sound.

I am afraid that the general handling of strings with && is broken in 32bit TC

[sa16]

08.11.24 Fixed: Alt+underlined letter hotkeys not working if the string contained && before &hotkey (32)

Confirmed fixed.

5381="C&ustom column configurations (sort with drag&&drop):"
6502="&File types (sort by using drag&&drop, edit with <spacebar>):"
6612="Searc&h && Replace"

This works for me.

5381="Custom column configurations (sort with drag&&dr&op):"
6502="File types (sort by using drag&&dr&op, edit with <spacebar>):"
6612="Search && Repl&ace"

There are problems with this. I confirm.

[petermad]

Actually these does not work in 64bit TC either:

Code: Select all

5381="Custom column configurations (sort with drag&&dr&op):"
6502="File types (sort by using drag&&dr&op, edit with <spacebar>):"

I just don't get an error beep when using the hotkey in 64bit TC as I do in 32bit TC

This one (in MRT) does work in 64bit TC though:

Code: Select all

6612="Search && Repl&ace"

Setting hotkeys after && should work for all strings - otherwise the translators should be warned against doing so.