Problem with external 7z in 11.50b7

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

ghisler(Author) wrote: 2024-11-26, 10:46 UTC But I found a description on how to grant the right via security policy:
Let's hope everything works out for you now.
lelik007
Member
Member
Posts: 173
Joined: 2021-04-20, 06:37 UTC

Re: Problem with external 7z in 11.50b7

Post by *lelik007 »

2ghisler(Author)
I didn't know that I have to enable the large page mode function system wide (7-zip help for -slp explains that "To install this feature, you must run the 7-Zip File Manager with administrator's rights at least once, close it, and then reboot the system.").
To disable LP for your system completely you should delete an owner of the policy, if you so choose 1.
viewtopic.php?p=464487#p464487
This is why I'm referring not 7-zip help, but 7-max help where it's more detailed.
lelik007
Member
Member
Posts: 173
Joined: 2021-04-20, 06:37 UTC

Re: Problem with external 7z in 11.50b7

Post by *lelik007 »

2AkulaBig
I've tried right now with new tcbit7z.dll , and no, I see clearly that -slp is not used. And as told you before it will never work without the appropriate WinAPI calls described here:
https://learn.microsoft.com/en-us/windows/win32/memory/large-page-support
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

I think I figured it out: It's not sufficient to call SetLargePageMode. I also need to call AdjustTokenPrivileges to request the SE_LOCK_MEMORY_NAME. You can test the dll from here:
https://www.totalcommander.ch/beta/tcbit7z-priv.zip

It will show an error when the user doesn't have the right to request the SE_LOCK_MEMORY_NAME privilege.
Author of Total Commander
https://www.ghisler.com
lelik007
Member
Member
Posts: 173
Joined: 2021-04-20, 06:37 UTC

Re: Problem with external 7z in 11.50b7

Post by *lelik007 »

2ghisler(Author)
Yes, this .dll has -slp enabled, it's clearly seen in Task Manager, you have less time packing and even TC's progress bar moves... with small jumps It's hard to explain but it should be this way when LP mode works.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

Great, thanks for testing! I will include these new dlls in beta 8.
Author of Total Commander
https://www.ghisler.com
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

Fabulous! You did it!
[img]https://i.ibb.co/K9Sn7dx/2024-11-27-154905.png[/img]
[img]https://i.ibb.co/Cv0k0hx/2024-11-27-155703.png[/img]
[img]https://i.ibb.co/Zhv85nJ/2024-11-27-155823.png[/img]
[img]https://i.ibb.co/Wxyyqpj/2024-11-27-161136.png[/img]
There is a small problem. This option cannot be disabled. The screenshot shows that both with and without -slp the packaging time is the same. I'm happy with it anyway :) But it's better to fix it.
I'll do some more tests in the meantime.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

This option cannot be disabled.
Did you close and re-open Total Commander before using 7-zip without -slp? I don't think it's possible without restarting.
Author of Total Commander
https://www.ghisler.com
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

ghisler(Author) wrote: 2024-11-27, 11:46 UTC
This option cannot be disabled.
Did you close and re-open Total Commander before using 7-zip without -slp? I don't think it's possible without restarting.
It's clear. I remembered that you wrote about this earlier. And I didn't reboot TC. I'll check it now. We still need to carry out a number of tests.
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

Yes, after reboot -slp was disabled.
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

Fully tested the latest changes. Everything works. Deleting from an encrypted archive, adding a file to a subdirectory.
There remains one problem that has been there since the first beta. The packing speed of an external packer is much lower than that of an internal packer. Even with -slp you can see from the screenshots, that my test archive is packed 25 seconds faster by an external archiver than by an internal one. I again replaced TC7z.dll and TC7z64.dll with libraries from the 7z installer and you can see that the packaging time was reduced from 05:15 to 05:02. That is, the changes are noticeable. Please see if something can be done about this.
[img]https://i.ibb.co/BPsyMfH/2024-11-27-172658.png[/img]
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

In b8, the packaging speed with 7z libraries instead of TC7Z and TC7Z64 began to match the packaging speed of external 7z! 04:51. So the question is removed. All the same, to open other formats, libraries must be replaced.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

Moderator message from: ghisler(Author) » 2024-12-02, 16:56 UTC

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
Post Reply