[TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 5464
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *white »

  • Go to the Total Commander program folder.
  • Select TOTALCMD.EXE and TOTALCMD64.EXE.
  • Execute cm_IntCompareFilesByContent.
  • Click the Next difference button.
  • Click the Previous difference button.
  • Click the Next difference button.
    Nothing happens. You have to click it again.
This seems to only happen when there's a difference in the first line. And it only happens at the beginning, not when you alternate Next and Previous further on in the file.
User avatar
MaxX
Power Member
Power Member
Posts: 1157
Joined: 2012-03-23, 18:15 UTC
Location: UA

Re: [TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *MaxX »

11.03 acts the same way.
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
white
Power Member
Power Member
Posts: 5464
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *white »

MaxX wrote: 2024-12-24, 23:32 UTC 11.03 acts the same way.
The feature was added in Windows Commander 4.0. I tested Windows Commander 4.03 and it acts the same way..
User avatar
AntonyD
Power Member
Power Member
Posts: 1453
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *AntonyD »

For me, the main problem here is that Total does not indicate WHAT exactly it considered the difference.
YES, some parts of the binary representation are tinted red. BUT! there can be them in one line up to 5/7
different places, not consecutive!!! This can be called "islands" in the "sea" of solid text of 1 line, imho.
Those - according to the logic of a simple comparison, Total should demand from me press the Next difference
button up to 5/7 times? Or how is this supposed to work?
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49881
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *ghisler(Author) »

Confirmed, it happens because searching for the previous difference reaches the top of the file, setting the last found index to -1. Therefore the next click on "Next difference" actually finds the FIRST difference again. I will change it.
For me, the main problem here is that Total does not indicate WHAT exactly it considered the difference.
It's actually explained well in the help:
Next difference
Jumps to the next difference found. A continuous block of different lines will be regarded as ONE difference.
A line is considered different if there is at least one different character/byte on that line.
Author of Total Commander
https://www.ghisler.com
User avatar
MaxX
Power Member
Power Member
Posts: 1157
Joined: 2012-03-23, 18:15 UTC
Location: UA

Re: [TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *MaxX »

So, is that a bug or not?
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49881
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *ghisler(Author) »

Yes it is - please try Total Commander 11.50 final!
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5464
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *white »

HISTORY.TXT wrote:26.12.24 Fixed: Compare by content, binary mode: clicking on Next difference, previous difference, next difference stayed on the first difference if the files started with a different line (32/64)
Tested OK using TC 11.50 32-bit and 64-bit.
User avatar
AntonyD
Power Member
Power Member
Posts: 1453
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *AntonyD »

It looks like in terms of the definition of the problem from the first post - it looks like this situation is now working correctly.
We can put a stamp "Fixed".
#146217 personal license
User avatar
white
Power Member
Power Member
Posts: 5464
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50rc4] Compare by Content: Binary compare, Next does not always work if there's a difference in the beginning

Post by *white »

Moderator message from: white » 2025-01-03, 15:02 UTC

Moved topic
» from TC11.x bug reports (English) to TC Fixed bugs
Post Reply