[TC11.51 RC2] Checksum verification

[Infector]

I have an sfv file where the leading zero in the checksum was somehow lost (4519F2F instead of 04519F2F). In this case, if 123.mp3 exist or not, TC give the same result:

Code: Select all

123.sfv:
Errors: 0
OK: 0, not found: 0, read error: 0, wrong checksum: 0

If the leading zero was returned into the sfv file I am getting expected result "Cannot open input file"

Code: Select all

123.sfv:
Cannot open input file 123.mp3!
Errors: 1
OK: 0, not found: 1, read error: 0, wrong checksum: 0

I also noticed a strange behaviour, if I rename the file to test.mp3 (whether the file exists on fs or not) with a checksum of 4519F2F in sfv, I get:

Code: Select all

Cannot open input file 4519F2F!.
Errors: 1
OK: 0, not found: 1, read error: 0, wrong checksum: 0

If leading zero was returned in the sfv file, the result for test.mp3 is correct

Code: Select all

123.sfv:
Cannot open input file test.mp3!
Errors: 1
OK: 0, not found: 1, read error: 0, wrong checksum: 0

[white]

I have an sfv file where the leading zero in the checksum was somehow lost (4519F2F instead of 04519F2F). In this case, if 123.mp3 exist or not, TC give the same result:

Note that if checksums don't have the correct length, TC will not recognize them as such and treat the line as comment.

I also noticed a strange behaviour, if I rename the file to test.mp3 (whether the file exists on fs or not) with a checksum of 4519F2F in sfv, I get:

Code: Select all

Cannot open input file 4519F2F!.
Errors: 1
OK: 0, not found: 1, read error: 0, wrong checksum: 0

Note that TC also supports that the filename and checksum are swapped. So in your case, the filename length is 8 and interpreted as the checksum and the code (with length 7) as the filename.

Both these things have to do with TC being flexible and not working with a strict format.

[Infector]

Note that if checksums don't have the correct length, TC will not recognize them as such and treat the line as comment.

For me it looks a bit strange when TC haven't found a valid checksum and does not give an error or warning.
Maybe in that case TC should give an error? Something like "checksum missing"

[white]

Maybe in that case TC should give an error? Something like "checksum missing"

Answer from another thread:

Exactly, lines which do not contain a pair of checksum and file name will be ignored. There are checksum files with comments made by other tools, and I don't want to show errors for such lines.

[ghisler(Author)]

Total Commander cannot recognize checksums with the wrong length. Trying to handle them would lead to a lot of problems, e.g. it would no longer be possible to decide whether a checksum is a full length MD5 or a shortened SHA1 with left out zeroes. All checksum tools I know always include leading zeroes.

Moderator message from: ghisler(Author) » 2025-01-26, 08:53 UTC

Moved to will not be changed